This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Closes #5715: Login storage refactor #6128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6128 +/- ##
============================================
+ Coverage 78.25% 78.43% +0.18%
+ Complexity 4580 4414 -166
============================================
Files 606 573 -33
Lines 21973 21193 -780
Branches 3199 3074 -125
============================================
- Hits 17194 16622 -572
+ Misses 3462 3323 -139
+ Partials 1317 1248 -69 Continue to review full report at Codecov.
|
grigoryk
force-pushed
the
issue5715LoginStorage
branch
from
304cbe7
to
1a8ea76
Compare
4 tasks
grigoryk
changed the title
|
@csadilek when this lands, can you make an AC dot release at the same time? We'll need one for 4.0 anyway. |
grigoryk
force-pushed
the
issue5715LoginStorage
branch
from
1a8ea76
to
d856eac
Compare
csadilek
approved these changes
Mar 2, 2020
...ce/sync-logins/src/main/java/mozilla/components/service/sync/logins/SyncableLoginsStorage.kt
Outdated
Show resolved
Hide resolved
components/concept/storage/src/main/java/mozilla/components/concept/storage/LoginsStorage.kt
Outdated
Show resolved
Hide resolved
components/concept/storage/src/main/java/mozilla/components/concept/storage/LoginsStorage.kt
Outdated
Show resolved
Hide resolved
grigoryk
force-pushed
the
issue5715LoginStorage
branch
2 times, most recently
from
fe7abdb
to
bdf9f31
Compare
This refactor changes how (most) consumers are expected to interact with the logins storage. Instead of "locking"/"unlocking" the store whenever its needed, a connection to a storage layer is now cached on first access and re-used for subsequent operations. Various components relying on logins storage have been simplified.
grigoryk
force-pushed
the
issue5715LoginStorage
branch
from
bdf9f31
to
aa9a36a
Compare
grigoryk
pushed a commit
to grigoryk/fenix
that referenced
this pull request
Mar 3, 2020
The a-c side of this work is in mozilla-mobile/android-components#6128 This switches Fenix to use `SyncableLoginsStorage`, which caches a connection internally on first access, and doesn't expose any lock/unlock APIs at the public boundary.
grigoryk
changed the title
|
bors r=csadilek |
Build succeeded
|
pocmo
pushed a commit
to grigoryk/fenix
that referenced
this pull request
Mar 3, 2020
The a-c side of this work is in mozilla-mobile/android-components#6128 This switches Fenix to use `SyncableLoginsStorage`, which caches a connection internally on first access, and doesn't expose any lock/unlock APIs at the public boundary.
pocmo
pushed a commit
to grigoryk/fenix
that referenced
this pull request
Mar 3, 2020
The a-c side of this work is in mozilla-mobile/android-components#6128 This switches Fenix to use `SyncableLoginsStorage`, which caches a connection internally on first access, and doesn't expose any lock/unlock APIs at the public boundary.
pocmo
pushed a commit
to grigoryk/fenix
that referenced
this pull request
Mar 3, 2020
The a-c side of this work is in mozilla-mobile/android-components#6128 This switches Fenix to use `SyncableLoginsStorage`, which caches a connection internally on first access, and doesn't expose any lock/unlock APIs at the public boundary.
pocmo
pushed a commit
to pocmo/fenix
that referenced
this pull request
Mar 3, 2020
The a-c side of this work is in mozilla-mobile/android-components#6128 This switches Fenix to use `SyncableLoginsStorage`, which caches a connection internally on first access, and doesn't expose any lock/unlock APIs at the public boundary.
pocmo
pushed a commit
to mozilla-mobile/fenix
that referenced
this pull request
Mar 3, 2020
The a-c side of this work is in mozilla-mobile/android-components#6128 This switches Fenix to use `SyncableLoginsStorage`, which caches a connection internally on first access, and doesn't expose any lock/unlock APIs at the public boundary.
liuche
pushed a commit
to liuche/fenix
that referenced
this pull request
Mar 3, 2020
The a-c side of this work is in mozilla-mobile/android-components#6128 This switches Fenix to use `SyncableLoginsStorage`, which caches a connection internally on first access, and doesn't expose any lock/unlock APIs at the public boundary.
liuche
pushed a commit
to mozilla-mobile/fenix
that referenced
this pull request
Mar 3, 2020
The a-c side of this work is in mozilla-mobile/android-components#6128 This switches Fenix to use `SyncableLoginsStorage`, which caches a connection internally on first access, and doesn't expose any lock/unlock APIs at the public boundary.
2 tasks
gmierz
pushed a commit
to gmierz/fenix
that referenced
this pull request
Mar 5, 2020
The a-c side of this work is in mozilla-mobile/android-components#6128 This switches Fenix to use `SyncableLoginsStorage`, which caches a connection internally on first access, and doesn't expose any lock/unlock APIs at the public boundary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge