This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Uplift: For fenix#16232 - Make sure we cancel any in-progress auth #8978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to #7856 we only had a NotAuthenticated state, which user would remain in until the very end of the authentication process (receiving a 'finished...' api call). After the refactor, we introduced an in-progress states - specifically, BeginningAuthentication. If the user cancels the auth flow (e.g. closes a custom tab), they will remain in this state. Subsequent login attempts would then fail. This patch fixes this by introducing a Cancel event which we trigger whenever handling 'beginAuthentication' calls. In normal scenarios, this event is ignored. Otherwise, it "resets" the state machine into NotAuthenticated state before emitting any Begin* events.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to #7856 we only had a NotAuthenticated
state, which user would remain in until the very end of the authentication process (receiving a 'finished...' api call).
After the refactor, we introduced an in-progress states - specifically, BeginningAuthentication. If the user
cancels the auth flow (e.g. closes a custom tab), they will remain in this state. Subsequent login attempts
would then fail.
This patch fixes this by introducing a Cancel event which we trigger whenever handling 'beginAuthentication' calls.
In normal scenarios, this event is ignored. Otherwise, it "resets" the state machine into NotAuthenticated
state before emitting any Begin* events.
Pull Request checklist
After merge