Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

For #9184 - Emit ContextMenuFact to track text selection context usage in Fenix #9185

Merged
merged 1 commit into from
Dec 21, 2020
Merged

For #9184 - Emit ContextMenuFact to track text selection context usage in Fenix #9185

merged 1 commit into from
Dec 21, 2020

Conversation

codrut-topliceanu
Copy link
Contributor

@codrut-topliceanu codrut-topliceanu commented Dec 10, 2020 •
edited
Loading

For #9184

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks.
  • Tests: This PR does not include any tests as it is only a minor change.
  • Changelog: This PR doesn't include a changelog entry as this is only a minor change.
  • Accessibility: The code in this PR does not include any user facing features.

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@codrut-topliceanu codrut-topliceanu mentioned this pull request Dec 10, 2020
Merged
3 tasks
@jonalmeida
Copy link
Contributor

For telemetry, we emit "facts" for consumers to track.

You can see some examples of facts being emitted in other components here.

@codrut-topliceanu codrut-topliceanu changed the title For #9184 - Adds lambda parameter to allow performAction() to be tracked For #9184 - Emit ContextMenuFact to track text selection context usage in Fenix Dec 14, 2020
@rocketsroger rocketsroger assigned csadilek, pocmo and jonalmeida and unassigned pocmo Dec 14, 2020
jonalmeida
jonalmeida approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the ping!

@codrut-topliceanu codrut-topliceanu added the 🛬 needs landing PRs that are ready to land label Dec 18, 2020
@mergify mergify bot merged commit 208f630 into mozilla-mobile:master Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csadilek csadilek csadilek left review comments

@jonalmeida jonalmeida jonalmeida approved these changes

@pocmo pocmo Awaiting requested review from pocmo

Assignees

@csadilek csadilek

@jonalmeida jonalmeida

Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codrut-topliceanu @jonalmeida @csadilek @pocmo