For #3620 - Adds automatic theme onboarding content description (#3629)

mozilla-mobile · Jun 24, 2019 · 03a5cb2 · 03a5cb2
1 parent 1d57e77
commit 03a5cb2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/...zilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingThemePickerViewHolder.kt b/...zilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingThemePickerViewHolder.kt
@@ -52,6 +52,10 @@ class OnboardingThemePickerViewHolder(private val view: View) : RecyclerView.Vie
             radioLightTheme.performClick()
         }
 
+        val automaticTitle = view.context.getString(R.string.onboarding_theme_automatic_title)
+        val automaticSummary = view.context.getString(R.string.onboarding_theme_automatic_summary)
+        view.clickable_region_automatic.contentDescription = "$automaticTitle $automaticSummary"
+
         view.clickable_region_automatic.setOnClickListener {
             radioFollowDeviceTheme.performClick()
         }

diff --git a/app/src/main/res/layout/onboarding_theme_picker.xml b/app/src/main/res/layout/onboarding_theme_picker.xml
@@ -60,7 +60,6 @@
         app:layout_constraintTop_toBottomOf="@+id/description_text"
         app:onboardingKey="@string/pref_key_light_theme" />
 
-
     <ImageButton
         android:id="@+id/theme_light_image"
         android:layout_width="wrap_content"
@@ -144,6 +143,7 @@
         android:layout_marginStart="16dp"
         android:layout_marginTop="16dp"
         android:layout_marginBottom="16dp"
+        android:contentDescription="@string/onboarding_theme_automatic_title"
         android:paddingStart="0dp"
         android:paddingEnd="8dp"
         app:layout_constraintBottom_toBottomOf="parent"