Fixes comments

mozilla-mobile · Oct 3, 2019 · 0a74773 · 0a74773
1 parent ae9e2ec
commit 0a74773
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 10 deletions.
diff --git a/app/src/main/java/org/mozilla/fenix/HomeActivity.kt b/app/src/main/java/org/mozilla/fenix/HomeActivity.kt
@@ -130,13 +130,12 @@ open class HomeActivity : AppCompatActivity() {
         // We do this on a separate thread to alleviate performance issues
         val weakReferenceContext = WeakReference(this)
         lifecycleScope.launch {
-            weakReferenceContext.get()?.let {
-                if (!Browsers.all(it).isDefaultBrowser) {
-                    it.settings().preferences
-                        .edit()
-                        .putBoolean(it.getString(R.string.pref_key_open_links_in_a_private_tab), false)
-                        .apply()
-                }
+            val context = weakReferenceContext.get() ?: return@launch
+            if (!Browsers.all(context).isDefaultBrowser) {
+                context.settings().preferences
+                    .edit()
+                    .putBoolean(context.getString(R.string.pref_key_open_links_in_a_private_tab), false)
+                    .apply()
             }
         }
     }

diff --git a/app/src/main/java/org/mozilla/fenix/IntentReceiverActivity.kt b/app/src/main/java/org/mozilla/fenix/IntentReceiverActivity.kt
@@ -122,7 +122,9 @@ class IntentReceiverActivity : Activity() {
     }
 
     companion object {
+        // This constant must match the metadata from the private activity-alias
         const val LAUNCH_PRIVATE_LINK = "org.mozilla.fenix.LAUNCH_PRIVATE_LINK"
+
         const val ACTION_OPEN_TAB = "org.mozilla.fenix.OPEN_TAB"
         const val ACTION_OPEN_PRIVATE_TAB = "org.mozilla.fenix.OPEN_PRIVATE_TAB"
     }

diff --git a/.../fenix/settings/DefaultBrowserFragment.kt → ...ettings/DefaultBrowserSettingsFragment.kt b/.../fenix/settings/DefaultBrowserFragment.kt → ...ettings/DefaultBrowserSettingsFragment.kt
@@ -22,9 +22,9 @@ import org.mozilla.fenix.ext.getPreferenceKey
 import org.mozilla.fenix.ext.settings
 
 /**
- * Lets the user toggle telemetry on/off.
+ * Lets the user control their default browser preferences
  */
-class DefaultBrowserFragment : PreferenceFragmentCompat() {
+class DefaultBrowserSettingsFragment : PreferenceFragmentCompat() {
 
     private val preferenceChangeListener =
         SharedPreferences.OnSharedPreferenceChangeListener { sharedPreferences, key ->

diff --git a/app/src/main/res/navigation/nav_graph.xml b/app/src/main/res/navigation/nav_graph.xml
@@ -590,6 +590,6 @@
         android:label="AddNewDeviceFragment" />
     <fragment
         android:id="@+id/defaultBrowserFragment"
-        android:name="org.mozilla.fenix.settings.DefaultBrowserFragment"
+        android:name="org.mozilla.fenix.settings.DefaultBrowserSettingsFragment"
         android:label="DefaultBrowserFragment" />
 </navigation>