Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Commit

Permalink
Closes #19496: remove glean metrics docs check from pre-push hook.
Browse files Browse the repository at this point in the history
  • Loading branch information
mcomella committed May 13, 2021
1 parent ede909e commit 51d33fc
Showing 1 changed file with 0 additions and 18 deletions.
18 changes: 0 additions & 18 deletions config/pre-push-recommended.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,24 +14,6 @@
# Descriptions for each gradle task below can be found in the
# output of `./gradlew tasks`.

# Prevent push if generated glean docs are not committed.
# A better implementation would make sure these doc updates
# only came from this commit.
./gradlew -q \
gleanGenerateMetricsDocsForDebug \
gleanGenerateMetricsSourceForDebug
if git status --porcelain=v1 | grep -q "docs/metrics.md"; then
echo "
FAIL pre-push hook: generated glean file, docs/metrics.md, has uncommitted changes.
Please commit these files and try again.
This check tries to prevent these generated files from being uncommitted on master.
However, it may fail unintuitively if we're in that state. If this happens often
and is disruptive to your workflow, please notify mcomella so we can improve this
check." >&2
exit 1
fi

# Run core checks.
./gradlew -q \
ktlint \
Expand Down

0 comments on commit 51d33fc

Please sign in to comment.