Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Commit

Permalink
Properly quote description for ad metric
Browse files Browse the repository at this point in the history
This is pedantic, but strictly something called <provider-name> is considered an HTML tag
unless it's in a code block (backticks). 

See mozilla/glean-dictionary#549 and mozilla/glean-dictionary#497. I'm going to fix this upstream
but figured I might as well file a PR here to fix the underlying issue.
  • Loading branch information
wlach committed Apr 26, 2021
1 parent 883cb7c commit 68472a7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions app/metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3949,7 +3949,7 @@ browser.search:
type: labeled_counter
description: |
Records counts of SERP pages with adverts displayed.
The key format is <provider-name>.
The key format is `<provider-name>`.
send_in_pings:
- metrics
bugs:
Expand All @@ -3966,7 +3966,7 @@ browser.search:
type: labeled_counter
description: |
Records clicks of adverts on SERP pages.
The key format is <provider-name>.
The key format is `<provider-name>`.
send_in_pings:
- metrics
bugs:
Expand Down

0 comments on commit 68472a7

Please sign in to comment.