Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Commit

Permalink
Bug 1580778 - Fix version names (#5635)
Browse files Browse the repository at this point in the history
* Bug 1580778 - Put back versionName to releases

* Bug 1580778 - Put quote escaping
  • Loading branch information
JohanLorenzo authored and sblatz committed Sep 30, 2019
1 parent ef29fe2 commit 9729fd4
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
3 changes: 3 additions & 0 deletions taskcluster/ci/build/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ jobs:
fennec-production:
attributes:
nightly: true
include-nightly-version: true
include-shippable-secrets: true
run:
geckoview-engine: geckoBeta
Expand All @@ -88,6 +89,7 @@ jobs:
attributes:
build-type: production
release-type: beta
include-release-version: true
include-shippable-secrets: true
run:
geckoview-engine: geckoBeta
Expand All @@ -99,6 +101,7 @@ jobs:
production:
attributes:
release-type: production
include-release-version: true
include-shippable-secrets: true
run:
geckoview-engine: geckoBeta
Expand Down
7 changes: 4 additions & 3 deletions taskcluster/fenix_taskgraph/transforms/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
from __future__ import absolute_import, print_function, unicode_literals

import datetime
import os

from taskgraph.transforms.base import TransformSequence
from fenix_taskgraph.gradle import get_variant
Expand Down Expand Up @@ -83,7 +84,7 @@ def add_nightly_version(config, tasks):

for task in tasks:
if task.pop("include-nightly-version", False):
task["run"]["gradlew"].append('-PversionName="{}"'.format(formated_date_time))
task["run"]["gradlew"].append('-PversionName={}'.format(formated_date_time))
yield task


Expand All @@ -92,10 +93,10 @@ def add_release_version(config, tasks):
for task in tasks:
if task.pop("include-release-version", False):
# TODO Move GIT_TAG to a parameter
git_tag = os.environ['GIT_TAG']
git_tag = os.environ.get('GIT_TAG', 'vUNSET')
version = git_tag[1:] # remove prefixed "v"

task["run"]["gradlew"].append('-PversionName="{}"'.format(version))
task["run"]["gradlew"].append('-PversionName={}'.format(version))
yield task


Expand Down

0 comments on commit 9729fd4

Please sign in to comment.