Fix I think

mozilla-mobile · May 15, 2019 · eafa55a · eafa55a
1 parent b201988
commit eafa55a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/app/metrics.yaml b/app/metrics.yaml
@@ -645,7 +645,7 @@ error_page:
     bugs:
     - 1242
     data_reviews:
-    - https://github.com/mozilla-mobile/fenix/pull/2491
+    - https://github.com/mozilla-mobile/fenix/pull/2491#issuecomment-492414486
     notification_emails:
     - fenix-core@mozilla.com
     expires: "2020-03-01"
diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt
@@ -22,6 +22,7 @@ import kotlinx.coroutines.Job
 import kotlinx.coroutines.launch
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.runBlocking
+import org.mozilla.fenix.GleanMetrics.ErrorPage
 
 private class EventWrapper<T : Enum<T>>(
     private val recorder: ((Map<T, String>?) -> Unit),
@@ -158,6 +159,10 @@ private val Event.wrapper
         is Event.UriOpened -> EventWrapper<NoExtraKeys>(
             { Events.totalUriCount.add(1) }
         )
+        is Event.ErrorPageVisited -> EventWrapper(
+            { ErrorPage.visitedError },
+            { ErrorPage.visitedErrorKeys.valueOf(it) }
+        )
 
         // Don't track other events with Glean
         else -> null