This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
for #12573, added startup type and hasSavedInstance keys to app_start…
…up_type telemetry
- Loading branch information
Showing
11 changed files
with
413 additions
and
175 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 0 additions & 59 deletions
59
app/src/main/java/org/mozilla/fenix/components/metrics/AppAllSourceStartTelemetry.kt
This file was deleted.
Oops, something went wrong.
148 changes: 148 additions & 0 deletions
148
app/src/main/java/org/mozilla/fenix/components/metrics/AppStartupTelemetry.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,148 @@ | ||
| /* This Source Code Form is subject to the terms of the Mozilla Public | ||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| package org.mozilla.fenix.components.metrics | ||
|
|
||
| import android.content.Intent | ||
| import androidx.annotation.VisibleForTesting | ||
| import androidx.lifecycle.Lifecycle | ||
| import androidx.lifecycle.LifecycleObserver | ||
| import androidx.lifecycle.OnLifecycleEvent | ||
| import androidx.lifecycle.ProcessLifecycleOwner | ||
| import mozilla.components.support.utils.SafeIntent | ||
| import org.mozilla.fenix.components.metrics.Event.AppStartupSourceAndType | ||
| import org.mozilla.fenix.components.metrics.Event.AppStartupSourceAndType.Source | ||
| import org.mozilla.fenix.components.metrics.Event.AppStartupSourceAndType.Source.APP_ICON | ||
| import org.mozilla.fenix.components.metrics.Event.AppStartupSourceAndType.Source.ERROR | ||
| import org.mozilla.fenix.components.metrics.Event.AppStartupSourceAndType.Source.CUSTOM_TAB | ||
| import org.mozilla.fenix.components.metrics.Event.AppStartupSourceAndType.Source.LINK | ||
|
|
||
| import org.mozilla.fenix.components.metrics.Event.AppStartupSourceAndType.Type | ||
| import org.mozilla.fenix.components.metrics.Event.AppStartupSourceAndType.Type.COLD | ||
| import org.mozilla.fenix.components.metrics.Event.AppStartupSourceAndType.Type.WARM | ||
|
|
||
| /** | ||
| * Tracks application startup source, type, and whether or not activity has savedInstance to restore | ||
| * the activity from. Sample metric = [source = COLD, type = APP_ICON, hasSavedInstance = false]. | ||
| * The basic idea is to collect these metrics from different phases of startup through | ||
| * [AppStartupSourceAndType]and finally report them on Activity's onResume() function. | ||
| * If application wasn't backgrounded before onResume() is called, we don't report the metric. | ||
| */ | ||
| class AppStartupTelemetry(private val metrics: MetricController) : LifecycleObserver { | ||
|
|
||
| init { | ||
| ProcessLifecycleOwner.get().lifecycle.addObserver(this) | ||
| } | ||
|
|
||
| private var metricDataContainer = AppStartupMetricDataContainer() | ||
|
|
||
| private var isMetricRecordedSinceAppWasForegrounded = false | ||
| private var wasAppCreateCalledBeforeActivityCreate = false | ||
|
|
||
| fun onFenixApplicationOnCreate() { | ||
| wasAppCreateCalledBeforeActivityCreate = true | ||
| } | ||
|
|
||
| fun onHomeActivityOnCreate(safeIntent: SafeIntent, hasSavedInstanceState: Boolean) { | ||
| metricDataContainer.hasSavedInstance = hasSavedInstanceState | ||
| metricDataContainer.type = getAppStartupType() | ||
| metricDataContainer.source = getStartupSourceFromIntent(safeIntent, false) | ||
|
|
||
| wasAppCreateCalledBeforeActivityCreate = false | ||
| } | ||
|
|
||
| fun onExternalAppBrowserOnCreate(safeIntent: SafeIntent, hasSavedInstanceState: Boolean) { | ||
| metricDataContainer.hasSavedInstance = hasSavedInstanceState | ||
| metricDataContainer.type = getAppStartupType() | ||
| metricDataContainer.source = getStartupSourceFromIntent(safeIntent, true) | ||
|
|
||
| wasAppCreateCalledBeforeActivityCreate = false | ||
| } | ||
|
|
||
| /** | ||
| * we are not setting [Source] in this method since source is derived from a [SafeIntent]. | ||
| * therefore source either gets set in oncreate() or onNewIntent(). | ||
| */ | ||
| fun onHomeActivityOnRestart() { | ||
| metricDataContainer.type = Type.HOT | ||
| metricDataContainer.hasSavedInstance = false | ||
| } | ||
|
|
||
| /** | ||
| * we are only setting [Source] in this method since source is derived from a [SafeIntent]. | ||
| * other metric fields are set in onCreate() and onRestart() | ||
| */ | ||
| fun onHomeActivityOnNewIntent(safeIntent: SafeIntent) { | ||
| metricDataContainer.source = getStartupSourceFromIntent(safeIntent, false) | ||
| } | ||
|
|
||
| private fun getAppStartupType(): Type { | ||
| return if (wasAppCreateCalledBeforeActivityCreate) COLD else WARM | ||
| } | ||
|
|
||
| private fun getStartupSourceFromIntent( | ||
| intent: SafeIntent, | ||
| isExternalAppBrowserActivity: Boolean | ||
| ): Source { | ||
| return when { | ||
| isExternalAppBrowserActivity -> CUSTOM_TAB | ||
| intent.isLauncherIntent -> APP_ICON | ||
| intent.action == Intent.ACTION_VIEW -> LINK | ||
| else -> ERROR | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * The reason we record metric on resume is because we need to wait for onNewIntent(), and | ||
| * we are not guaranteed that onNewIntent() will be called before or after onStart() / onRestart(). | ||
| * However we are guaranteed onResume() will be called after onNewIntent() and onStart(). Source: | ||
| * https://developer.android.com/reference/android/app/Activity#onNewIntent(android.content.Intent) | ||
| * | ||
| */ | ||
| fun onHomeActivityOnResume() { | ||
| recordMetric() | ||
| } | ||
|
|
||
| private fun recordMetric() { | ||
| if (!isMetricRecordedSinceAppWasForegrounded) { | ||
| metrics.track(metricDataContainer.getAppStartupSourceAndType()) | ||
| isMetricRecordedSinceAppWasForegrounded = true | ||
| } | ||
| // we don't want any weird previous states to persist on our next metric record. | ||
| metricDataContainer = AppStartupMetricDataContainer() | ||
| } | ||
|
|
||
| @OnLifecycleEvent(Lifecycle.Event.ON_STOP) | ||
| @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE) | ||
| fun onApplicationOnStop() { | ||
| // application was backgrounded, we need to record the new metric type if | ||
| // application was to come to foreground again. | ||
| // Therefore we set the isMetricRecorded flag to false. | ||
| isMetricRecordedSinceAppWasForegrounded = false | ||
| } | ||
|
|
||
| private data class AppStartupMetricDataContainer( | ||
| var source: Source? = null, | ||
| var type: Type? = null, | ||
| var hasSavedInstance: Boolean? = null | ||
| ) { | ||
|
|
||
| fun getAppStartupSourceAndType(): AppStartupSourceAndType { | ||
| setNullFieldsToError() | ||
| return AppStartupSourceAndType(source!!, type!!, hasSavedInstance!!) | ||
| } | ||
|
|
||
| private fun setNullFieldsToError() { | ||
| if (source == null) { | ||
| source = ERROR | ||
| } | ||
| if (type == null) { | ||
| type = Type.ERROR | ||
| } | ||
| if (hasSavedInstance == null) { | ||
| hasSavedInstance = false | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.