Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Address bar context menu cannot be dismissed without selecting an option from menu #10027

Closed
yoasif opened this issue Apr 17, 2020 · 3 comments
Closed

[Bug] Address bar context menu cannot be dismissed without selecting an option from menu #10027

yoasif opened this issue Apr 17, 2020 · 3 comments
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified

Comments

@yoasif
Copy link
Contributor

yoasif commented Apr 17, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Open Fenix
  2. Open any website
  3. Tap and hold on address in address bar
  4. Do any of: tap meatball menu, press back button, tap on page content, tap on location bar, tap tab switcher

Expected behavior

Contextual menu should be dismissed.

Actual behavior

Context menu is not dismissed unless an option is selected from the menu. Fenix appears completely frozen until this occurs.

FYI: I cannot reproduce this on my Pixel 2.

Device information

  • Android device: Moto G XT1031
  • Fenix version: latest from play store.
  • Edit: Reproducible only on SDK 22 or below.

┆Issue is synchronized with this Jira Task
@yoasif yoasif added the 🐞 bug Crashes, Something isn't working, .. label Apr 17, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 17, 2020
@eliserichards eliserichards added this to Inbox in Engineering triage via automation Apr 17, 2020
@mcarare
Copy link
Contributor

mcarare commented Apr 21, 2020

@yoasif I assume that device has Android 5 or at most 5.1.1? I cannot reproduce on SDK 23 or higher but I can reproduce it on 21 & 22.

@mcarare mcarare self-assigned this Apr 21, 2020
@mcarare mcarare added this to App Navigation in Workflow Apr 21, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Apr 21, 2020
@mcarare
For mozilla-mobile#10027: Make toolbar context menu popup dismissible…
1025507 
… on SDK<23
@yoasif
Copy link
Contributor Author

yoasif commented Apr 21, 2020

@mcarare yep, Android 5.1

@mcarare mcarare removed this from Inbox in Engineering triage Apr 22, 2020
@mcarare mcarare added this to API 22 in API-specific issues Apr 22, 2020
ekager pushed a commit that referenced this issue Apr 23, 2020
@mcarare @ekager
For #10027: Make toolbar context menu popup dismissible on SDK<23
e11f1b6
@ekager ekager added the eng:qa:needed QA Needed label Apr 23, 2020
@vesta0 vesta0 removed this from App Navigation in Workflow Apr 23, 2020
@vesta0 vesta0 added this to Ready for QA in Fenix Sprint Kanban Apr 23, 2020
Amejia481 pushed a commit to Amejia481/fenix that referenced this issue Apr 23, 2020
@mcarare @Amejia481
For mozilla-mobile#10027: Make toolbar context menu popup dismissible…
43f30ad 
… on SDK<23
@sv-sdeiac
Copy link

sv-sdeiac commented Apr 24, 2020 •
edited
Loading

Hi, I can confirm that this issue is fixed using the latest version of Firefox Preview Nightly 4/24 #21150607.
Now you can dismiss the context menu by tapping on the page content, toolbar, or overview buttons from your device.

Devices:

  • Huawei MediaPad M2 (Android 5.1.1).

@sv-sdeiac sv-sdeiac added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed needs:triage Issue needs triage labels Apr 24, 2020
@vesta0 vesta0 moved this from Ready for QA to Sprint 20.8 Done in Fenix Sprint Kanban Apr 28, 2020
@liuche liuche mentioned this issue Apr 28, 2020
Closed
32 tasks
@BranescuMihai BranescuMihai mentioned this issue Jun 2, 2020
Merged
4 tasks
@data-sync-user data-sync-user changed the title [Bug] Address bar context menu cannot be dismissed without selecting an option from menu FNX2-15691 ⁃ [Bug] Address bar context menu cannot be dismissed without selecting an option from menu Jul 30, 2020
@data-sync-user data-sync-user changed the title FNX2-15691 ⁃ [Bug] Address bar context menu cannot be dismissed without selecting an option from menu FNX3-13595 ⁃ [Bug] Address bar context menu cannot be dismissed without selecting an option from menu Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13595 ⁃ [Bug] Address bar context menu cannot be dismissed without selecting an option from menu FNX-3239 ⁃ [Bug] Address bar context menu cannot be dismissed without selecting an option from menu Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-3239 ⁃ [Bug] Address bar context menu cannot be dismissed without selecting an option from menu FNX2-15691 ⁃ [Bug] Address bar context menu cannot be dismissed without selecting an option from menu Aug 11, 2020
@mcarare mcarare removed this from API 22 in API-specific issues Jan 12, 2021
@data-sync-user data-sync-user changed the title FNX2-15691 ⁃ [Bug] Address bar context menu cannot be dismissed without selecting an option from menu [Bug] Address bar context menu cannot be dismissed without selecting an option from menu May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@yoasif @ekager @sv-sdeiac @mcarare @data-sync-user