Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] getProcessStartTimeTicks crash #10434

Closed
liuche opened this issue May 6, 2020 · 4 comments
Closed

[Bug] getProcessStartTimeTicks crash #10434

liuche opened this issue May 6, 2020 · 4 comments
Assignees
@mcarare
Labels
b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info 🐞 bug Crashes, Something isn't working, .. eng:qa:not-needed Added by QA to issues that cannot be tested performance Possible performance wins
Projects
Performance, front-end roadmap

Comments

@liuche
Copy link
Contributor

liuche commented May 6, 2020 •
edited by data-sync-user
Loading

Crash in fenix.perf with getProcessStartTimeTicks in 5.0.0 release build.

Sentry log: https://sentry.prod.mozaws.net/operations/firefox-nightly/issues/8293980/

┆Issue is synchronized with this Jira Task
@liuche liuche added 🐞 bug Crashes, Something isn't working, .. b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info performance Possible performance wins labels May 6, 2020
@liuche
Copy link
Contributor Author

liuche commented May 6, 2020 •
edited
Loading

@mcomella is this something from perf team telemetry?

@liuche liuche added the Release Blocker Blocks a Release label May 6, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label May 6, 2020
@mcarare
Copy link
Contributor

mcarare commented May 6, 2020

@liuche This seems to be a problem specific to using a privacy manager that relies on a hooking mechanism (SandHook) and it blocks reading the file in Stat.kt. The most we can do is catch the exception or maybe @mcomella has another idea.
I do not think this crash will have a high recurrence.

@mcomella mcomella added this to Needs prioritization in Performance, front-end roadmap via automation May 6, 2020
@mcomella
Copy link
Contributor

mcomella commented May 6, 2020

The most we can do is catch the exception or maybe @mcomella has another idea.

Yeah, I think we'll have to catch the exception.

This doesn't seem to have a high crash count and does seem to be related to OS customization so it doesn't urgent: I'll wait for triage later today to figure out the priority. This is probably a permacrash though and the fix is straightforward so I think we should address it, despite the low crash count.

@liuche
Copy link
Contributor Author

liuche commented May 6, 2020

This is with 1% rollout, but reasons seem good, I'll remove the RB label.

@liuche liuche removed the Release Blocker Blocks a Release label May 6, 2020
@eliserichards eliserichards removed the needs:triage Issue needs triage label May 6, 2020
mcarare added a commit to mcarare/fenix that referenced this issue May 7, 2020
@mcarare
For mozilla-mobile#10434: Handle cases when proc/$pid/stat is not acc…
fd0b6d4 
…essible.
mcarare added a commit to mcarare/fenix that referenced this issue May 7, 2020
@mcarare
For mozilla-mobile#10434: Handle cases when proc/$pid/stat is not acc…
a53cb47 
…essible.
mcarare added a commit to mcarare/fenix that referenced this issue May 7, 2020
@mcarare
For mozilla-mobile#10434: Handle cases when proc/$pid/stat is not acc…
27447bc 
…essible.
@mcarare mcarare self-assigned this May 11, 2020
@ekager ekager added this to Blocked in Engineering triage May 12, 2020
@ekager ekager removed this from Blocked in Engineering triage May 12, 2020
mcarare added a commit to mcarare/fenix that referenced this issue May 13, 2020
@mcarare
For mozilla-mobile#10434: Handle cases when proc/$pid/stat is not acc…
05e2c03 
…essible.
mcarare added a commit to mcarare/fenix that referenced this issue May 13, 2020
@mcarare
For mozilla-mobile#10434: Handle cases when proc/$pid/stat is not acc…
2ef835a 
…essible.
mcarare added a commit to mcarare/fenix that referenced this issue May 13, 2020
@mcarare
For mozilla-mobile#10434: Handle cases when proc/$pid/stat is not acc…
0d6a3e7 
…essible.
mcarare added a commit to mcarare/fenix that referenced this issue May 13, 2020
@mcarare
For mozilla-mobile#10434: Handle cases when proc/$pid/stat is not acc…
2725aa8 
…essible.
@mcarare mcarare mentioned this issue May 13, 2020
Merged
4 tasks
mcarare added a commit to mcarare/fenix that referenced this issue May 14, 2020
@mcarare
For mozilla-mobile#10434: Handle cases when proc/$pid/stat is not acc…
5654eff 
…essible.
mcarare added a commit to mcarare/fenix that referenced this issue May 14, 2020
@mcarare
For mozilla-mobile#10434: Handle cases when proc/$pid/stat is not acc…
9db426c 
…essible.
@mcomella mcomella moved this from Needs prioritization to Top 10 Inter-Team bugs in Performance, front-end roadmap May 20, 2020
mcarare added a commit to mcarare/fenix that referenced this issue May 25, 2020
@mcarare
For mozilla-mobile#10434: Handle cases when proc/$pid/stat is not acc…
1a68109 
…essible.
liuche pushed a commit that referenced this issue Jun 3, 2020
@mcarare @liuche
For #10434: Handle cases when proc/$pid/stat is not accessible.
2090b11
@mcarare mcarare added the eng:qa:not-needed Added by QA to issues that cannot be tested label Jun 4, 2020
@mcarare mcarare closed this as completed Jun 4, 2020
Performance, front-end roadmap automation moved this from Top 10 Inter-Team bugs to Done Jun 4, 2020
@liuche liuche mentioned this issue Jun 10, 2020
Closed
29 tasks
@data-sync-user data-sync-user changed the title [Bug] getProcessStartTimeTicks crash FNX2-15953 ⁃ [Bug] getProcessStartTimeTicks crash Jul 30, 2020
@data-sync-user data-sync-user changed the title FNX2-15953 ⁃ [Bug] getProcessStartTimeTicks crash FNX-4283 ⁃ [Bug] getProcessStartTimeTicks crash Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-4283 ⁃ [Bug] getProcessStartTimeTicks crash FNX3-13895 ⁃ [Bug] getProcessStartTimeTicks crash Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13895 ⁃ [Bug] getProcessStartTimeTicks crash FNX-4283 ⁃ [Bug] getProcessStartTimeTicks crash Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-4283 ⁃ [Bug] getProcessStartTimeTicks crash FNX2-15953 ⁃ [Bug] getProcessStartTimeTicks crash Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-15953 ⁃ [Bug] getProcessStartTimeTicks crash [Bug] getProcessStartTimeTicks crash May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info 🐞 bug Crashes, Something isn't working, .. eng:qa:not-needed Added by QA to issues that cannot be tested performance Possible performance wins
Projects
Performance, front-end roadmap
Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mcomella @liuche @eliserichards @mcarare @data-sync-user