-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add dark theme for low/medium risk error pages #10571
Comments
@NotWoods Great idea! As we’ve specced out in the Material UI library, our dark colour scheme is as follows:
An example of this colour scheme looks like this: To note: this colour scheme applies to low and medium-risk error pages (content crashed, SSL errors, etc.). For high-risk pages (malware warnings), we should keep using the red background colour. It’s meant to be jarring. Here’s an Abstract link to the rest of the dark theme error pages: I’ll just ping @AmyYLee here to double-check the colour values, particularly the secondary buttons. |
Can you follow this for the secondary button: See reference below. Thanks! |
Reopening for QA |
Tested this on Nightly 6/4 with Google Pixel 3 (Android 10), Nokia 6 (Android 7.1.1), and LG G7 FIT (Android 8), and I confirm that the pages are changing the background colour based on the app theme. The testing pages included:
|
Why/User Benefit/User Problem
Currently, our error pages (connection issue, SSL error, etc) are on light backgrounds and cannot be controlled by extensions like Dark Reader.
High risk pages have a colored background and should be left alone.
What/Requirements
We should have dark versions of these screens that are used if Fenix is in dark mode. The background could be changed to
#24193c
and the button could be changed to#f9f9fb
(inverting the current color scheme).Acceptance Criteria (how do I know when I’m done?)
Error pages have dark backgrounds in dark mode.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: