Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add dark theme for low/medium risk error pages #10571

Closed
NotWoods opened this issue May 11, 2020 · 4 comments
Closed

Add dark theme for low/medium risk error pages #10571

NotWoods opened this issue May 11, 2020 · 4 comments
Assignees
Labels
eng:qa:verified QA Verified Feature:ErrorMessages feature request 🌟 New functionality and improvements Feature:Themes Dark mode, light mode, private browsing mode needs:UX-feedback Needs UX Feedback
Milestone

Comments

@NotWoods
Copy link
Contributor

NotWoods commented May 11, 2020

Why/User Benefit/User Problem

Currently, our error pages (connection issue, SSL error, etc) are on light backgrounds and cannot be controlled by extensions like Dark Reader.

High risk pages have a colored background and should be left alone.

What/Requirements

We should have dark versions of these screens that are used if Fenix is in dark mode. The background could be changed to #24193c and the button could be changed to #f9f9fb (inverting the current color scheme).

Acceptance Criteria (how do I know when I’m done?)

Error pages have dark backgrounds in dark mode.

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label May 11, 2020
@ekager ekager added feature request 🌟 New functionality and improvements and removed needs:triage Issue needs triage labels May 12, 2020
@NotWoods NotWoods added the Feature:Themes Dark mode, light mode, private browsing mode label May 12, 2020
@brampitoyo brampitoyo self-assigned this May 28, 2020
@brampitoyo
Copy link

@NotWoods Great idea!

As we’ve specced out in the Material UI library, our dark colour scheme is as follows:

  • Foundation (background): Dark Grey 80 #15141a
  • On-Dark (text): Light Grey 5 #fbfbfe
  • Accent (colour of primary buttons): Violet 50 #9059ff
  • Secondary Buttons (colour of secondary buttons like “Advanced”): Dark Grey 20 #4a4a55
  • Accent Bright (colour of text links and text-only buttons): #ab71ff

An example of this colour scheme looks like this:

To note: this colour scheme applies to low and medium-risk error pages (content crashed, SSL errors, etc.). For high-risk pages (malware warnings), we should keep using the red background colour. It’s meant to be jarring.

Here’s an Abstract link to the rest of the dark theme error pages:
https://share.goabstract.com/108da5e3-6d39-4f87-a35d-91c6e78d7ee5

I’ll just ping @AmyYLee here to double-check the colour values, particularly the secondary buttons.

@AmyYLee
Copy link
Collaborator

AmyYLee commented May 28, 2020

@NotWoods Great idea!

As we’ve specced out in the Material UI library, our dark colour scheme is as follows:

* Foundation (background): Dark Grey 80 `#15141a`

* On-Dark (text): Light Grey 5 `#fbfbfe`

* Accent (colour of primary buttons): Violet 50 `#9059ff`

* Secondary Buttons (colour of secondary buttons like “Advanced”): Dark Grey 20 `#4a4a55`

* Accent Bright (colour of text links and text-only buttons): `#ab71ff`

An example of this colour scheme looks like this:

To note: this colour scheme applies to low and medium-risk error pages (content crashed, SSL errors, etc.). For high-risk pages (malware warnings), we should keep using the red background colour. It’s meant to be jarring.

Here’s an Abstract link to the rest of the dark theme error pages:
https://share.goabstract.com/108da5e3-6d39-4f87-a35d-91c6e78d7ee5

I’ll just ping @AmyYLee here to double-check the colour values, particularly the secondary buttons.

Can you follow this for the secondary button:
• Button - Light Grey 30 #E0E0E6
• Text in button - Ink 20 #312A65

See reference below. Thanks!

Screen Shot 2020-05-28 at 13 41 28

NotWoods added a commit to NotWoods/fenix that referenced this issue May 28, 2020
NotWoods added a commit to NotWoods/fenix that referenced this issue May 28, 2020
NotWoods added a commit to NotWoods/fenix that referenced this issue May 28, 2020
@ekager ekager closed this as completed in b5d03ff Jun 2, 2020
@ekager ekager added the eng:qa:needed QA Needed label Jun 2, 2020
@ekager
Copy link
Contributor

ekager commented Jun 2, 2020

Reopening for QA

@ekager ekager reopened this Jun 2, 2020
@NotWoods NotWoods added this to the 5.2 milestone Jun 2, 2020
@sflorean
Copy link
Contributor

sflorean commented Jun 4, 2020

Tested this on Nightly 6/4 with Google Pixel 3 (Android 10), Nokia 6 (Android 7.1.1), and LG G7 FIT (Android 8), and I confirm that the pages are changing the background colour based on the app theme. The testing pages included:

To note: this colour scheme applies to low and medium-risk error pages (content crashed, SSL errors, etc.). For high-risk pages (malware warnings), we should keep using the red background colour.

@sflorean sflorean closed this as completed Jun 4, 2020
@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 4, 2020
@liuche liuche mentioned this issue Jun 10, 2020
29 tasks
@data-sync-user data-sync-user changed the title Add dark theme for low/medium risk error pages FNX2-16026 ⁃ Add dark theme for low/medium risk error pages Jul 31, 2020
@data-sync-user data-sync-user changed the title FNX2-16026 ⁃ Add dark theme for low/medium risk error pages FNX-4583 ⁃ Add dark theme for low/medium risk error pages Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-4583 ⁃ Add dark theme for low/medium risk error pages FNX3-13995 ⁃ Add dark theme for low/medium risk error pages Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13995 ⁃ Add dark theme for low/medium risk error pages FNX-4583 ⁃ Add dark theme for low/medium risk error pages Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-4583 ⁃ Add dark theme for low/medium risk error pages FNX2-16026 ⁃ Add dark theme for low/medium risk error pages Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16026 ⁃ Add dark theme for low/medium risk error pages Add dark theme for low/medium risk error pages May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified Feature:ErrorMessages feature request 🌟 New functionality and improvements Feature:Themes Dark mode, light mode, private browsing mode needs:UX-feedback Needs UX Feedback
Projects
No open projects
Fenix Feature Requests
Awaiting triage
Development

No branches or pull requests

7 participants