Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Integrate SyncedTabs feature #10834

Closed
jonalmeida opened this issue May 21, 2020 · 3 comments · Fixed by #10970
Closed

Integrate SyncedTabs feature #10834

jonalmeida opened this issue May 21, 2020 · 3 comments · Fixed by #10970
Assignees
@Vishwa-Mozilla
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified P1 Current sprint
Projects
A-C: Meta: Sync Tabs Tabs Tray

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented May 21, 2020 •
edited by data-sync-user

A reference implementation exists here: https://github.com/mozilla-mobile/reference-browser/tree/master/app/src/main/java/org/mozilla/reference/browser/tabs/synced

To start:

  1. We could copy over the code from Reference Browser to Fenix (except the SyncedTabsActivity.kt).
  2. Connect the SyncedTabsFragment to the menu.
  3. Fix any references where needed.
  4. Follow the Fenix architecture pattern.
  5. Update UI to match Fenix history/bookmarks lists
  6. Tests!

Designs for an MVP version: https://app.abstract.com/share/cb14ade9-a5a1-4ca9-8012-4350363cf5b4

┆Issue is synchronized with this Jira Task
@jonalmeida jonalmeida created this issue from a note in A-C: Meta: Sync Tabs (In progress) May 21, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label May 21, 2020
@ekager ekager removed the needs:triage Issue needs triage label May 21, 2020
@liuche liuche added this to Sprint in Tabs Tray May 22, 2020
@liuche liuche added P1 Current sprint Skittle labels May 22, 2020
Vishwa-Mozilla added a commit to Vishwa-Mozilla/fenix that referenced this issue May 27, 2020
@Vishwa-Mozilla
For mozilla-mobile#10834 - Adding Sync Tabs Feature in Fenix
51772c9
@liuche liuche added E3 Estimation Point: average, 2 - 3 days E8 Estimation Point: about 8 days E5 Estimation Point: about 5 days and removed E3 Estimation Point: average, 2 - 3 days E8 Estimation Point: about 8 days labels May 28, 2020
Vishwa-Mozilla added a commit to Vishwa-Mozilla/fenix that referenced this issue May 29, 2020
@Vishwa-Mozilla
For mozilla-mobile#10834 - Adding Sync Tabs Feature in Fenix
919d556
Vishwa-Mozilla added a commit to Vishwa-Mozilla/fenix that referenced this issue Jun 1, 2020
@Vishwa-Mozilla
For mozilla-mobile#10834 - Adding Sync Tabs Feature in Fenix
3d932e4
Vishwa-Mozilla added a commit to Vishwa-Mozilla/fenix that referenced this issue Jun 1, 2020
@Vishwa-Mozilla
For mozilla-mobile#10834 - Adding Sync Tabs Feature in Fenix
c6caae4
Vishwa-Mozilla added a commit to Vishwa-Mozilla/fenix that referenced this issue Jun 1, 2020
@Vishwa-Mozilla
For mozilla-mobile#10834 - Adding Sync Tabs Feature in Fenix
746abbc
ekager pushed a commit that referenced this issue Jun 1, 2020
@Vishwa-Mozilla @ekager
For #10834 - Adding Sync Tabs Feature in Fenix
4da22c6
@ekager ekager added the eng:qa:needed QA Needed label Jun 1, 2020
@Vishwa-Mozilla Vishwa-Mozilla moved this from In progress to Done in A-C: Meta: Sync Tabs Jun 2, 2020
@liuche liuche moved this from Sprint to Ready for QA in Tabs Tray Jun 4, 2020
@lobontiumira
Copy link

Verified on the latest Nightly build from 6/4 that:

  • the "Synced tabs" option is displayed both in the main three-dot menu and in the page's three-dot menu, in normal mode and private mode:
    synced tabs menu

page menu

  • the UI matches Fenix history/bookmarks lists.
  • the user can choose to sync tabs across Firefox connected devices,
  • the user can access synced tabs in other connected devices on Fenix:
  • the user can access the synced Fenix tabs on the other Firefox connected devices,
  • the user sees the suggestions in the awesomebar for sites from the synced tabs.

Tested with OnePlus 5T (Android 5T), Sony Xperia Z5 Premium (Android 7.1.1), and Windows 10.
I've connected both mobile devices and desktop. The synced tabs were displayed correctly on every device.

@jonalmeida can I close the issue or is there anything else that needs to be tested by QA?
Thank you!

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 4, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 4, 2020 •
edited

Hi, verified as fixed while using the Tabs Tray on the latest Nightly Build 200604 from 6/4

I've synced the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)
• Desktop

► Video from Google Pixel 3a
20200604-150247

► Video from Huawei Mate 20 Lite
20200604-150938

► Video from OnePlus A3
20200604-150402

► Screenshot from the Desktop
Capturerere

@AndiAJ AndiAJ closed this as completed Jun 4, 2020
Tabs Tray automation moved this from Ready for QA to Done Jun 4, 2020
@Vishwa-Mozilla Vishwa-Mozilla mentioned this issue Jun 4, 2020
Merged
4 tasks
@jonalmeida
Copy link
Contributor Author

jonalmeida commented Jun 4, 2020 •
edited

the user sees the suggestions in the awesomebar for sites from the synced tabs.

This hasn't been integrated yet, but it can be easily mistaken with history sync. I'll file a separate issue for this integration (#11245).

Thank you for verifying @softvision-miralobontiu and @AndiAJ .

@liuche liuche mentioned this issue Jun 10, 2020
Closed
29 tasks
@data-sync-user data-sync-user changed the title Integrate SyncedTabs feature FNX2-16188 ⁃ Integrate SyncedTabs feature Jul 31, 2020
@data-sync-user data-sync-user changed the title FNX2-16188 ⁃ Integrate SyncedTabs feature FNX3-14192 ⁃ Integrate SyncedTabs feature Aug 10, 2020
Tabs Tray automation moved this from Done to In Progress Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-14192 ⁃ Integrate SyncedTabs feature FNX-4614 ⁃ Integrate SyncedTabs feature Aug 11, 2020
Tabs Tray automation moved this from In Progress to Done Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-4614 ⁃ Integrate SyncedTabs feature FNX2-16188 ⁃ Integrate SyncedTabs feature Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16188 ⁃ Integrate SyncedTabs feature Integrate SyncedTabs feature May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Vishwa-Mozilla Vishwa-Mozilla

Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified P1 Current sprint
Projects
No open projects
A-C: Meta: Sync Tabs
  
Done
Tabs Tray
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

For #10834 - Adding Sync Tabs Feature in Fenix Vishwa-Mozilla/fenix
7 participants
@liuche @jonalmeida @ekager @lobontiumira @AndiAJ @data-sync-user @Vishwa-Mozilla