Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Telemetry] Include state of preferenceToggled events in metrics ping #11118

Closed
sblatz opened this issue Jun 1, 2020 · 4 comments
Closed

[Telemetry] Include state of preferenceToggled events in metrics ping #11118

sblatz opened this issue Jun 1, 2020 · 4 comments
Assignees
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:Telemetry

Comments

@sblatz
Copy link
Contributor

sblatz commented Jun 1, 2020

We would also like to include documentation about the default state of each toggle somewhere in the metrics.md or elsewhere so data science can consult it when doing analysis.

┆Issue is synchronized with this Jira Task

@sblatz sblatz self-assigned this Jun 1, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 1, 2020
@kglazko kglazko removed the needs:triage Issue needs triage label Jun 1, 2020
@sblatz sblatz added the E3 Estimation Point: average, 2 - 3 days label Jun 2, 2020
@sblatz sblatz added this to In Progress in Fenix Sprint Kanban Jun 2, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Jun 3, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Jun 3, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Jun 3, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Jun 3, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Jun 3, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Jun 3, 2020
@sblatz sblatz moved this from In Progress to In Dev Review in Fenix Sprint Kanban Jun 3, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Jun 3, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Jun 3, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Jun 3, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Jun 3, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Jun 4, 2020
@sblatz sblatz added the eng:qa:needed QA Needed label Jun 4, 2020
@sblatz sblatz moved this from In Dev Review to Ready for QA in Fenix Sprint Kanban Jun 4, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Jun 10, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Jun 10, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Jun 10, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Jun 10, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Jun 10, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Jun 10, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 11, 2020

Hi @sblatz , I've just checked this matter on the latest Nightly build 200611 from 6/11 using a Google Pixel 3a (Android 10)

Status Description Notes
"preferences.sync" Not sure what does it stand for. It's always set to false
✔️ "preferences.sync_items"
✔️ "metrics.toolbar_position"
✔️ "preferences.show_search_shortcuts"
✔️ "preferences.show_clipboard_suggestions"
pref_key_search_browsing_history Not included in the metrics ping
✔️ "preferences.search_bookmarks"
pref_key_show_voice_search Not included in the metrics ping
✔️ "preferences.show_search_suggestions"
✔️ "preferences.search_suggestions_private"
✔️ "preferences.open_links_in_a_private_tab"
✔️ "preferences.tracking_protection"
✔️ "preferences.telemetry"
✔️ "preferences.remote_debugging"
✔️ "preferences.accessibility_services"

Logacat
Glean dashboard

Logcat ("touch exploration")
Glean dashboard

As per #11118 you've also mentioned the position of the position of the Toolbar, which as you can see is properly displayed in the metrics pings
On the other hand, I've noticed that nothing is displayed regarding the Theme setting.
Should this be included?

Please review. ☺️

@AndiAJ AndiAJ removed the eng:qa:needed QA Needed label Jun 11, 2020
@sblatz sblatz moved this from Ready for QA to In Dev Review in Fenix Sprint Kanban Jun 11, 2020
sblatz added a commit that referenced this issue Jun 12, 2020
@sblatz
Copy link
Contributor Author

sblatz commented Jun 12, 2020

Thanks for verifying @AndiAJ! Sync sounds right (given you're probably not signed in. If you're singed in to FxA then it should say the items you're syncing, if you'd like to test that portion!)

pref_key_show_voice_search, theme should be included now!

I'm putting up a PR now ot include searchBrowsingHistory as well.

@sblatz sblatz added the eng:qa:needed QA Needed label Jun 12, 2020
@sblatz sblatz moved this from In Dev Review to Ready for QA in Fenix Sprint Kanban Jun 12, 2020
@sblatz
Copy link
Contributor Author

sblatz commented Jun 12, 2020

This is ready to test now!

@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 15, 2020

Hi @sblatz , verified as fixed on the latest Nightly build 200615 from 6/15 Google Pixel 3a (Android 10)

Status Description
✔️ "preferences.sync_items"
✔️ "metrics.toolbar_position"
✔️ "preferences.theme"
✔️ "preferences.show_search_shortcuts"
✔️ "preferences.show_clipboard_suggestions"
✔️ "preferences.search_browsing_history"
✔️ "preferences.search_bookmarks"
✔️ "preferences.show_voice_search"
✔️ "preferences.show_search_suggestions"
✔️ "preferences.search_suggestions_private"
✔️ "preferences.open_links_in_a_private_tab"
✔️ "preferences.tracking_protection"
✔️ "preferences.telemetry"
✔️ "preferences.remote_debugging"
✔️ "preferences.accessibility_services"

• Theme settings

"preferences.theme": [
            "light"
          ]
"preferences.theme": [
            "dark"
          ]
"preferences.theme": [
            "system"

          ]

Logcat
Glean dashboard

Logcat
Glean dashboard

Regarding the previously mentioned "preferences.sync" matter I've opened #11595

@AndiAJ AndiAJ closed this as completed Jun 15, 2020
Fenix Sprint Kanban automation moved this from Ready for QA to Sprint 20.11 Done Jun 15, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 15, 2020
@data-sync-user data-sync-user changed the title [Telemetry] Include state of preferenceToggled events in metrics ping FNX2-16345 ⁃ [Telemetry] Include state of preferenceToggled events in metrics ping Jul 31, 2020
@data-sync-user data-sync-user changed the title FNX2-16345 ⁃ [Telemetry] Include state of preferenceToggled events in metrics ping FNX3-14404 ⁃ [Telemetry] Include state of preferenceToggled events in metrics ping Aug 10, 2020
Fenix Sprint Kanban automation moved this from Sprint 20.11 Done to In Progress Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-14404 ⁃ [Telemetry] Include state of preferenceToggled events in metrics ping FNX-11989 ⁃ [Telemetry] Include state of preferenceToggled events in metrics ping Aug 11, 2020
Fenix Sprint Kanban automation moved this from In Progress to Sprint 20.11 Done Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-11989 ⁃ [Telemetry] Include state of preferenceToggled events in metrics ping FNX2-16345 ⁃ [Telemetry] Include state of preferenceToggled events in metrics ping Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16345 ⁃ [Telemetry] Include state of preferenceToggled events in metrics ping [Telemetry] Include state of preferenceToggled events in metrics ping May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:Telemetry
Projects
Fenix Sprint Kanban
  
Sprint 20.11 Done
Development

No branches or pull requests

4 participants