Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

BaseBrowserFragment: Refactor session manager observers to use store #11285

Closed
csadilek opened this issue Jun 5, 2020 · 1 comment
Closed

BaseBrowserFragment: Refactor session manager observers to use store #11285

csadilek opened this issue Jun 5, 2020 · 1 comment
Assignees
@csadilek
Labels
eng:health Improve code health
Projects
A-C: Browser-State

Comments

@csadilek
Copy link
Contributor

csadilek commented Jun 5, 2020 •
edited by data-sync-user

BaseBrowserFragment is currently using both SessionManager and the browser store. Let's refactor it to use the store only.

We want to get rid of SessionManager observers so we can finish the A-C refactoring to browser state.

┆Issue is synchronized with this Jira Task
@csadilek csadilek added the eng:health Improve code health label Jun 5, 2020
@csadilek csadilek added this to Backlog in A-C: Browser-State Jun 5, 2020
@csadilek csadilek moved this from Backlog to Migration Backlog in A-C: Browser-State Jun 5, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 5, 2020
@kglazko kglazko removed the needs:triage Issue needs triage label Jun 8, 2020
@data-sync-user data-sync-user changed the title HomeFragment: Refactor BrowserSessionsObserver to use store FNX3-14519 ⁃ HomeFragment: Refactor BrowserSessionsObserver to use store Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-14519 ⁃ HomeFragment: Refactor BrowserSessionsObserver to use store FNX-12192 ⁃ HomeFragment: Refactor BrowserSessionsObserver to use store Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12192 ⁃ HomeFragment: Refactor BrowserSessionsObserver to use store FNX2-13406 ⁃ HomeFragment: Refactor BrowserSessionsObserver to use store Aug 11, 2020
@kbrosnan kbrosnan changed the title FNX2-13406 ⁃ HomeFragment: Refactor BrowserSessionsObserver to use store HomeFragment: Refactor BrowserSessionsObserver to use store Aug 29, 2020
@csadilek
Copy link
Contributor Author

csadilek commented Oct 8, 2020

BrowserSessionsObserver was removed in 52c2fdb#diff-f4e9cb78eb3bbc10057cf15de6b220e1 but there are SessionManager observers left in BrowserFragment now, so changing the the title. Problem/Fix is the same: Switch to observing the browser store state change.

@csadilek csadilek changed the title HomeFragment: Refactor BrowserSessionsObserver to use store BaseBrowserFragment: Refactor session manager observers to use store Oct 8, 2020
@csadilek csadilek self-assigned this Oct 20, 2020
csadilek added a commit to csadilek/fenix that referenced this issue Oct 20, 2020
@csadilek
Closes mozilla-mobile#11285: Replace Session[Manager] observers in Ba…
cc956a6 
…seBrowserFragment
@csadilek csadilek mentioned this issue Oct 21, 2020
Closed
csadilek added a commit to csadilek/fenix that referenced this issue Oct 21, 2020
@csadilek
Closes mozilla-mobile#11285: Replace Session[Manager] observers in Ba…
0748952 
…seBrowserFragment
@csadilek csadilek moved this from Migration Backlog to In progress in A-C: Browser-State Oct 21, 2020
csadilek added a commit to csadilek/fenix that referenced this issue Oct 22, 2020
@csadilek
Closes mozilla-mobile#11285: Replace Session[Manager] observers in Ba…
3f29d6b 
…seBrowserFragment
csadilek added a commit to csadilek/fenix that referenced this issue Oct 23, 2020
@csadilek
Closes mozilla-mobile#11285: Replace Session[Manager] observers in Ba…
ab43f3e 
…seBrowserFragment
csadilek added a commit to csadilek/fenix that referenced this issue Oct 26, 2020
@csadilek
Closes mozilla-mobile#11285: Replace Session[Manager] observers in Ba…
7b770f5 
…seBrowserFragment
csadilek added a commit to csadilek/fenix that referenced this issue Oct 26, 2020
@csadilek
Closes mozilla-mobile#11285: Replace Session[Manager] observers in Ba…
beee43f 
…seBrowserFragment
csadilek added a commit to csadilek/fenix that referenced this issue Oct 26, 2020
@csadilek
Closes mozilla-mobile#11285: Replace Session[Manager] observers in Ba…
4e33530 
…seBrowserFragment
csadilek added a commit to csadilek/fenix that referenced this issue Oct 26, 2020
@csadilek
Closes mozilla-mobile#11285: Replace Session[Manager] observers in Ba…
4c58bfd 
…seBrowserFragment
csadilek added a commit to csadilek/fenix that referenced this issue Oct 27, 2020
@csadilek
Closes mozilla-mobile#11285: Replace Session[Manager] observers in Ba…
5fa6664 
…seBrowserFragment
csadilek added a commit to csadilek/fenix that referenced this issue Oct 27, 2020
@csadilek
Closes mozilla-mobile#11285: Replace Session[Manager] observers in Ba…
bc2218b 
…seBrowserFragment
csadilek added a commit to csadilek/fenix that referenced this issue Oct 27, 2020
@csadilek
Closes mozilla-mobile#11285: Replace Session[Manager] observers in Ba…
995cfcc 
…seBrowserFragment
csadilek added a commit to csadilek/fenix that referenced this issue Oct 27, 2020
@csadilek
Closes mozilla-mobile#11285: Replace Session[Manager] observers in Ba…
821218a 
…seBrowserFragment
A-C: Browser-State automation moved this from In progress to Done Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@csadilek csadilek

Labels
eng:health Improve code health
Projects
No open projects
A-C: Browser-State
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@csadilek @kglazko