[Bug] "Report Site Issue" icon does not use correct colors and icons for light and dark themes

[klint]

Steps to reproduce

Set Fenix in dark mode
Open Addon submenu in Fenix main menu (in a page)
Check the icon near to "Report Site Issue"

Expected behavior

Icon is white as other Fenix menu icons

Actual behavior

Icon is black

Device information

• Android device: Redmi Note 7 Miui 11 Android 9
• Fenix version: #2015745203

┆Issue is synchronized with this Jira Task

[hkaancaliskan]

@ekager @mcarare
https://github.com/mozilla-mobile/android-components/blob/master/components/feature/webcompat-reporter/src/main/assets/extensions/webcompat-reporter/manifest.json#L47
adding here theme_icons does nothing (broken feature?).
https://discourse.mozilla.org/t/use-theme-colors-for-svg-favicons/29165/2

"theme_icons": [{
      "light": "icons/lightbulb.svg",
      "dark": "icons/darkbulb.svg",
      "size": 16
    }, {
      "light": "icons/lightbulb.svg",
      "dark": "icons/darkbulb.svg",
      "size": 32
    }]

Is there another way i can do?

[mcarare]

cc: @denschub

[denschub]

We're also tracking this at https://bugzilla.mozilla.org/show_bug.cgi?id=1644451, fwiw.

[gabrielluong]

This is the icon that should be used from #15884 (comment)

https://github.com/mozilla-mobile/fenix/files/5402793/Report.Site.Icons.zip

[klint]

Hi. any update on that issue? Now that the icon moved to the main menu, the color inconsistency in dark mode is more visible and quite obvious. Thanks ;)

[klint]

Hi
Could the be resolved now that the new menu has been implemented? Looks ugly on this new shiny menu... 😋Thanks

[mcarare]

Opened mozilla-mobile/android-components#10092 for a workaround on AC side.

[codrut-topliceanu]

Opened mozilla-mobile/android-components#10092 for a workaround on AC side.

AC fix for this issue has been merged.
Changes will be reflected in Fenix on AC bump.

[klint]

Seems to be fixed on lastest Nightly, thanks a lot. Definitely makes Fenix look better ;)

[denschub]

Hey @mcarare, I noticed that we don't get an icon right now, or a placeholder icon:

Are you aware of that, and is this related to the patch you submitted 10 days ago, or should I open a new bug?

[cadeyrn]

or should I open a new bug?

There is already #19558.

[mcarare]

The report site issue with the light theme will be tracked in #19558.