Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Telemetry] New tab shortcuts #11442

Closed
boek opened this issue Jun 10, 2020 · 2 comments · Fixed by #11823
Closed

[Telemetry] New tab shortcuts #11442

boek opened this issue Jun 10, 2020 · 2 comments · Fixed by #11823
Assignees
@person808
Labels
eng:qa:verified QA Verified Feature:Tabs
Projects
Tabs Tray

Comments

@boek
Copy link
Contributor

boek commented Jun 10, 2020 •
edited by data-sync-user

Follow up for #10374, lets add telemetry probes for the menu items

┆Issue is synchronized with this Jira Task
@boek boek added 🐞 bug Crashes, Something isn't working, .. and removed 🐞 bug Crashes, Something isn't working, .. labels Jun 10, 2020
@boek boek added this to Triage in Tabs Tray via automation Jun 10, 2020
@boek boek moved this from Triage to Sprint in Tabs Tray Jun 10, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 10, 2020
@gabrielluong gabrielluong added Feature:Tabs Skittle and removed needs:triage Issue needs triage labels Jun 10, 2020
person808 added a commit to person808/fenix that referenced this issue Jun 12, 2020
@person808
For mozilla-mobile#11442 - Telemetry for tab counter menu.
2217737
person808 added a commit to person808/fenix that referenced this issue Jun 12, 2020
@person808
For mozilla-mobile#11442 - Telemetry for tab counter menu.
11b7e85
boek pushed a commit that referenced this issue Jun 15, 2020
@person808 @boek
For #11442 - Telemetry for tab counter menu.
9e3e95e
BranescuMihai pushed a commit to BranescuMihai/fenix that referenced this issue Jun 16, 2020
@person808 @BranescuMihai
For mozilla-mobile#11442 - Telemetry for tab counter menu.
b80d50d
@person808 person808 added the eng:qa:needed QA Needed label Jun 17, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 22, 2020

Hi, I've just checked this matter on the latest Nightly Build 200622 from 6/22 using a Google Pixel 3a (Android 10)

• Home screen
New tab - ❌
New Private Tab - ❌

• Page view
✔️ New tab - Ping 01351a07-7c17-4e43-81f2-a800a85eb053
✔️ New Private Tab - Ping 6a00839b-b3db-489a-8bcc-5dcdb25ed575
✔️ Close tab - Ping a22a5225-0ff2-4c70-ba36-ae35aba9cd1c

Logcat
Glean dashboard

@boek - Shouldn't the new tab buttons from the Home screen context menu be also tracked?

I'll remove the QA needed label until further notice

@AndiAJ AndiAJ removed the eng:qa:needed QA Needed label Jun 22, 2020
@boek boek moved this from Sprint to In Progress in Tabs Tray Jun 22, 2020
person808 added a commit to person808/fenix that referenced this issue Jun 22, 2020
@person808
Followup for mozilla-mobile#11442 - Add tab counter menu metrics to h…
7263699 
…ome fragment.
@person808 person808 mentioned this issue Jun 22, 2020
Merged
4 tasks
Tabs Tray automation moved this from In Progress to Done Jun 24, 2020
boek pushed a commit that referenced this issue Jun 24, 2020
@person808 @boek
Followup for #11442 - Add tab counter menu metrics to home fragment.
5f7e0e4
@boek boek moved this from Done to Ready for QA in Tabs Tray Jun 24, 2020
@boek boek added the eng:qa:needed QA Needed label Jun 24, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 25, 2020

Hi, verified as fixed on the latest Nightly Build 200625 from 6/25 using a Google Pixel 3a (Android 10)

• Home fragment ✔️
New tab - Ping 54ef47a8-ce49-4e5a-9d8d-bec125ae4a7c
New Private Tab - Ping 1a4164d3-8035-4cfe-9bd4-2639db69a662

• Page view Normal Browsing ✔️
New tab - Ping beeb7f81-0fa0-47e5-b924-9c8792da1e41
New Private Tab - Ping 0f320608-4505-42ce-936f-c3767c1d0e55
Close tab - Ping 3d7a207b-96f5-4157-abcf-5e03f7daff18

• Page view Private Browsing ✔️
New tab - Ping ebe10636-b209-4767-9753-870a8c073a6f
New Private Tab - Ping 2166001a-2e2e-421a-a9e6-943f675c6dbe
Close tab - Ping 24567d0f-0617-4e6e-8075-e2db0367a0b5

Logcat
Glean dashboard

@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 25, 2020
@AndiAJ AndiAJ moved this from Ready for QA to Done in Tabs Tray Jun 25, 2020
@liuche liuche mentioned this issue Jun 27, 2020
Closed
12 tasks
@data-sync-user data-sync-user changed the title [Telemetry] New tab shortcuts FNX2-16511 ⁃ [Telemetry] New tab shortcuts Aug 1, 2020
@data-sync-user data-sync-user changed the title FNX2-16511 ⁃ [Telemetry] New tab shortcuts FNX3-14643 ⁃ [Telemetry] New tab shortcuts Aug 11, 2020
Tabs Tray automation moved this from Done to In Progress Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-14643 ⁃ [Telemetry] New tab shortcuts FNX-12376 ⁃ [Telemetry] New tab shortcuts Aug 11, 2020
Tabs Tray automation moved this from In Progress to Done Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12376 ⁃ [Telemetry] New tab shortcuts FNX2-16511 ⁃ [Telemetry] New tab shortcuts Aug 11, 2020
@mcarare mcarare mentioned this issue Feb 19, 2021
Closed
@data-sync-user data-sync-user changed the title FNX2-16511 ⁃ [Telemetry] New tab shortcuts [Telemetry] New tab shortcuts May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@person808 person808

Labels
eng:qa:verified QA Verified Feature:Tabs
Projects
No open projects
Tabs Tray
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Followup for #11442 - Add tab counter menu metrics to home fragment. person808/fenix
5 participants
@gabrielluong @boek @person808 @AndiAJ @data-sync-user