Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Edit bookmarks: Wrong button title #11504

Closed
theFireProject opened this issue Jun 12, 2020 · 1 comment
Closed

[Bug] Edit bookmarks: Wrong button title #11504

theFireProject opened this issue Jun 12, 2020 · 1 comment
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified needs:triage Issue needs triage
Projects
Hershey's 🍫

Comments

@theFireProject
Copy link

theFireProject commented Jun 12, 2020 •
edited by data-sync-user

Steps to reproduce

  1. Edit a bookmark or folder
  2. Select the parent folder
    (tap the current parent folder)
  3. Long-press the create new folder icon on the title bar

"Select folder" is displayed

Actual behavior

The button creates a new folder. "Select folder" is the wrong title for that button. It's the description for the current page, but not for the action of the button.

Expected behavior

The button creates/adds a new folder. Accordingly, it should be called "Add folder". That's the same title the add folder button has in the bookmarks section, when not editing any bookmark or folder.

Screenshot

Device information

  • Android device: Samsung Galaxy S9+ (SM-G9650/DS)
  • Android version: 8.0.0
  • Fenix version: 5.1.1

┆Issue is synchronized with this Jira Task
@theFireProject theFireProject added the 🐞 bug Crashes, Something isn't working, .. label Jun 12, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 12, 2020
@mcarare mcarare self-assigned this Jun 12, 2020
@mcarare mcarare added this to In Progress in Hershey's 🍫 Jun 12, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Jun 12, 2020
@mcarare
For mozilla-mobile#11504: Rectify action bar button descriptions in b…
ef486e2 
…ookmarks screen.
@mcarare mcarare moved this from In Progress to In Dev Review in Hershey's 🍫 Jun 12, 2020
ekager pushed a commit that referenced this issue Jun 12, 2020
@mcarare @ekager
For #11504: Rectify action bar button descriptions in bookmarks screen.
eb3e4fc
@ekager ekager added the eng:qa:needed QA Needed label Jun 12, 2020
@sflorean
Copy link
Contributor

Verified as fixed on Nightly 6/15 with Samsung Galaxy Note 10 (Android 10) and Nokia 6 (Android 7.1.1).

@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 15, 2020
@mcarare mcarare moved this from In Dev Review to Done in Hershey's 🍫 Jun 19, 2020
@data-sync-user data-sync-user changed the title [Bug] Edit bookmarks: Wrong button title FNX2-16533 ⁃ [Bug] Edit bookmarks: Wrong button title Aug 1, 2020
@data-sync-user data-sync-user changed the title FNX2-16533 ⁃ [Bug] Edit bookmarks: Wrong button title FNX3-14688 ⁃ [Bug] Edit bookmarks: Wrong button title Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-14688 ⁃ [Bug] Edit bookmarks: Wrong button title FNX-12450 ⁃ [Bug] Edit bookmarks: Wrong button title Aug 11, 2020
Hershey's 🍫 automation moved this from Done to QA Review Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12450 ⁃ [Bug] Edit bookmarks: Wrong button title FNX2-16533 ⁃ [Bug] Edit bookmarks: Wrong button title Aug 11, 2020
@Mugurell Mugurell moved this from QA Review to Done in Hershey's 🍫 Aug 17, 2020
@data-sync-user data-sync-user changed the title FNX2-16533 ⁃ [Bug] Edit bookmarks: Wrong button title [Bug] Edit bookmarks: Wrong button title May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified needs:triage Issue needs triage
Projects
No open projects
Hershey's 🍫
  
Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ekager @mcarare @data-sync-user @sflorean @theFireProject