Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Native crash when opening many tabs rapidly (1 per second) #11653

Closed
mcomella opened this issue Jun 16, 2020 · 14 comments
Closed

[Bug] Native crash when opening many tabs rapidly (1 per second) #11653

mcomella opened this issue Jun 16, 2020 · 14 comments
Labels
b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org

Comments

@mcomella
Copy link
Contributor

mcomella commented Jun 16, 2020

Steps to reproduce

  • Connect device to computer
  • Open many tabs quickly. I ran: while true; do adb shell am start -n org.mozilla.fenix.nightly/org.mozilla.fenix.IntentReceiverActivity https://amazon.com; sleep 1; done

Expected behavior

No crash, tabs open.

Actual behavior

App crash. Looking at the logs, I only see native traces and "Crashes" setting confirms it was a native crash. Crash signature is c6ae7e08-82e9-4436-bc82-ac7f3e3c3ab7 (not loaded into crash-stats yet).

Device information

  • Android device: P2
  • Fenix version: Nightly 200616

┆Issue is synchronized with this Jira Task

@mcomella mcomella added the 🐞 bug Crashes, Something isn't working, .. label Jun 16, 2020
@mcomella mcomella changed the title [Bug] Native crash when opening many tabs rapidly [Bug] Native crash when opening many tabs rapidly (1 per second) Jun 16, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 16, 2020
@kbrosnan kbrosnan added b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info Feature:Tabs needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org labels Jun 16, 2020
@kbrosnan
Copy link
Contributor

That is not a processed crash id. That is the local crash id. A sharable crash ID will end in YYMMDD.

See a similar report in issue #11419

@liuche liuche added this to Backlog in Theme: Eng Health via automation Jun 17, 2020
@liuche liuche moved this from Backlog to Potential Release Blockers & Crashes in Theme: Eng Health Jun 17, 2020
@Mugurell
Copy link
Contributor

I think there's another bug with the crash reporter in relate to native crashes.
I'm seeing in logs.
Submitted crash to Sentry (id=null, url=null)
and
E/mozac/MozillaSocorroCra: failed to send report to Socorro
Will investigate.

@Mugurell Mugurell self-assigned this Jun 17, 2020
@Mugurell Mugurell added this to In Progress in Hershey's 🍫 Jun 17, 2020
@Mugurell
Copy link
Contributor

Could not get the same logs.
Using the adb am start loop as suggested by mcomella I can have this reproduced.
A socorro Report for this- https://crash-stats.mozilla.org/report/index/294379c4-9e46-4244-9806-8f7530200617

@Mugurell
Copy link
Contributor

Interestingly this doesn't seem to be reproducible onGeckoView Example but I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1646352 there since this seems like something the GV team may be better suited to investigate.

@Mugurell Mugurell removed their assignment Jun 17, 2020
@mcarare mcarare moved this from In Progress to Waiting in Hershey's 🍫 Jun 18, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 18, 2020

Hi, I've just checked this on both Nightly 200618 from 6/18 and Beta 5.2.0-beta.2 from 6/16 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

Nightly 200618 from 6/18

• Google Pixel 3a (Android 10) - ✔️ No crash
• Huawei Mate 20 Lite (Android 9) - 💥 Native code crash (No Soccoro link)
• OnePlus A3 (Android 6.0.1) - 💥 Native code crash (No Soccoro link)

Beta 5.2.0-beta.2 from 6/16

• Google Pixel 3a (Android 10) - ✔️ No crash
• Huawei Mate 20 Lite (Android 9) - ✔️ No crash
• OnePlus A3 (Android 6.0.1) - ✔️ No crash

Opened more than 100 tabs using this

Loop
@echo off
goto Loop

:Loop
adb shell am start -n org.mozilla.fenix.nightly/org.mozilla.fenix.IntentReceiverActivity https://amazon.com
goto Loop

exit

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Jun 18, 2020

I tried the loop as well on a Nexus 9 (Android 7.1.1) and got an about:blank tab (after ~14-20 tabs), then a new tab with amazon.com which didn't load, just showed a blank screen. Then the app stopped loading tabs or responding to refreshing and opening new tabs manually. No crash reports were added in about:crashes. Let me know if you need more info, this device is pretty slow FWIW.
Screenshot_20200618-152844

@liuche
Copy link
Contributor

liuche commented Jun 18, 2020

@AndiAJ thanks for the testing. To get the Socorro links, maybe you need to click the "Report" button in the Fenix crash notification in the system notifications tray? Give that a try in the future, hopefully we can get Socorro and Sentry links from about:crashes (which will help us differentiate them).

@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Jun 18, 2020
@gabrielluong gabrielluong added this to Triage in Tabs Tray via automation Jun 18, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 19, 2020

Hi @liuche, clicking the "Report" button in the Fenix crash notification doesn't do the trick, mentioned this in #11419 and #11685

As @Mugurell mentioned above
Sentry (id=null, url=null)
and
E/mozac/MozillaSocorroCra: failed to send report to Socorro

I've re-tested this issue, tapped the notification but yet again, no Soccoro link

► Video
20200619-123115

@Mugurell
Copy link
Contributor

This should probably be fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1644561.
Not sure about the prevalence of the issue on Fenix but with seeing this in the "Potential Release Blockers" column, maybe after verifying it as fixed in the next Nightlyes we could push for an uplift in both GV and Fenix Release.

@sv-ohorvath
Copy link
Contributor

I got this similar crash in one of the automated tests: https://console.firebase.google.com/project/moz-fenix/testlab/histories/bh.66b7091e15d53d45/matrices/6411311184354138254/executions/bs.c1ebb5c4598f8ece/testcases/1/logs
The steps are:
Open 3 dot menu from the homescreen.
Go to Settings.
Go back to homescreen.
Open 3 dot menu, open the Help link.
On the Help tab, tap the tab counter.

Not sure if it's the same crash but looks similar to this bug or #5478
From the logs:
06-22 23:58:50.543: D/GeckoSession(7710): handleMessage GeckoView:PageStart uri=about:blank

--------- beginning of crash 06-22 23:59:43.778: E/AndroidRuntime(7710): FATAL EXCEPTION: FinalizerWatchdogDaemon 06-22 23:59:43.778: E/AndroidRuntime(7710): Process: org.mozilla.fenix.debug, PID: 7710 06-22 23:59:43.778: E/AndroidRuntime(7710): java.util.concurrent.TimeoutException: android.view.ThreadedRenderer.finalize() timed out after 10 seconds

@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 24, 2020

Still reproducible on the latest Nightly Build 200624 from 6/24 using the following devices:
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

@kbrosnan kbrosnan added this to To do in Fenix Crashes via automation Jun 24, 2020
@liuche
Copy link
Contributor

liuche commented Jun 25, 2020

This just landed today, so it should be in the nightly on 6/26. This won't make 78.0.0 but should be fixed in 79.0.0

@liuche liuche mentioned this issue Jun 27, 2020
12 tasks
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 30, 2020

Hi, I've just checked this on both Nightly Build 200629 from 6/30 and Fenix 79.0.1-beta.1 from 6/30 using the following devices:
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

I've ran the loop 3x on each device and build (loaded 100+ tabs)

Nightly Build 200629 from 6/30
Huawei Mate 20 Lite (Android 9) ✔️ No crash
OnePlus A3 (Android 6.0.1) 💥 Crashed 2 out of 3 times, native code crash (No Soccoro link)

Fenix 79.0.1-beta.1 from 6/30
Huawei Mate 20 Lite (Android 9) ✔️ No crash
OnePlus A3 (Android 6.0.1) ✔️ No crash

@sv-ohorvath's Nexus 9 (Android 7.1.1)
Nightly Build 200629 from 6/30 - Stopped loading the loop after approx. 80 tabs but didn't crash
Fenix 79.0.1-beta.1 from 6/30 - Loaded properly 100+ tabs without any crash ✔️

@liuche - Please review and advise

@kbrosnan kbrosnan added this to Needs triage in Android: Crash Tracking Jun 30, 2020
@kbrosnan
Copy link
Contributor

This looks to be fixed then. Thanks for testing @AndiAJ

Fenix Crashes automation moved this from To do to Done Jun 30, 2020
Tabs Tray automation moved this from Triage to Done Jun 30, 2020
Hershey's 🍫 automation moved this from Waiting to QA Review Jun 30, 2020
Android: Crash Tracking automation moved this from Needs triage to Closed Jun 30, 2020
@kbrosnan kbrosnan added the eng:qa:verified QA Verified label Jun 30, 2020
@Mugurell Mugurell moved this from QA Review to Done in Hershey's 🍫 Jul 2, 2020
@data-sync-user data-sync-user changed the title [Bug] Native crash when opening many tabs rapidly (1 per second) FNX2-16600 ⁃ [Bug] Native crash when opening many tabs rapidly (1 per second) Aug 1, 2020
@data-sync-user data-sync-user changed the title FNX2-16600 ⁃ [Bug] Native crash when opening many tabs rapidly (1 per second) FNX3-14797 ⁃ [Bug] Native crash when opening many tabs rapidly (1 per second) Aug 11, 2020
Tabs Tray automation moved this from Done to In Progress Aug 11, 2020
Android: Crash Tracking automation moved this from Closed to Needs triage Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-14797 ⁃ [Bug] Native crash when opening many tabs rapidly (1 per second) FNX-12626 ⁃ [Bug] Native crash when opening many tabs rapidly (1 per second) Aug 11, 2020
Tabs Tray automation moved this from In Progress to Done Aug 11, 2020
Hershey's 🍫 automation moved this from Done to QA Review Aug 11, 2020
Android: Crash Tracking automation moved this from Needs triage to Closed Aug 11, 2020
@Mugurell Mugurell moved this from QA Review to Done in Hershey's 🍫 Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12626 ⁃ [Bug] Native crash when opening many tabs rapidly (1 per second) FNX2-16600 ⁃ [Bug] Native crash when opening many tabs rapidly (1 per second) Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16600 ⁃ [Bug] Native crash when opening many tabs rapidly (1 per second) [Bug] Native crash when opening many tabs rapidly (1 per second) May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org
Projects
No open projects
Development

No branches or pull requests

8 participants