Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Intermittent UI test failure - ThreeDotMenuMainTest.threeDotMenuItemsTest #11764

Closed
sv-ohorvath opened this issue Jun 19, 2020 · 4 comments · Fixed by #11949 or #12313
Closed

Intermittent UI test failure - ThreeDotMenuMainTest.threeDotMenuItemsTest #11764

sv-ohorvath opened this issue Jun 19, 2020 · 4 comments · Fixed by #11949 or #12313
Assignees
@sv-ohorvath
Labels
eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer eng:ui-test UI Tests

Comments

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Jun 19, 2020 •
edited by data-sync-user
Loading

Currently, this test is disabled, due to a GV crash:
#11642
But it looks like it failed for other reasons as well and we need to fix these before re-enabling the test.

Firebase Test Run:

https://console.firebase.google.com/u/0/project/moz-fenix/testlab/histories/bh.66b7091e15d53d45/matrices/7947689494250192878/executions/bs.960d4b1a54f54c3e/testcases/2/test-cases

https://console.firebase.google.com/u/0/project/moz-fenix/testlab/histories/bh.66b7091e15d53d45/matrices/7638769871916277214/executions/bs.e2909c0bd0b77a72/testcases/2/test-cases

https://console.firebase.google.com/u/0/project/moz-fenix/testlab/histories/bh.66b7091e15d53d45/matrices/7947689494250192878/executions/bs.960d4b1a54f54c3e/testcases/2/test-cases

Stacktrace:

java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertNotNull(Assert.java:712)
at org.junit.Assert.assertNotNull(Assert.java:722)
at org.mozilla.fenix.helpers.ext.WaitNotNullKt.waitNotNull(WaitNotNull.kt:20)
at org.mozilla.fenix.ui.robots.BrowserRobot$Transition.openTabDrawer(BrowserRobot.kt:372)
at org.mozilla.fenix.ui.ThreeDotMenuMainTest.threeDotMenuItemsTest(ThreeDotMenuMainTest.kt:65)
at java.lang.reflect.Method.invoke(Native Method)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at androidx.test.internal.runner.junit4.statement.RunBefores.evaluate(RunBefores.java:80)
at androidx.test.internal.runner.junit4.statement.RunAfters.evaluate(RunAfters.java:61)
at androidx.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:531)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
at androidx.test.internal.runner.TestExecutor.execute(TestExecutor.java:56)
at androidx.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:395)
at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:2145)

Build: 6/18/20

┆Issue is synchronized with this Jira Task
@sv-ohorvath sv-ohorvath added eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer eng:ui-test UI Tests labels Jun 19, 2020
@sv-ohorvath sv-ohorvath self-assigned this Jun 19, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 19, 2020
@sv-ohorvath sv-ohorvath added eng:disabled-test For any test that has been disabled and removed needs:triage Issue needs triage labels Jun 19, 2020
@sv-ohorvath sv-ohorvath mentioned this issue Jun 19, 2020
Closed
@sv-ohorvath
Copy link
Contributor Author

sv-ohorvath commented Jun 22, 2020 •
edited
Loading

Espresso performing a long-click instead of a single click issue is the cause here:
Untitled

I'm going to apply the same fix as for the clickAddBookmarkButton() method (#10753) but leave the test disabled until the GV crash is fixed.

sv-ohorvath pushed a commit that referenced this issue Jun 22, 2020
Fixes #11764: re-try single-click on openTabDrawer if a long-tap is made
3c2da23
sv-ohorvath pushed a commit that referenced this issue Jun 22, 2020
Fixes #11764: re-try single-click on openTabDrawer if a long-tap is made
7b82580
sv-ohorvath pushed a commit that referenced this issue Jun 23, 2020
Fixes #11764: re-try single-click on openTabDrawer if a long-tap is made
e9c4747
@sv-ohorvath
Copy link
Contributor Author

sv-ohorvath commented Jun 23, 2020 •
edited
Loading

Fixed the long-click issue, but now there is a new crash uncovered in this test while opening the tab drawer: https://console.firebase.google.com/project/moz-fenix/testlab/histories/bh.66b7091e15d53d45/matrices/6411311184354138254/executions/bs.c1ebb5c4598f8ece/testcases/1/logs

posted in #5478 & #11653 because it looks like it could be the same crash.

sv-ohorvath pushed a commit that referenced this issue Jun 24, 2020
Fixes #11764: re-try single-click on openTabDrawer if a long-tap is made
a33496a
sv-ohorvath pushed a commit that referenced this issue Jun 25, 2020
fixes #11764: delay single-click duration to avoid long-clicks
08db164
sv-ohorvath pushed a commit that referenced this issue Jun 25, 2020
fixes #11764: delay single-click duration to avoid long-clicks
fffb7c1
@sv-ohorvath sv-ohorvath mentioned this issue Jun 25, 2020
Merged
@sv-ohorvath sv-ohorvath linked a pull request Jun 25, 2020 that will close this issue
Fixes #11764: delay single-click duration to avoid long-clicks in ThreeDotMenu UI tests #11949
Merged
sv-ohorvath pushed a commit that referenced this issue Jun 25, 2020
fixes #11764: delay single-click duration to avoid long-clicks
443b782
AaronMT pushed a commit that referenced this issue Jun 25, 2020
For #11764: delay single-click duration to avoid long-clicks (#11949)
45bc42f
@liuche liuche mentioned this issue Jun 27, 2020
Closed
12 tasks
@Archaeopteryx Archaeopteryx reopened this Jul 3, 2020
@Archaeopteryx
Copy link

New occurrence: https://console.firebase.google.com/project/moz-fenix/testlab/histories/bh.66b7091e15d53d45/matrices/7933313855820721897/executions/bs.5daf0220b3760393/testcases/2/test-cases

sv-ohorvath pushed a commit that referenced this issue Jul 6, 2020
For #11764: doubles long-press delay in UI test
123a242
sv-ohorvath pushed a commit that referenced this issue Jul 6, 2020
For #11764: doubles long-press delay UI test
b0797dc
@sv-ohorvath sv-ohorvath mentioned this issue Jul 6, 2020
Merged
4 tasks
@sv-ohorvath sv-ohorvath removed the eng:disabled-test For any test that has been disabled label Jul 6, 2020
sv-ohorvath pushed a commit that referenced this issue Jul 6, 2020
For #11764: doubles long-press delay UI test
836199f
@sv-ohorvath sv-ohorvath linked a pull request Jul 6, 2020 that will close this issue
For #11764: doubles long-press delay UI test #12313
Merged
4 tasks
@sv-ohorvath
Copy link
Contributor Author

Closed in #12313

@liuche liuche mentioned this issue Jul 20, 2020
Closed
9 tasks
@data-sync-user data-sync-user changed the title Intermittent UI test failure - ThreeDotMenuMainTest.threeDotMenuItemsTest FNX3-14889 ⁃ Intermittent UI test failure - ThreeDotMenuMainTest.threeDotMenuItemsTest Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-14889 ⁃ Intermittent UI test failure - ThreeDotMenuMainTest.threeDotMenuItemsTest FNX-12746 ⁃ Intermittent UI test failure - ThreeDotMenuMainTest.threeDotMenuItemsTest Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12746 ⁃ Intermittent UI test failure - ThreeDotMenuMainTest.threeDotMenuItemsTest FNX2-15103 ⁃ Intermittent UI test failure - ThreeDotMenuMainTest.threeDotMenuItemsTest Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-15103 ⁃ Intermittent UI test failure - ThreeDotMenuMainTest.threeDotMenuItemsTest Intermittent UI test failure - ThreeDotMenuMainTest.threeDotMenuItemsTest May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sv-ohorvath sv-ohorvath

Labels
eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer eng:ui-test UI Tests
Projects
None yet
Milestone
No milestone
3 participants
@Archaeopteryx @sv-ohorvath @data-sync-user