Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Mic displayed on widget when Show voice search option is disabled #11819

Closed
Diana-Rus opened this issue Jun 22, 2020 · 8 comments
Closed

[Bug] Mic displayed on widget when Show voice search option is disabled #11819

Diana-Rus opened this issue Jun 22, 2020 · 8 comments
Assignees
@Mugurell
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering feature:SearchWidget Feature:Settings Feature:Voice S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
Android Engineering Team Kanban board
Milestone
90

Comments

@Diana-Rus
Copy link

Diana-Rus commented Jun 22, 2020 •
edited by data-sync-user
Loading

Prerequisites

  • Have search widget set on device's homescreen.
    1. Steps to reproduce
  1. Open app and go to Menu/Settings/Search
  2. Disable option "Show voice search" option.
    1. Expected behavior
      The mic is not present at widget level.
    2. Actual behavior
      The mic is present at widget level.
    3. Device information
  • Android device: Sony Xperia Z5 (Android 7)
  • Fenix version: Nightly 6/22

┆Issue is synchronized with this Jira Task
@Diana-Rus Diana-Rus added 🐞 bug Crashes, Something isn't working, .. feature:SearchWidget S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist Feature:Settings labels Jun 22, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 22, 2020
@Diana-Rus Diana-Rus changed the title [Bug] Mic not displayed on widget when Show voice search option is disabled [Bug] Mic displayed on widget when Show voice search option is disabled Jun 22, 2020
@Diana-Rus Diana-Rus removed the needs:triage Issue needs triage label Jun 22, 2020
@mcarare
Copy link
Contributor

mcarare commented Jun 23, 2020

AFAIK that setting is only for the search bar, not for the widget. cc @sblatz for confirmation.

@sblatz
Copy link
Contributor

sblatz commented Jun 25, 2020

That's correct :) Having this option also affect the search widget seems reasonable, though. Pinging UX for their thoughts.

@sblatz sblatz added the needs:UX-feedback Needs UX Feedback label Jun 25, 2020
@AmyYLee
Copy link
Collaborator

AmyYLee commented Jul 4, 2020

Assigning to @brampitoyo

@brampitoyo
Copy link

@sblatz Correct! If “Show voice search” is disabled under Settings, the mic icon should not be shown in the search widget.

@brampitoyo brampitoyo added eng:ready Ready for engineering and removed needs:UX-feedback Needs UX Feedback labels Jul 8, 2020
@data-sync-user data-sync-user changed the title [Bug] Mic displayed on widget when Show voice search option is disabled FNX3-14934 ⁃ [Bug] Mic displayed on widget when Show voice search option is disabled Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-14934 ⁃ [Bug] Mic displayed on widget when Show voice search option is disabled FNX-12804 ⁃ [Bug] Mic displayed on widget when Show voice search option is disabled Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12804 ⁃ [Bug] Mic displayed on widget when Show voice search option is disabled FNX2-13635 ⁃ [Bug] Mic displayed on widget when Show voice search option is disabled Aug 11, 2020
@kbrosnan kbrosnan changed the title FNX2-13635 ⁃ [Bug] Mic displayed on widget when Show voice search option is disabled [Bug] Mic displayed on widget when Show voice search option is disabled Aug 29, 2020
@stale
Copy link

stale bot commented Feb 25, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 25, 2021
@stale stale bot closed this as completed Mar 4, 2021
@AndiAJ
Copy link
Collaborator

AndiAJ commented Mar 5, 2021

Still reproducible on Firefox 87.0.0 Beta 3 using a OnePlus A3 (Android 6.0.1)

@AndiAJ AndiAJ reopened this Mar 5, 2021
@stale stale bot closed this as completed Mar 12, 2021
@AndiAJ
Copy link
Collaborator

AndiAJ commented Mar 25, 2021

Still reproducible on Firefox 88.0.0 Beta 1 using a OnePlus A3 (Android 6.0.1)

@AndiAJ AndiAJ reopened this Mar 25, 2021
@stale stale bot removed the wontfix label Mar 25, 2021
@mcarare mcarare added this to Top 15 Bugs or User Reported Issues in Android Team Backlog Staging Board Mar 25, 2021
@Mugurell Mugurell self-assigned this Apr 23, 2021
@Mugurell Mugurell added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Apr 23, 2021
@Mugurell Mugurell moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Apr 23, 2021
Mugurell added a commit that referenced this issue Apr 27, 2021
@Mugurell
For #11819 - Show the mic in widget only if setting is enabled
d495d84 
If "Show voice search" is disabled under Settings, the mic icon should not be
shown in the search widget.
@Mugurell Mugurell added the eng:qa:needed QA Needed label Apr 27, 2021
@Mugurell Mugurell added this to the 90 milestone Apr 27, 2021
@lobontiumira
Copy link

Verified as fixed on the 4/28 Nightly build with Google Pixel (Android 10), and Sony Xperia Z5 Premium (Android 7.1.1).

Android Engineering Team Kanban board automation moved this from In Development (WIP limit - 15) to Done Apr 28, 2021
@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 28, 2021
@mcarare mcarare removed this from Top 15 Bugs or User Reported Issues in Android Team Backlog Staging Board Jun 30, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 10, 2021
@Mugurell @pkirakosyan
For mozilla-mobile#11819 - Show the mic in widget only if setting is …
09d3594 
…enabled

If "Show voice search" is disabled under Settings, the mic icon should not be
shown in the search widget.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering feature:SearchWidget Feature:Settings Feature:Voice S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
No open projects
Android Engineering Team Kanban board
Done
Milestone
90
Development

No branches or pull requests
8 participants
@brampitoyo @sblatz @AmyYLee @Mugurell @lobontiumira @mcarare @Diana-Rus @AndiAJ