Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Remember scroll position when saving sessions #1185

Closed
severinrudie opened this issue Mar 25, 2019 · 4 comments
Closed

Remember scroll position when saving sessions #1185

severinrudie opened this issue Mar 25, 2019 · 4 comments
Labels
Milestone

Comments

@severinrudie
Copy link
Contributor

severinrudie commented Mar 25, 2019

Depends on mozilla-mobile/android-components#2700

Why/User Benefit/User Problem

It is common for users to read part of an article, close their phones, and return to finish later. Their session is currently saved when they do so, but their scroll position is not.

[Vesta]
As a user, I want to be able to close the browser, and when I come back to my last session, start reading where I left off. This is key to aligning to our vision of building a browser that is fast by design.

What / Requirements

Scroll position should be saved whenever a session is persisted, and restored when it is reopened.

Acceptance Criteria (how do I know when I’m done?)

I can re-open a session to where I left off in the page.

┆Issue is synchronized with this Jira Task

@severinrudie severinrudie added the feature request 🌟 New functionality and improvements label Mar 25, 2019
@boek boek added the needs:ac Needs Android Component Work label Mar 25, 2019
@vesta0
Copy link
Collaborator

vesta0 commented Mar 26, 2019

Needs an A-C issue and investigation into whether GV work is required @pocmo @boek

@vesta0 vesta0 added this to the Milestone 3 Backlog milestone Mar 26, 2019
@vesta0 vesta0 added Feature:Sessions and removed feature request 🌟 New functionality and improvements labels Mar 27, 2019
@vesta0 vesta0 added P1 Current sprint 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Mar 31, 2019
@ghost ghost added the needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org label Apr 10, 2019
@vesta0 vesta0 added P2 Upcoming release and removed P1 Current sprint labels Apr 12, 2019
@vesta0 vesta0 modified the milestones: MVP Backlog, MVP Metas Apr 15, 2019
@pocmo pocmo removed needs:ac Needs Android Component Work 🙅 waiting Issues that are blocked or has dependencies that are not ready needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org labels Jun 3, 2019
@pocmo
Copy link
Contributor

pocmo commented Jun 3, 2019

Removed a bunch of labels (a-c, Needs GV work, blocked). This has been fixed in GeckoView and uplifted. It's working in RB.

@vesta0
Copy link
Collaborator

vesta0 commented Jun 3, 2019

Thank you @pocmo I believe it's also working in Fenix :)

@vesta0 vesta0 added the eng:qa:needed QA Needed label Jun 3, 2019
@vesta0 vesta0 modified the milestones: MVP Metas, MVP Backlog Jun 3, 2019
@lobontiumira
Copy link

Verified as fixed on the latest build 1.0.1923 (#11550608), with Huawei MediaPad M2 (Android 5.1.1), Sony Xperia Z5 Premium (Android 7.1.1), and OnePlus 5T (Android 9).

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 4, 2019
@data-sync-user data-sync-user changed the title Remember scroll position when saving sessions FNX2-16688 ⁃ Remember scroll position when saving sessions Aug 1, 2020
@data-sync-user data-sync-user changed the title FNX2-16688 ⁃ Remember scroll position when saving sessions FNX3-14953 ⁃ Remember scroll position when saving sessions Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-14953 ⁃ Remember scroll position when saving sessions FNX-4855 ⁃ Remember scroll position when saving sessions Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-4855 ⁃ Remember scroll position when saving sessions FNX2-16688 ⁃ Remember scroll position when saving sessions Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16688 ⁃ Remember scroll position when saving sessions Remember scroll position when saving sessions May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants