Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Error colors in input fields are not consistent throughout the app and do not follow UX specs #11880

Closed
mcarare opened this issue Jun 24, 2020 · 3 comments
Closed

[Bug] Error colors in input fields are not consistent throughout the app and do not follow UX specs #11880

mcarare opened this issue Jun 24, 2020 · 3 comments
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. E1 Estimation Point: trivial, less than half day eng:qa:verified QA Verified Feature:ErrorMessages Feature:Logins Feature:SearchProvider needs:triage Issue needs triage
Projects
Hershey's 🍫

Comments

@mcarare
Copy link
Contributor

mcarare commented Jun 24, 2020 •
edited by data-sync-user
Loading

See screens in : Edit logins & Add search engine

rszUNITO-UNDERSCORE!1rsz!UNITO-UNDERSCORE!img!UNITO-UNDERSCORE!20200622!UNITO-UNDERSCORE!104507!

According to these mocks the colors should be: Light theme - Red 70 #C50042. | Dark theme - Red 40 #FF6A75 :

https://app.abstract.com/share/33afd8de-f90e-4504-90e3-ee2a3bcb1925?mode=design&sha=2b7a1bf44fa2c02a3b7e470075e94c587a491d3b

https://miro.com/app/board/o9J_kwAuqu4=/

And also issue #9596 mentions the same colors.

cc @brampitoyo @ @AmyYLee can you please double check my assessment? Thank you!

┆Issue is synchronized with this Jira Task
@mcarare mcarare added the 🐞 bug Crashes, Something isn't working, .. label Jun 24, 2020
@mcarare mcarare self-assigned this Jun 24, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 24, 2020
@mcarare mcarare added this to In Progress in Hershey's 🍫 Jun 24, 2020
@mcarare mcarare added E1 Estimation Point: trivial, less than half day and removed E3 Estimation Point: average, 2 - 3 days labels Jun 24, 2020
@mcarare mcarare changed the title [Bug] Errors in input fields are not consistent throughout the app and. to not follow UX specs [Bug] Errors in input fields are not consistent throughout the app and do not follow UX specs Jun 24, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Jun 24, 2020
@mcarare
For mozilla-mobile#11880: Provide default text color for errors in a …
67941bb 
…TextInputLayout
@mcarare mcarare moved this from In Progress to In Dev Review in Hershey's 🍫 Jun 24, 2020
@mcarare mcarare changed the title [Bug] Errors in input fields are not consistent throughout the app and do not follow UX specs [Bug] Error colors in input fields are not consistent throughout the app and do not follow UX specs Jun 24, 2020
ekager pushed a commit to mcarare/fenix that referenced this issue Jun 25, 2020
@mcarare @ekager
For mozilla-mobile#11880: Provide default text color for errors in a …
7616775 
…TextInputLayout
ekager pushed a commit that referenced this issue Jun 25, 2020
@mcarare @ekager
For #11880: Provide default text color for errors in a TextInputLayout
4aaa54c
@ekager ekager added the eng:qa:needed QA Needed label Jun 25, 2020
@brampitoyo
Copy link

Hi @mcarare, your assessment was right. To ensure enough colour contrast for readability and accessibility, we’ve decided on two different error colour values for light and dark/private.

Thanks for fixing this issue!

@brampitoyo
Copy link

@mcarare Just adding some colour contrast checker measurements:

Screenshot_2020-06-25 WebAIM Contrast Checker(1)

Screenshot_2020-06-25 WebAIM Contrast Checker

@mcarare mcarare moved this from In Dev Review to QA Review in Hershey's 🍫 Jun 25, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 25, 2020

Hi, verified as fixed on the latest Nightly Build 200625 from 6/25 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)

► Screenshots
rsz_rsz_img_20200625_132822222222

rsz_rsz_screenshot_20200625_1316411_orgmozillafenixnightly

@AndiAJ AndiAJ closed this as completed Jun 25, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 25, 2020
@liuche liuche mentioned this issue Jun 27, 2020
Closed
12 tasks
@mcarare mcarare moved this from QA Review to Done in Hershey's 🍫 Jul 2, 2020
@data-sync-user data-sync-user changed the title [Bug] Error colors in input fields are not consistent throughout the app and do not follow UX specs FNX2-16703 ⁃ [Bug] Error colors in input fields are not consistent throughout the app and do not follow UX specs Aug 1, 2020
@data-sync-user data-sync-user changed the title FNX2-16703 ⁃ [Bug] Error colors in input fields are not consistent throughout the app and do not follow UX specs FNX3-14977 ⁃ [Bug] Error colors in input fields are not consistent throughout the app and do not follow UX specs Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-14977 ⁃ [Bug] Error colors in input fields are not consistent throughout the app and do not follow UX specs FNX-12879 ⁃ [Bug] Error colors in input fields are not consistent throughout the app and do not follow UX specs Aug 11, 2020
Hershey's 🍫 automation moved this from Done to QA Review Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12879 ⁃ [Bug] Error colors in input fields are not consistent throughout the app and do not follow UX specs FNX2-16703 ⁃ [Bug] Error colors in input fields are not consistent throughout the app and do not follow UX specs Aug 11, 2020
@Mugurell Mugurell moved this from QA Review to Done in Hershey's 🍫 Aug 17, 2020
@data-sync-user data-sync-user changed the title FNX2-16703 ⁃ [Bug] Error colors in input fields are not consistent throughout the app and do not follow UX specs [Bug] Error colors in input fields are not consistent throughout the app and do not follow UX specs May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. E1 Estimation Point: trivial, less than half day eng:qa:verified QA Verified Feature:ErrorMessages Feature:Logins Feature:SearchProvider needs:triage Issue needs triage
Projects
No open projects
Hershey's 🍫
  
Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@brampitoyo @ekager @mcarare @AndiAJ @data-sync-user