Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] White almost invisible "close" and "share" icons in custom tabs when Fenix is always set to open tabs in a Private Browsing mode #11903

Closed
ghost opened this issue Jun 24, 2020 · 9 comments
Closed

[Bug] White almost invisible "close" and "share" icons in custom tabs when Fenix is always set to open tabs in a Private Browsing mode #11903

ghost opened this issue Jun 24, 2020 · 9 comments
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:CustomTabs Feature:PrivateBrowsing Feature:Themes Dark mode, light mode, private browsing mode S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@ghost
Copy link

ghost commented Jun 24, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

Have the setting to open all links in Private Browsing enabled by going into 3-dot main menu > settings > Private Browsing > Open links in a private tab > enable

I tested this with Sync for Reddit and Boost for Reddit, when opening any link in custom tabs from them the icons for "close" (to close the tab) and "share" completely white such that they are almost invisible. Please see the screenshots for clarity.

The issue doesn't reproduce if "Open links in a private tab" is not enabled

Expected behavior

Icons shouldn't be white and invisible

Actual behavior

Icons are almost invisible

Device information

  • Android device: Motorola One Power, Android 10.
  • Fenix version: Nightly 200624 06:01.

ScreenshotUNITO-UNDERSCORE!20200624!UNITO-UNDERSCORE!204239!
ScreenshotUNITO-UNDERSCORE!20200624!UNITO-UNDERSCORE!204157!

┆Issue is synchronized with this Jira Task
@ghost ghost added the 🐞 bug Crashes, Something isn't working, .. label Jun 24, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 24, 2020
NotWoods added a commit to NotWoods/fenix that referenced this issue Jun 24, 2020
@NotWoods
For mozilla-mobile#11903: fix custom tab private gradient
252a666
@NotWoods NotWoods self-assigned this Jun 24, 2020
NotWoods added a commit to NotWoods/fenix that referenced this issue Jun 24, 2020
@NotWoods
For mozilla-mobile#11903: fix custom tab private gradient
1364fa5
NotWoods added a commit to NotWoods/fenix that referenced this issue Jun 24, 2020
@NotWoods
For mozilla-mobile#11903: fix custom tab private gradient
f489d93
NotWoods added a commit to NotWoods/fenix that referenced this issue Jun 24, 2020
@NotWoods
For mozilla-mobile#11903: fix custom tab private gradient
c33afa9
ekager pushed a commit that referenced this issue Jun 25, 2020
@NotWoods @ekager
For #11903: fix custom tab private gradient
183ba1b
@ekager ekager added the eng:qa:needed QA Needed label Jun 25, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 25, 2020

Hi, just checked this on the latest Nightly Build 200625 from 6/25 using a Google Pixel 3a (Android 10)

✔️ The "Close" and Action (Share) button are fixed
❌ On the other hand, The TP, Site certificate, URL, and ⋮ Main menu are impropely displayed

►Screenshots
rsz_screenshot_20200625-123347

@NotWoods - Pleasse review. ☺️

@AndiAJ AndiAJ added Feature:CustomTabs S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist Feature:PrivateBrowsing and removed eng:qa:needed QA Needed labels Jun 25, 2020
NotWoods added a commit to NotWoods/fenix that referenced this issue Jun 25, 2020
@NotWoods
For mozilla-mobile#11903: Enforce private theme in custom tabs
ab70467
NotWoods added a commit to NotWoods/fenix that referenced this issue Jun 26, 2020
@NotWoods
For mozilla-mobile#11903: Enforce private theme in custom tabs
bbbcdf4
ekager pushed a commit to NotWoods/fenix that referenced this issue Jun 27, 2020
@NotWoods @ekager
For mozilla-mobile#11903: Enforce private theme in custom tabs
0074f3b
ekager pushed a commit that referenced this issue Jun 27, 2020
@NotWoods @ekager
For #11903: Enforce private theme in custom tabs
ed33478
@ekager ekager added the eng:qa:needed QA Needed label Jun 27, 2020
@liuche liuche mentioned this issue Jun 27, 2020
Closed
12 tasks
@sflorean
Copy link
Contributor

Tested on Nightly 6/30 and 78.0.1-beta.1 and here are my findings:

  1. With Fenix opened in the background in normal browsing: I am still able to reproduce the issue, meaning that "close" and "share" buttons are almost invisible.

  2. With browser closed: close and share buttons are visible on the private background - custom tab, but opening the link in the browser and going to settings results in a blank page:
    Screenshot_2020-06-30-11-19-16

@sflorean sflorean removed the eng:qa:needed QA Needed label Jun 30, 2020
@ghost
Copy link
Author

ghost commented Jul 1, 2020 •
edited by ghost
Loading

The issue still reproducible on Nightly 200701 06:01.

The "Close" and "Share" icon still look just like the screenshots I uploaded in the issue's description.

@ghost ghost mentioned this issue Jul 3, 2020
Closed
@ghost
Copy link

ghost commented Jul 16, 2020

Hi, I'm the reporter of this issue. Please let me know if you need more information.

Thanks! :)

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Jul 23, 2020 •
edited
Loading

@NotWoods I can reproduce the 2nd issue (the screenshot) from this #11903 (comment) with these STR:

  1. Open Private Browsing
  2. Go to settings>Customize, select Dark theme
  3. Select Light theme.

If it wasn't caused by these changes, I'm happy to log a different issue.

@sv-ohorvath sv-ohorvath added the Feature:Themes Dark mode, light mode, private browsing mode label Jul 23, 2020
@Diana-Rus Diana-Rus mentioned this issue Jul 27, 2020
Closed
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 5, 2020
@NotWoods
For mozilla-mobile#11903: Fix private custom tabs
d0b1ec7
NotWoods added a commit that referenced this issue Aug 5, 2020
@NotWoods
For #11903: Fix private custom tabs (#13327)
d45af2a
@NotWoods NotWoods added eng:qa:needed QA Needed and removed needs:triage Issue needs triage labels Aug 6, 2020
@sflorean
Copy link
Contributor

Verified as fixed on Nightly 8/10 with Samsung Galaxy Note 10 (Android 10) and Huawei MediaPad M2 (Android 5.1.1).

@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 10, 2020
@data-sync-user data-sync-user changed the title [Bug] White almost invisible "close" and "share" icons in custom tabs when Fenix is always set to open tabs in a Private Browsing mode FNX3-14996 ⁃ [Bug] White almost invisible "close" and "share" icons in custom tabs when Fenix is always set to open tabs in a Private Browsing mode Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-14996 ⁃ [Bug] White almost invisible "close" and "share" icons in custom tabs when Fenix is always set to open tabs in a Private Browsing mode FNX-12904 ⁃ [Bug] White almost invisible "close" and "share" icons in custom tabs when Fenix is always set to open tabs in a Private Browsing mode Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12904 ⁃ [Bug] White almost invisible "close" and "share" icons in custom tabs when Fenix is always set to open tabs in a Private Browsing mode FNX2-13668 ⁃ [Bug] White almost invisible "close" and "share" icons in custom tabs when Fenix is always set to open tabs in a Private Browsing mode Aug 11, 2020
@B0pol
Copy link

B0pol commented Aug 11, 2020

It doesn't work on my device, Nightly 200811 06:01, Pocophone F1, /e/ (based on lineage os 16, android 9)

@sflorean
Copy link
Contributor

@B0pol could you please add a video, with the issue? thank you!

@B0pol
Copy link

B0pol commented Aug 29, 2020

can you re-open the issue?

@data-sync-user data-sync-user changed the title FNX2-13668 ⁃ [Bug] White almost invisible "close" and "share" icons in custom tabs when Fenix is always set to open tabs in a Private Browsing mode [Bug] White almost invisible "close" and "share" icons in custom tabs when Fenix is always set to open tabs in a Private Browsing mode May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:CustomTabs Feature:PrivateBrowsing Feature:Themes Dark mode, light mode, private browsing mode S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@NotWoods @sv-ohorvath @ekager @AndiAJ @data-sync-user @sflorean @B0pol