Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] URL copied from reader mode is useless: hard-coded as moz-extension://... #12353

Closed
mcomella opened this issue Jul 7, 2020 · 2 comments
Closed

[Bug] URL copied from reader mode is useless: hard-coded as moz-extension://... #12353

mcomella opened this issue Jul 7, 2020 · 2 comments
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:ReaderMode

Comments

@mcomella
Copy link
Contributor

mcomella commented Jul 7, 2020 •
edited by data-sync-user

Steps to reproduce

  • Load a page
  • Enter reader mode
  • After page load, long press on URL
  • Select "copy"
  • (go see what's in your clipboard by clicking URL bar and seeing clipboard suggestion or pasting it somewhere)

Expected behavior

URL is original page URL

Actual behavior

URL is reader mode URL: moz-extension://4cb11be8-83cb-41af-81c3-58e30a4717ab/readerview.html?url=https%3A%2F%2Fwww.nytimes.com%2F2020%2F07%2F07%2Fworld%2Fcoronavirus-updates.html&id=137438953892

This behavior does not appear to apply to sharing the URL.

Device information

  • Android device: P2
  • Fenix version: Nightly 200706

┆Issue is synchronized with this Jira Task
@mcomella mcomella added 🐞 bug Crashes, Something isn't working, .. Feature:ReaderMode labels Jul 7, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 7, 2020
@ekager ekager removed the needs:triage Issue needs triage label Jul 7, 2020
@csadilek
Copy link
Contributor

csadilek commented Jul 7, 2020 •
edited

See mozilla-mobile/android-components#2879 (comment) for a way to fix this with protocol headers.

This will make the URL easier to parse. We would still need a similar workaround as for sharing where we parse the original URL from the reader URL.

csadilek added a commit to csadilek/fenix that referenced this issue Jul 8, 2020
@csadilek
For mozilla-mobile#12353: URL copied to clipboard should not be exten…
92508a2 
…sion/reader URL
csadilek added a commit to csadilek/fenix that referenced this issue Jul 8, 2020
@csadilek
For mozilla-mobile#12353: URL copied to clipboard should not be exten…
c27f012 
…sion/reader URL
csadilek added a commit to csadilek/fenix that referenced this issue Jul 8, 2020
@csadilek
For mozilla-mobile#12353: URL copied to clipboard should not be exten…
3a6592d 
…sion/reader URL
ekager pushed a commit that referenced this issue Jul 8, 2020
@csadilek @ekager
For #12353: URL copied to clipboard should not be extension/reader URL
216396d
@ekager ekager added the eng:qa:needed QA Needed label Jul 8, 2020
@abodea
Copy link
Member

abodea commented Jul 9, 2020 •
edited

Verified as fixed on the latest Nightly 7/9 with Google Pixel 4 XL (10).
Note that the URL is displayed correctly now.

@abodea abodea closed this as completed Jul 9, 2020
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jul 9, 2020
@liuche liuche mentioned this issue Jul 20, 2020
Closed
9 tasks
@data-sync-user data-sync-user changed the title [Bug] URL copied from reader mode is useless: hard-coded as moz-extension://... FNX3-15324 ⁃ [Bug] URL copied from reader mode is useless: hard-coded as moz-extension://... Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15324 ⁃ [Bug] URL copied from reader mode is useless: hard-coded as moz-extension://... FNX-13401 ⁃ [Bug] URL copied from reader mode is useless: hard-coded as moz-extension://... Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-13401 ⁃ [Bug] URL copied from reader mode is useless: hard-coded as moz-extension://... FNX2-15185 ⁃ [Bug] URL copied from reader mode is useless: hard-coded as moz-extension://... Aug 11, 2020
@csadilek csadilek mentioned this issue Sep 1, 2020
Closed
@data-sync-user data-sync-user changed the title FNX2-15185 ⁃ [Bug] URL copied from reader mode is useless: hard-coded as moz-extension://... [Bug] URL copied from reader mode is useless: hard-coded as moz-extension://... May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:ReaderMode
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@csadilek @mcomella @NotWoods @ekager @abodea @data-sync-user