Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Reuse common elements of tracking protection and login exceptions #12522

Closed
ekager opened this issue Jul 13, 2020 · 0 comments
Closed

Reuse common elements of tracking protection and login exceptions #12522

ekager opened this issue Jul 13, 2020 · 0 comments
Assignees
@NotWoods
Labels
eng:health Improve code health

Comments

@ekager
Copy link
Contributor

ekager commented Jul 13, 2020 •
edited by data-sync-user
Loading

In theory these UIs are very similar. Should be able to use the same general layouts, adapters, viewholders, and interactors with different copy, storage layers, and data types.

Some difficulties could lie the differences in the TP exceptions storage and the Login Exceptions storage, ie reloading, fetching, deleting and working around the AC-provided data types.

┆Issue is synchronized with this Jira Task
@ekager ekager added the eng:health Improve code health label Jul 13, 2020
@ekager ekager mentioned this issue Jul 13, 2020
Merged
4 tasks
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 13, 2020
@ekager ekager removed the needs:triage Issue needs triage label Jul 13, 2020
@NotWoods NotWoods self-assigned this Jul 28, 2020
NotWoods added a commit to NotWoods/fenix that referenced this issue Jul 28, 2020
@NotWoods
Closes mozilla-mobile#12522: Reuse exceptions code
bcbda66
NotWoods added a commit to NotWoods/fenix that referenced this issue Jul 31, 2020
@NotWoods
Closes mozilla-mobile#12522: Reuse exceptions code
09216bf
@data-sync-user data-sync-user changed the title Reuse common elements of tracking protection and login exceptions FNX3-13548 ⁃ Reuse common elements of tracking protection and login exceptions Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-13548 ⁃ Reuse common elements of tracking protection and login exceptions FNX-13598 ⁃ Reuse common elements of tracking protection and login exceptions Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-13598 ⁃ Reuse common elements of tracking protection and login exceptions FNX2-15305 ⁃ Reuse common elements of tracking protection and login exceptions Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-15305 ⁃ Reuse common elements of tracking protection and login exceptions Reuse common elements of tracking protection and login exceptions May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NotWoods NotWoods

Labels
eng:health Improve code health
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NotWoods @ekager @data-sync-user