Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Separate release locale list from master locale list. #12759

Closed
person808 opened this issue Jul 20, 2020 · 3 comments
Closed

Separate release locale list from master locale list. #12759

person808 opened this issue Jul 20, 2020 · 3 comments
Assignees
Labels
eng:automation Build automation, Continuous integration, .. 🌐 L10N Localization, translation, strings, ..

Comments

@person808
Copy link
Contributor

person808 commented Jul 20, 2020

We use l10n.toml to define what locales to include in our builds. For release we want to use a separate list of locales than on the master branch. To allow us to have the same l10n.toml file on master and release branches we should create a separate list that is used to filter out locales on release builds. We can't modify this list on master because Pontoon uses it to expose locales to translators.

┆Issue is synchronized with this Jira Task

@person808 person808 added eng:automation Build automation, Continuous integration, .. 🌐 L10N Localization, translation, strings, .. labels Jul 20, 2020
@person808 person808 self-assigned this Jul 20, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 20, 2020
@person808 person808 removed the needs:triage Issue needs triage label Jul 20, 2020
person808 added a commit to person808/fenix that referenced this issue Jul 20, 2020
person808 added a commit to person808/fenix that referenced this issue Jul 21, 2020
person808 added a commit to person808/fenix that referenced this issue Jul 21, 2020
person808 added a commit to person808/fenix that referenced this issue Jul 21, 2020
@person808 person808 added the eng:qa:needed QA Needed label Jul 21, 2020
@person808
Copy link
Contributor Author

person808 commented Jul 21, 2020

Note for QA: we want to check that the apk from here should have only the locales in l10n-release.toml in the Settings > Languages screen. If we can verify the locale filter is running on one build in TC then it should be working for all build variants its needed for.

@lobontiumira
Copy link

Verified all the languages from the locales in l10n-release.toml, on the build from here with OnePlus 5T (Android 9).
Three languages are missing on the build from above, but they are available on the 7/27 Nightly build:

  1. Hebrew "he".
  2. Bahasa Indonesia "id".
  3. Triqui "trs".

I'll remove the qa:needed label for now.
@person808 please let us know if there is anything else we can do.
Thanks!

@lobontiumira lobontiumira removed the eng:qa:needed QA Needed label Jul 27, 2020
@person808
Copy link
Contributor Author

Likely just a delay in pulling in the translations thanks!

@data-sync-user data-sync-user changed the title Separate release locale list from master locale list. FNX3-21877 ⁃ Separate release locale list from master locale list. Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-21877 ⁃ Separate release locale list from master locale list. FNX-13876 ⁃ Separate release locale list from master locale list. Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-13876 ⁃ Separate release locale list from master locale list. FNX2-15455 ⁃ Separate release locale list from master locale list. Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-15455 ⁃ Separate release locale list from master locale list. Separate release locale list from master locale list. May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:automation Build automation, Continuous integration, .. 🌐 L10N Localization, translation, strings, ..
Projects
None yet
Development

No branches or pull requests

3 participants