Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Migrate library menus to concept-menu #12862

Closed
2 tasks done
NotWoods opened this issue Jul 23, 2020 · 1 comment
Closed
2 tasks done

Migrate library menus to concept-menu #12862

NotWoods opened this issue Jul 23, 2020 · 1 comment
Assignees
@NotWoods
Labels
eng:qa:verified QA Verified Feature:Bookmarks Feature:History
Projects
A-C: Concept-Menu

Comments

@NotWoods
Copy link
Contributor

NotWoods commented Jul 23, 2020 •
edited by data-sync-user

Classes still using browser-menu:

  • BookmarkItemMenu
  • HistoryItemMenu

After converting to the new library, the menus should still work in the same way.

┆Issue is synchronized with this Jira Task
@NotWoods NotWoods added this to Backlog in A-C: Concept-Menu Jul 23, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 23, 2020
@eliserichards eliserichards removed the needs:triage Issue needs triage label Jul 27, 2020
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 6, 2020
@NotWoods
For mozilla-mobile#12862: Use concept-menu in library
7217027
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 10, 2020
@NotWoods
For mozilla-mobile#12862: Use concept-menu in library
8484c0b
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 10, 2020
@NotWoods
For mozilla-mobile#12862: Use concept-menu in library
a949f3f
@data-sync-user data-sync-user changed the title Migrate library menus to concept-menu FNX3-21934 ⁃ Migrate library menus to concept-menu Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-21934 ⁃ Migrate library menus to concept-menu FNX-13998 ⁃ Migrate library menus to concept-menu Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-13998 ⁃ Migrate library menus to concept-menu FNX2-15510 ⁃ Migrate library menus to concept-menu Aug 11, 2020
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 12, 2020
@NotWoods
For mozilla-mobile#12862: Use concept-menu in library
8d44e3b
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 13, 2020
@NotWoods
For mozilla-mobile#12862: Use concept-menu in library
56b8bb7
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 14, 2020
@NotWoods
For mozilla-mobile#12862: Use concept-menu in library
6d61567
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 14, 2020
@NotWoods
For mozilla-mobile#12862: Use concept-menu in library
a9753b4
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 14, 2020
@NotWoods
For mozilla-mobile#12862: Use concept-menu in library
7a97e7b
NotWoods added a commit that referenced this issue Aug 14, 2020
@NotWoods
FNX-14513 ⁃ For #12862: Use concept-menu in library (#13332)
a04b91e
@NotWoods NotWoods added the eng:qa:needed QA Needed label Aug 15, 2020
@NotWoods NotWoods moved this from Backlog to Done in A-C: Concept-Menu Aug 15, 2020
@sflorean
Copy link
Contributor

Verified as fixed on Nightly 8/19 with Samsung Galaxy Note 10 (Android 10) and Google Pixel 3 (Android 11).

@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 19, 2020
@data-sync-user data-sync-user changed the title FNX2-15510 ⁃ Migrate library menus to concept-menu Migrate library menus to concept-menu May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NotWoods NotWoods

Labels
eng:qa:verified QA Verified Feature:Bookmarks Feature:History
Projects
No open projects
A-C: Concept-Menu
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NotWoods @eliserichards @sflorean