Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Clear icons when clearing private data #12980

Closed
pocmo opened this issue Jul 27, 2020 · 7 comments
Closed

Clear icons when clearing private data #12980

pocmo opened this issue Jul 27, 2020 · 7 comments
Assignees
@BranescuMihai @Mugurell
Labels
E2 Estimation Point: easy, half a day to 2 days eng:qa:verified QA Verified eng:tech-debt Engineering debt. Missing unit tests, etc. Feature:Privacy&Security
Projects
Hershey's 🍫

Comments

@pocmo
Copy link
Contributor

pocmo commented Jul 27, 2020 •
edited by data-sync-user

See mozilla-mobile/android-components#7766 for details.

We added BrowserIcons.clear() to make it possible to remove all icons from disk and memory.

┆Issue is synchronized with this Jira Task
@pocmo pocmo mentioned this issue Jul 27, 2020
Closed
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 27, 2020
@eliserichards eliserichards added eng:tech-debt Engineering debt. Missing unit tests, etc. and removed needs:triage Issue needs triage labels Jul 27, 2020
@mcarare mcarare added this to Sprint in Hershey's 🍫 Jul 30, 2020
@BranescuMihai BranescuMihai moved this from Sprint to In Progress in Hershey's 🍫 Aug 3, 2020
@BranescuMihai BranescuMihai self-assigned this Aug 3, 2020
@BranescuMihai BranescuMihai added the needs:UX-feedback Needs UX Feedback label Aug 4, 2020
@BranescuMihai
Copy link
Contributor

Question for UX: From a user's perspective, which of the two options from the Delete browsing data fragment you would associate with clearing the favicons:

  • Browsing history and site data
  • Cached images and files

I would personally go with the first, since that is the one that I associate with removing all trace of me visiting a website.

@Mugurell Mugurell added the E2 Estimation Point: easy, half a day to 2 days label Aug 6, 2020
@BranescuMihai BranescuMihai moved this from In Progress to Waiting in Hershey's 🍫 Aug 6, 2020
@data-sync-user data-sync-user changed the title Clear icons when clearing private data FNX3-22019 ⁃ Clear icons when clearing private data Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-22019 ⁃ Clear icons when clearing private data FNX-14124 ⁃ Clear icons when clearing private data Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-14124 ⁃ Clear icons when clearing private data FNX2-15598 ⁃ Clear icons when clearing private data Aug 11, 2020
@apbitner
Copy link

Assigning @AmyYLee for UX follow-up

@AmyYLee
Copy link
Collaborator

AmyYLee commented Aug 14, 2020

Question for UX: From a user's perspective, which of the two options from the Delete browsing data fragment you would associate with clearing the favicons:

* Browsing history and site data

* Cached images and files

I would personally go with the first, since that is the one that I associate with removing all trace of me visiting a website.

@betsymi on this one since it's about strings. I personally think of the second option because I think of favs as part of cached images.

@betsymi
Copy link

betsymi commented Aug 18, 2020

I do love a good string debate! I am going to recommend Browsing history and site data because I find the language simpler and easier to understand. "Cached" veers on the side of jargony. While it may be more specific, I'd rather veer on the side of removing all traces.

@apbitner apbitner removed the needs:UX-feedback Needs UX Feedback label Aug 19, 2020
@Mugurell Mugurell mentioned this issue Aug 21, 2020
Closed
@Mugurell Mugurell self-assigned this Aug 21, 2020
@Mugurell Mugurell moved this from Waiting to In Dev Review in Hershey's 🍫 Aug 26, 2020
@Mugurell
Copy link
Contributor

Hey @betsymi, @AmyYLee , just to confirm, because it came up in review,
Clearing the icons should happen when the user selects

  • "Browsing history and site data"
    or
  • "Cached images and files"

?

@liuche liuche added the needs:UX-feedback Needs UX Feedback label Aug 27, 2020
@betsymi
Copy link

betsymi commented Aug 27, 2020

Browsing history and site data

mcarare pushed a commit that referenced this issue Aug 28, 2020
@Mugurell @mcarare
For #12980 - Unify deleteBrowsingData() and deleteHistoryAndDOMStorag…
aa7283d 
…es()

The two methods are serving the same purpose, with one calling the other.
This prepares the ground for adding a method to delete icons in only one place
and remove confusion about what that place should be.
mcarare pushed a commit that referenced this issue Aug 28, 2020
@Mugurell @mcarare
For #12980 - Clear icons when deleting browsing data
acdef76
@kbrosnan kbrosnan changed the title FNX2-15598 ⁃ Clear icons when clearing private data Clear icons when clearing private data Aug 29, 2020
@mcarare mcarare moved this from In Dev Review to QA Review in Hershey's 🍫 Aug 31, 2020
@mcarare mcarare added the eng:qa:needed QA Needed label Aug 31, 2020
@Mugurell Mugurell removed the needs:UX-feedback Needs UX Feedback label Aug 31, 2020
TrianguloY pushed a commit to TrianguloY/fenix that referenced this issue Sep 3, 2020
@Mugurell @TrianguloY
For mozilla-mobile#12980 - Unify deleteBrowsingData() and deleteHisto…
22886a2 
…ryAndDOMStorages()

The two methods are serving the same purpose, with one calling the other.
This prepares the ground for adding a method to delete icons in only one place
and remove confusion about what that place should be.
TrianguloY pushed a commit to TrianguloY/fenix that referenced this issue Sep 3, 2020
@Mugurell @TrianguloY
For mozilla-mobile#12980 - Clear icons when deleting browsing data
929e0e4
@lobontiumira
Copy link

Hi all,
Verified as fixed on a debug build from 9/7 (AC: 58.0.20200906130403, b6c304b2a) on Samsung Galaxy Tab S6 (Android 9).
In the screenshots below, the first image represents the mozac_browser_icons before the deletion, and the second screenshot is after deletion. I've only selected to delete "Browsing history and site data" from the "Delete browsing data" page.

deletebrowsingdata

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 7, 2020
@Mugurell Mugurell moved this from QA Review to Done Sprint 20.18 in Hershey's 🍫 Sep 7, 2020
@mcarare mcarare moved this from Done Sprint 20.19 to Done in Hershey's 🍫 Sep 18, 2020
@code644 code644 mentioned this issue Oct 16, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BranescuMihai BranescuMihai

@Mugurell Mugurell

Labels
E2 Estimation Point: easy, half a day to 2 days eng:qa:verified QA Verified eng:tech-debt Engineering debt. Missing unit tests, etc. Feature:Privacy&Security
Projects
No open projects
Hershey's 🍫
  
Done
Milestone
No milestone
Development

No branches or pull requests