Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

When the New Tab Page has the keyboard open, the keyboard should be easy to dismiss #13053

Closed
brampitoyo opened this issue Jul 29, 2020 · 3 comments

Comments

@brampitoyo
Copy link

brampitoyo commented Jul 29, 2020

Current

To see “the rest of the New Tab Page” and dismiss the keyboard, people may only use the system back button/gesture.

Proposal

People may either use the system back button/gesture, or simply swipe up/down the area that’s not covered by the keyboard.

We’ve “pre-committed” people to the Search/URL path by auto-selecting the address bar on NTP, so let’s not make them “commit to search 100%” until they’ve typed a character into the address bar. Give them an easy way to exit out and see “the rest of the NTP”.

People can dismiss the keyboard by simply swiping up or down the NTP area. When the keyboard is dismissed, the address bar returns to its initial/unselected position and the rest of the NTP shows up in full.

This should work as long as nothing has been typed into the address bar.

Before swiping up/down After swiping up/down

When a keyword has been entered into the address bar, we assume that people have “committed to search 100%”, so swiping up or down won’t exit out of the address bar. It will just allow them to see more suggestions.

The current search results ordering is not changed: we are keeping top-to-bottom.

After entering keyword After swiping up/down

And just as our behaviour today, tap/gesture back once is still the equivalent of exiting out of the search screen. The keyboard dismisses, the address bar returns to its initial/unselected position and the rest of the NTP shows up in full.

|----|
| Tap/gesture back once (after entering keyword) |

| ------------- |

|----|
| |

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 29, 2020
@vesta0 vesta0 removed the needs:triage Issue needs triage label Jul 29, 2020
boek added a commit to boek/fenix that referenced this issue Aug 7, 2020
@data-sync-user data-sync-user changed the title When the New Tab Page has the keyboard open, the keyboard should be easy to dismiss FNX3-22060 ⁃ When the New Tab Page has the keyboard open, the keyboard should be easy to dismiss Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-22060 ⁃ When the New Tab Page has the keyboard open, the keyboard should be easy to dismiss FNX-14226 ⁃ When the New Tab Page has the keyboard open, the keyboard should be easy to dismiss Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-14226 ⁃ When the New Tab Page has the keyboard open, the keyboard should be easy to dismiss FNX2-15637 ⁃ When the New Tab Page has the keyboard open, the keyboard should be easy to dismiss Aug 11, 2020
@data-sync-user
Copy link

➤ Elise Richards commented:

🚩 Flag added

Blocked on impl in #13052

@vesta0 vesta0 added this to Q3 Backlog in Fenix Product Backlog Aug 19, 2020
@kbrosnan kbrosnan changed the title FNX2-15637 ⁃ When the New Tab Page has the keyboard open, the keyboard should be easy to dismiss When the New Tab Page has the keyboard open, the keyboard should be easy to dismiss Aug 29, 2020
@vesta0
Copy link
Collaborator

vesta0 commented Sep 16, 2020

@brampitoyo is this work completed? Can we close this issue?

@brampitoyo
Copy link
Author

@vesta0 Yes. This work is now completed. Let’s close this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants