Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Download does not work on a custom tab (Slack) #1311

Closed
vesta0 opened this issue Apr 2, 2019 · 3 comments
Closed

Download does not work on a custom tab (Slack) #1311

vesta0 opened this issue Apr 2, 2019 · 3 comments
Assignees
@Amejia481
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:CustomTabs P1 Current sprint 🙅 waiting Issues that are blocked or has dependencies that are not ready
Projects
A-C: Android Components Sprint Planning
Milestone
Bugs and Polish

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Apr 2, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

-Open a custom tap from slack
-Tap on a link on the page to download a file

Expected behavior

-Download confirmation prompt pops up and you can tap on DOWNLOAD

Actual behavior

-Nothing happens

Device information

  • Android device: Pixel 3
  • Fenix version: 1.0.1914

┆Issue is synchronized with this Jira Task
@vesta0 vesta0 added 🐞 bug Crashes, Something isn't working, .. P1 Current sprint needs:investigation labels Apr 2, 2019
@vesta0 vesta0 added this to the Bugs milestone Apr 2, 2019
@vesta0 vesta0 added Feature:CustomTabs needs:ac Needs Android Component Work 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Apr 2, 2019
@vesta0 vesta0 added the beta label Apr 17, 2019
@vesta0 vesta0 added this to 🐉 Fenix Backlog in A-C: Android Components Sprint Planning Apr 22, 2019
@jonalmeida
Copy link
Contributor

jonalmeida commented Apr 22, 2019 •
edited
Loading

Fenix needs to pass in the session ID to the features so that they become session aware.

See the relevant r-b PR: https://github.com/mozilla-mobile/reference-browser/pull/553/files

@jonalmeida jonalmeida removed the needs:ac Needs Android Component Work label Apr 22, 2019
@vesta0
Copy link
Collaborator Author

vesta0 commented Apr 22, 2019

@colintheshots please see the comment above and confirm if this is all Fenix work.

@vesta0 vesta0 removed the beta label Apr 30, 2019
@jonalmeida jonalmeida mentioned this issue Apr 30, 2019
Closed
@vesta0 vesta0 moved this from 🐉 Fenix Backlog to ⏳ Sprint Backlog in A-C: Android Components Sprint Planning May 6, 2019
@Amejia481 Amejia481 self-assigned this May 6, 2019
@Amejia481 Amejia481 moved this from ⏳ Sprint Backlog to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning May 7, 2019
Amejia481 added a commit to Amejia481/fenix that referenced this issue May 7, 2019
@Amejia481
Closes mozilla-mobile#1311: Enable downloads in custom tabs.
ffefd39
A-C: Android Components Sprint Planning automation moved this from 🏃‍♀️ In Progress to 🏁 Done May 7, 2019
@Amejia481 Amejia481 reopened this May 8, 2019
@Amejia481 Amejia481 added the eng:qa:needed QA Needed label May 8, 2019
@project-bot project-bot bot added this to Ready for QA in Fenix Sprint Kanban May 8, 2019
@sv-ohorvath
Copy link
Contributor

Verified as fixed on the 5/8 build.
devices: Pixel(Android 9), P9 lite (Android 6)

@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 9, 2019
@sv-ohorvath sv-ohorvath moved this from Ready for QA to Done in Fenix Sprint Kanban May 9, 2019
@data-sync-user data-sync-user changed the title Download does not work on a custom tab (Slack) FNX2-17026 ⁃ Download does not work on a custom tab (Slack) Aug 3, 2020
@data-sync-user data-sync-user changed the title FNX2-17026 ⁃ Download does not work on a custom tab (Slack) FNX3-15475 ⁃ Download does not work on a custom tab (Slack) Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15475 ⁃ Download does not work on a custom tab (Slack) FNX-4950 ⁃ Download does not work on a custom tab (Slack) Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-4950 ⁃ Download does not work on a custom tab (Slack) FNX2-17026 ⁃ Download does not work on a custom tab (Slack) Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-17026 ⁃ Download does not work on a custom tab (Slack) Download does not work on a custom tab (Slack) May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Amejia481 Amejia481

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:CustomTabs P1 Current sprint 🙅 waiting Issues that are blocked or has dependencies that are not ready
Projects
No open projects
A-C: Android Components Sprint Planning
  
🏁 Done
Milestone
Bugs and Polish
Development

No branches or pull requests
6 participants
@kbrosnan @Amejia481 @jonalmeida @sv-ohorvath @vesta0 @data-sync-user