Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Strange Tab in Collections Items Behavior When Deleting Multiple Tabs #13177

Closed
ekager opened this issue Jul 31, 2020 · 8 comments
Closed

Strange Tab in Collections Items Behavior When Deleting Multiple Tabs #13177

ekager opened this issue Jul 31, 2020 · 8 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:ready Ready for engineering Feature:Collections help wanted Help wanted from a contributor. More complex than good first issue.

Comments

@ekager
Copy link
Contributor

ekager commented Jul 31, 2020

  1. If a collection has 2 items and you swipe them away one by one, it won't prompt you or delete the collection on the last item's removal (so then you end up with an empty collection).
  2. Swiping away on the bottom tab of a collection doesn't update the remaining item to be the next bottom item visually.

┆Issue is synchronized with this Jira Task

@ekager ekager added 🐞 bug Crashes, Something isn't working, .. Feature:Collections labels Jul 31, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 31, 2020
@ekager ekager removed the needs:triage Issue needs triage label Jul 31, 2020
@data-sync-user data-sync-user changed the title [Bug] Strange Tab in Collections Items Behavior When Deleting Multiple Tabs FNX3-22941 ⁃ [Bug] Strange Tab in Collections Items Behavior When Deleting Multiple Tabs Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-22941 ⁃ [Bug] Strange Tab in Collections Items Behavior When Deleting Multiple Tabs FNX-14358 ⁃ [Bug] Strange Tab in Collections Items Behavior When Deleting Multiple Tabs Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-14358 ⁃ [Bug] Strange Tab in Collections Items Behavior When Deleting Multiple Tabs FNX2-18832 ⁃ [Bug] Strange Tab in Collections Items Behavior When Deleting Multiple Tabs Aug 11, 2020
@kbrosnan kbrosnan changed the title FNX2-18832 ⁃ [Bug] Strange Tab in Collections Items Behavior When Deleting Multiple Tabs [Bug] Strange Tab in Collections Items Behavior When Deleting Multiple Tabs Aug 29, 2020
@liuche
Copy link
Contributor

liuche commented Sep 8, 2020

Empty state for Collections - is this something that @ekager and @topotropic can look at during the Collections sprint?

@ekager ekager added eng:ready Ready for engineering help wanted Help wanted from a contributor. More complex than good first issue. labels Sep 9, 2020
@amedyne amedyne added the Beta Beta release bugs label Jan 28, 2021
@amedyne amedyne removed the Beta Beta release bugs label Jan 28, 2021
@stale
Copy link

stale bot commented Jul 27, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 27, 2021
@stale stale bot closed this as completed Aug 3, 2021
@AndiAJ
Copy link
Collaborator

AndiAJ commented Aug 11, 2021

Still reproducible on Firefox 92.0.0 Beta 1 using a OnePlus A3 (Android 6.0.1)

@AndiAJ AndiAJ reopened this Aug 11, 2021
@stale stale bot removed the wontfix label Aug 11, 2021
@stale
Copy link

stale bot commented Feb 7, 2022

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 7, 2022
@stale stale bot closed this as completed Feb 15, 2022
@sv-ohorvath
Copy link
Contributor

Still reproducible on Nightly 100. Reopening

@sv-ohorvath sv-ohorvath reopened this Apr 5, 2022
@stale stale bot removed the wontfix label Apr 5, 2022
@stale
Copy link

stale bot commented Nov 23, 2022

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 23, 2022
@SoftVision-LorandJanos
Copy link

SoftVision-LorandJanos commented Nov 23, 2022

  1. The issue with the collection is still reproducible, also, seems to be related to [Empty collection can be created #20391. Collection can be created empty or delete all its items for it to be empty and still exist.
  2. I don't know if I understood the second part right, for me the behavior looks expected, however there is an issue with Collection created with a webpage (which after adding a few more pages gets to the bottom of the list) and if the original item is deleted, the collection is closed/deleted with all its added content (See Collection is automatically deleted while still containing tabs #24539 (comment)).

Tested on the latest Nightly 109.0a1 (2022-11-23) build.
Device used for testing: Oppo Find X5 (Android 12).

@stale stale bot removed the wontfix label Nov 23, 2022
@DreVla DreVla self-assigned this Nov 23, 2022
@boek boek changed the title [Bug] Strange Tab in Collections Items Behavior When Deleting Multiple Tabs Strange Tab in Collections Items Behavior When Deleting Multiple Tabs Jan 26, 2023
@boek
Copy link
Contributor

boek commented Jan 26, 2023

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1812746

Change performed by the Move to Bugzilla add-on.

@boek boek closed this as completed Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:ready Ready for engineering Feature:Collections help wanted Help wanted from a contributor. More complex than good first issue.
Projects
None yet
Development

No branches or pull requests

8 participants