Detekt errors on releases/v80.0.0 and master

[sysrqb]

Running ./gradlew detekt there are two separate issues.

1. The original exception message was: Value "trued" set for config parameter "complexity > LongParameterList > active" is not of required type Boolean.

This error exists on master, too, and it is fixed by

diff --git a/config/detekt.yml b/config/detekt.yml
index 56b6041c2..2568a929e 100644
--- a/config/detekt.yml
+++ b/config/detekt.yml
@@ -76,7 +76,7 @@ complexity:
     # https://github.com/mozilla-mobile/fenix/issues/4861
     threshold: 75
   LongParameterList:
-    active: trued
+    active: true
     excludes: "**/*Controller.kt, **/*Integration.kt"
     functionThreshold: 6
     constructorThreshold: 7

2. After correcting (1), detekt complains about:

complexity - 2h debt
        ComplexMethod - 15/15 - [start] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/components/metrics/LeanplumMetricsService.kt:96:18
        LongMethod - 78/75 - [toEvent] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt:535:18
        LargeClass - 200/200 - [AwesomeBarView] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/search/awesomebar/AwesomeBarView.kt:36:7
        LargeClass - 226/200 - [ToolbarGestureHandler] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/browser/ToolbarGestureHandler.kt:38:7
        TooManyFunctions - 11/11 - [ToolbarGestureHandler] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/browser/ToolbarGestureHandler.kt:38:7
        ComplexCondition - 4/4 - [onSwipeStarted] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/browser/ToolbarGestureHandler.kt:80:13
style - 15min debt
        MaxLineLength - [onLoadRequest] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/AppRequestInterceptor.kt:31:17
        MayBeConst - [PREFERENCE_NAME] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/components/metrics/LeanplumMetricsService.kt:243:9
        MayBeConst - [DEVICE_ID_KEY] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/components/metrics/LeanplumMetricsService.kt:244:9

Will you accept a PR for these? Should the patch simply suppress the warnings for TooManyFunctions, LargeClass, LongMethod, ComplexCondition, and ComplexMethod?

┆Issue is synchronized with this Jira Task

[sysrqb]

Oh. After fixing (1) above on master, these are the detekt issues:

/home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarView.kt - 20min debt
        ComplexCondition - 4/4 - [performHapticIfNeeded] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarView.kt:254:13
/home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/components/metrics/LeanplumMetricsService.kt - 30min debt
        ComplexMethod - 15/15 - [start] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/components/metrics/LeanplumMetricsService.kt:96:18
        MayBeConst - [PREFERENCE_NAME] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/components/metrics/LeanplumMetricsService.kt:243:9
        MayBeConst - [DEVICE_ID_KEY] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/components/metrics/LeanplumMetricsService.kt:244:9
/home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/components/metrics/MetricController.kt - 20min debt
        LongMethod - 84/75 - [toEvent] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/components/metrics/MetricController.kt:143:22
/home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/browser/ToolbarGestureHandler.kt - 1h debt
        LargeClass - 226/200 - [ToolbarGestureHandler] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/browser/ToolbarGestureHandler.kt:38:7
        TooManyFunctions - 11/11 - [ToolbarGestureHandler] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/browser/ToolbarGestureHandler.kt:38:7
        ComplexCondition - 4/4 - [onSwipeStarted] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/browser/ToolbarGestureHandler.kt:80:13
/home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/AppRequestInterceptor.kt - 5min debt
        MaxLineLength - [onLoadRequest] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/AppRequestInterceptor.kt:31:17
/home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/tabhistory/TabHistoryViewHolder.kt - 5min debt
        MaxLineLength - [bind] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/tabhistory/TabHistoryViewHolder.kt:36:13
/home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/utils/FeatureFlagPreference.kt - 5min debt
        MaxLineLength - [featureFlagPreference] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/utils/FeatureFlagPreference.kt:11:1
/home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/browser/BrowserAnimator.kt - 10min debt
        MagicNumber - [<anonymous>] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/browser/BrowserAnimator.kt:45:27
/home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt - 10min debt
        MagicNumber - [showEngineView] at /home/androidstudio/fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt:589:91
/home/androidstudio/fenix/app/src/geckoRelease/java/org/mozilla/fenix/engine/GeckoProvider.kt - 10min debt
        ForbiddenComment - [runtimeSettings] at /home/androidstudio/fenix/app/src/geckoRelease/java/org/mozilla/fenix/engine/GeckoProvider.kt:53:13 

Overall debt: 2h 55min

[person808]

Good catch!

[person808]

Will you accept a PR for these? Should the patch simply suppress the warnings for TooManyFunctions, LargeClass, LongMethod, ComplexCondition, and ComplexMethod?

I'll take care of it! A lot of these are probably not avoidable so suppressing the warning is what I'll do

[person808]

Fixed!