In-app review prompt #13507
Comments
EDIT: out of date! Here are the specs: Acceptance criteria:
Other noteworthy guidelines:
|
Moving this back to sourpatch bc the search work is almost done! |
Just to be explicit, this does not require any strings, per the Android guidelines. We can only control when the prompt is shown, and we must not show it too often.
|
…wPromptController
…wPromptController
…wPromptController
This should be triggered on Nightly (but depends on Google Play Services) by doing the following:
We're not entirely clear on when Google Play chooses to show this, but those steps will set it up to be able to be shown (so if it doesn't happen exactly with those steps, please note it in the comments, but we don't actually have full control over this) If you want to trigger it again, it needs to be a fresh install because one of the restrictions is that GPS will not show the prompt too close together (by a few weeks). Link to Google API in comment 0 can provide more info on how it should look. |
I tested the issue on Firefox Preview Nightly 200831 (Build #2015761139) but was unable to trigger the In-App Review prompt. I tried the following scenario:
Are there any more steps that need to be completed in order for the In-App Review prompt to be shown? |
Did you set Firefox Nightly as default browser @LaurentiuApahideanSV ? Did not see that in your list of steps, but maybe it was done but not written down. Could you also try browsing a site for each of the 5 restarts? I was able to get this to show up on Nightly, but others had not been able to, so the unknown is probably related to where Google Play Services is controlling something. |
@boek if I'm cutting a new 80 Release with the crashfix from #14357 could we get this uplifted too? and there was a follow-up crash with lower API level devices, maybe @eliserichards you know what that is? Let me know if it's too risky at this point, just a few days into nightly. Would be worthwhile for someone to check the crashes too to see if there's anything google play services / ratings related. |
For mozilla-mobile#13507 - Extracts review prompt behavior into ReviewPromptController For mozilla-mobile#13507 - Adds tests for ReviewPromptController For mozilla-mobile#13507 - Performance fixes for the ReviewPromptController For mozilla-mobile#14318 - Use old API to try to fix startup crash without GPS
For #13507 - Extracts review prompt behavior into ReviewPromptController For #13507 - Adds tests for ReviewPromptController For #13507 - Performance fixes for the ReviewPromptController For #14318 - Use old API to try to fix startup crash without GPS Co-authored-by: Elise Richards <erichards@mozilla.com>
@liuche Neither of us could trigger the Gplay review prompt on Nightly 9/1 or 80.1.2 RC (this one because is not yet in the Gplay Store, maybe?) following the criteria mentioned:
|
Hmmm, this is very strange - I was only able to trigger this once on my Nightly build. The Google Play Services APIs are not clear on how exactly the prompt gets triggered. However, we will keep an eye out for new reviews possibly through here. This is a low-risk change and maybe it is just unpredictable how the GPS APIs are working. I'll leave this open for now though. Maybe someone who sees this prompt show up can comment. |
@liuche unfortunately we still didn't managed to trigger the In-app review prompt on Beta 81.1.0-beta.2. |
Can we close this issue? |
I think even though QA wasn't able to reproduce this, some on the eng team could, and we're seeing a bump in positive reviews! so this is something we can close. Maybe there are some Google Play settings that we are not aware of that is making this difficult to test, thank you for trying! |
Hi all!
|
User Story
Dependencies
Using the Google In-app review API since it will allow user to rate the app without having the leave the browser.
Acceptance Criteria
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: