Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] The copy button in Saved Logins is too small #13831

Closed
s-ankur opened this issue Aug 14, 2020 · 2 comments
Closed

[Bug] The copy button in Saved Logins is too small #13831

s-ankur opened this issue Aug 14, 2020 · 2 comments
Assignees
@mcarare
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Logins help wanted Help wanted from a contributor. More complex than good first issue.
Projects
Hershey's 🍫

Comments

@s-ankur
Copy link
Contributor

s-ankur commented Aug 14, 2020 •
edited by data-sync-user

Steps to reproduce

Go to login-> Saved Logins-> onen one login and try to click on the copy buttons

Expected behavior

The buttons are easy to click

Actual behavior

You have to be extremely precise to click on the button, even when your click overlaps the copy icon, the button is not pressed

Device information

  • Android device: Asus Zenfone
  • Fenix version: Nightly
    (You may need to change the display size in android setting to smallest to see this, but I can also see it on the normal size to a lesser degree)

┆Issue is synchronized with this Jira Task
@s-ankur s-ankur added the 🐞 bug Crashes, Something isn't working, .. label Aug 14, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Aug 14, 2020
@liuche liuche added access Accessibility: Talkback, HW keyboard/mouse, braile display etc. Feature:Logins and removed needs:triage Issue needs triage labels Aug 20, 2020
@liuche
Copy link
Contributor

liuche commented Aug 20, 2020

We should make the touch target larger in the Edit Logins screen.

I also noticed that there is no highlight when clicking the "copy" icon for the password, which we should also fix

@liuche liuche added this to Inbox in Engineering triage via automation Aug 20, 2020
@liuche liuche moved this from Inbox to Skittle Staging Backlog in Engineering triage Aug 20, 2020
@liuche liuche added the help wanted Help wanted from a contributor. More complex than good first issue. label Aug 28, 2020
@liuche liuche removed this from Skittle Staging Backlog in Engineering triage Sep 8, 2020
@mcarare mcarare self-assigned this Oct 9, 2020
@mcarare mcarare added this to In Progress in Hershey's 🍫 Oct 9, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Oct 9, 2020
@mcarare
For mozilla-mobile#13831: Add ripple for the copy password button.
1a5b9a3
mcarare added a commit to mcarare/fenix that referenced this issue Oct 9, 2020
@mcarare
For mozilla-mobile#13831: Adjust buttons dimensions to improve a11y.
4ebc0b6 
Margins were also adjusted to maintain relative placements.
@mcarare mcarare moved this from In Progress to In Dev Review in Hershey's 🍫 Oct 9, 2020
ekager pushed a commit that referenced this issue Oct 9, 2020
@mcarare @ekager
For #13831: Add ripple for the copy password button.
e89b975
ekager pushed a commit that referenced this issue Oct 9, 2020
@mcarare @ekager
For #13831: Adjust buttons dimensions to improve a11y.
6516eff 
Margins were also adjusted to maintain relative placements.
@ekager ekager added the eng:qa:needed QA Needed label Oct 9, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Oct 12, 2020

Hi, verified as fixed on the latest Nightly Build 201012 using a Google Pixel 3a (Android 10)
Scanned the Saved Logins section with the Accessibility Scanner app and the "Copy" buttons have the right size. ✔️

@AndiAJ AndiAJ closed this as completed Oct 12, 2020
Hershey's 🍫 automation moved this from In Dev Review to QA Review Oct 12, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Oct 12, 2020
@mcarare mcarare moved this from QA Review to Done Sprint 20.21 in Hershey's 🍫 Oct 12, 2020
@mcarare mcarare moved this from Done Sprint 20.21 to Done in Hershey's 🍫 Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Logins help wanted Help wanted from a contributor. More complex than good first issue.
Projects
No open projects
Hershey's 🍫
  
Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@liuche @ekager @s-ankur @mcarare @AndiAJ