Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Show Synced Tabs in a separate tab on the tabs tray #14117

Closed
1 task done
jonalmeida opened this issue Aug 24, 2020 · 8 comments
Closed
1 task done

Show Synced Tabs in a separate tab on the tabs tray #14117

jonalmeida opened this issue Aug 24, 2020 · 8 comments
Assignees
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified feature request 🌟 New functionality and improvements Feature:SyncTabs Sync tabs Feature:Tabs MR1 Issues that are needed for the MR1 2021 release.
Milestone

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Aug 24, 2020

What is the user problem or growth opportunity you want to see solved?

Scrolling through open tabs to reach your Synced Tabs can cause scrolling fatigue. It can be bothersome to also find the tab you are looking for in a rather large list.

How do you know that this problem exists today? Why is this important?

The Synced Tabs list is at the bottom of the normal tabs in the tabs tray.

Who will benefit from it?

  • Firefox Sync users.

Unsolved problems

  • (UX) Do we show a tab icon when the user is not signed into Sync?
    • For now, I'm going to stick with showing it always since we have existing UX on what the screen will look like.

Dependant issues:

UX designs and discussions

┆Issue is synchronized with this Jira Task

@jonalmeida jonalmeida added this to Backlog in A-C: Meta: Sync Tabs via automation Aug 24, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Aug 24, 2020
@liuche liuche removed the needs:triage Issue needs triage label Aug 25, 2020
@topotropic
Copy link

* (UX) Do we show a tab icon when the user is not signed into Sync?

@vesta0 that's your call, we could always show it to help people discover the feature easier and monitor usage data to inform future decissions; suggested design: https://share.goabstract.com/c6bd0c2f-8384-44f3-ba59-4946d8cea469?collectionLayerId=7f7dbd7e-f8ba-4a03-aecd-aeb989476bd0&mode=design

@liuche liuche added this to Inbox in Engineering triage via automation Sep 10, 2020
@liuche liuche moved this from Inbox to Skittle Staging Backlog in Engineering triage Sep 10, 2020
@liuche
Copy link
Contributor

liuche commented Sep 10, 2020

not sure why this issue isn't showing up in jira

@bifleming
Copy link

@jonalmeida @ekager @amedyne is this story still blocked by the refactor? (or am I thinking of a different one...) Is this one we could pick up now?

@jonalmeida jonalmeida added this to Triage in Tabs Tray via automation Feb 4, 2021
@jonalmeida jonalmeida added this to Triage in Tabs Tray Refactor via automation Feb 4, 2021
@jonalmeida jonalmeida removed this from Triage in Tabs Tray Feb 4, 2021
@amedyne amedyne added this to New Features/Functions (top 20) in Android Team Backlog Staging Board Feb 11, 2021
@jonalmeida jonalmeida moved this from Triage to Stories in Tabs Tray Refactor Feb 18, 2021
@jonalmeida jonalmeida added feature request 🌟 New functionality and improvements MR1 Issues that are needed for the MR1 2021 release. E5 Estimation Point: about 5 days labels Feb 18, 2021
@brampitoyo
Copy link

@jonalmeida I’ve moved our Synced Tabs design spec from Abstract to Figma. Along the way, I’ve put them side by side with iOS and iPadOS Synced Tabs mockups.

This way, you’ll able to see how our design is aligned across the board.

See comment 0 for Figma link update, or see https://www.figma.com/file/lfgj15zbNkL9Pp4hdZGJgp/Proton-Mobile-UI?node-id=101%3A3907

@amedyne amedyne removed this from New Features/Functions (top 20) in Android Team Backlog Staging Board Feb 24, 2021
@amedyne amedyne added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Feb 24, 2021
@mcarare
Copy link
Contributor

mcarare commented Feb 25, 2021

We should wait for #17821 work to be done and merged before working on this.

@jonalmeida
Copy link
Contributor Author

We should wait for #17821 work to be done and merged before working on this.

There are a couple of things we want to do including that ticket. I've put them on this board to make it easier to track.

@mcarare mcarare added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Feb 25, 2021
@jonalmeida jonalmeida moved this from Stories to In progress in Tabs Tray Refactor Mar 17, 2021
@jonalmeida jonalmeida self-assigned this Mar 17, 2021
@jonalmeida jonalmeida moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Mar 17, 2021
@jonalmeida jonalmeida moved this from In Development (WIP limit - 15) to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board Mar 31, 2021
@jonalmeida jonalmeida removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Mar 31, 2021
@jonalmeida
Copy link
Contributor Author

This is done behind a feature flag. I'll add the QA label when it's available to be tested.

@gabrielluong gabrielluong added this to the 89 milestone Apr 1, 2021
@jonalmeida jonalmeida moved this from In progress to Done in Tabs Tray Refactor Apr 2, 2021
@lobontiumira
Copy link

Verified on the 4/20 Nightly build with Google Pixel (Android 10), Samsung Galaxy Note 8 (Android 9), Xiaomi Mi 8 Lite (Android 9), OnePlus 5T (Android 10), and Samsung Galaxy Tab A6 (Android 5.1.1) that the synced tabs are displayed in a separate tab on the tabs tray.

synced tabs tray

A-C: Meta: Sync Tabs automation moved this from Backlog to Done Apr 20, 2021
Android Engineering Team Kanban board automation moved this from Reviewer approved, ready for test (WIP limit - ?) to Done Apr 20, 2021
@lobontiumira lobontiumira added the eng:qa:verified QA Verified label Apr 20, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified feature request 🌟 New functionality and improvements Feature:SyncTabs Sync tabs Feature:Tabs MR1 Issues that are needed for the MR1 2021 release.
Development

No branches or pull requests

8 participants