Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] opened_link telemetry is wrong: reports twice when it should report once on cold app link #14133

Closed
mcomella opened this issue Aug 24, 2020 · 3 comments
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Telemetry wontfix

Comments

@mcomella
Copy link
Contributor

mcomella commented Aug 24, 2020

Steps to reproduce

  • (ensure telemetry is enabled in your build)
  • Force-stop the app
  • Click a link in another app (I used gmail)
  • Send ping to glean debug view (adb shell am start -n org.mozilla.fenix.debug/mozilla.telemetry.glean.debug.GleanDebugActivity --es tagPings correctness --es sendPing events)
  • Check ping in debug view for results

Expected behavior

opened_link appears once

Actual behavior

opened_link appears twice

Device information

  • Android device: P2
  • Fenix version: master fd90afc

Note: the app_opened_all_startup captures app startup (i.e. app background to foreground) and includes if the link came from app_link. As a solution to this issue, assuming I understand the probe correctly, we could merge the NORMAL/PRIVATE state to the app_opened_all_startup probe to get the same results.

If you correct the existing probe, don't forget to:

┆Issue is synchronized with this Jira Task

@mcomella mcomella added the 🐞 bug Crashes, Something isn't working, .. label Aug 24, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Aug 24, 2020
@mcomella mcomella changed the title [Bug] opened_link telemetry is wrong: reports twice when it should report once [Bug] opened_link telemetry is wrong: reports twice when it should report once on cold app link Aug 24, 2020
@mcomella
Copy link
Contributor Author

I opened #14138 to update the docs with the info that this probe may be wrong.

@stale
Copy link

stale bot commented Feb 21, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 21, 2021
@stale stale bot closed this as completed Feb 28, 2021
@eliserichards eliserichards reopened this Jun 14, 2021
@stale stale bot removed the wontfix label Jun 14, 2021
@stale
Copy link

stale bot commented Dec 11, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 11, 2021
@stale stale bot closed this as completed Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Telemetry wontfix
Projects
None yet
Development

No branches or pull requests

3 participants