Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] [Translation] "Downloads" entries not translated into French on Beta and Nightly #14665

Closed
klint opened this issue Sep 3, 2020 · 6 comments
Closed

[Bug] [Translation] "Downloads" entries not translated into French on Beta and Nightly #14665

klint opened this issue Sep 3, 2020 · 6 comments
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. E1 Estimation Point: trivial, less than half day eng:qa:verified QA Verified 🌐 L10N Localization, translation, strings, .. needs:triage Issue needs triage
Projects
Hershey's 🍫

Comments

@klint
Copy link

klint commented Sep 3, 2020 •
edited by data-sync-user

Steps to reproduce

Set language to "French"
Open 3 dots menu from a web page or from the home page

Expected behavior

"Downloads" is translated by "Téléchargements"

Actual behavior

It is not translated

Device information

  • Android device: ?
  • Fenix version: 81 beta + nighlty

┆Issue is synchronized with this Jira Task
@klint klint added the 🐞 bug Crashes, Something isn't working, .. label Sep 3, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 3, 2020
@cadeyrn
Copy link
Contributor

cadeyrn commented Sep 3, 2020

Translations happen via https://pontoon.mozilla.org. If it's still in English then it's probably not yet translated by the translators. You can also suggest translations on Pontoon.

@klint
Copy link
Author

klint commented Sep 3, 2020

Thanks for the hint. Will check there! 😊

@klint
Copy link
Author

klint commented Sep 3, 2020

There are entries for "Downloads" in Pontoon and they are translated properly in French: https://pontoon.mozilla.org/fr/android-l10n/mozilla-mobile/fenix/app/src/main/res/values/strings.xml/?search=downloads&string=197484
By the way, I have checked with Italian, and it is not translated either.

@mcarare mcarare added the 🌐 L10N Localization, translation, strings, .. label Sep 3, 2020
@mcarare mcarare self-assigned this Sep 3, 2020
@mcarare
Copy link
Contributor

mcarare commented Sep 3, 2020

@klint Thank you fo the report, it turns out the menu name was hardcoded.

@mcarare mcarare added this to In Dev Review in Hershey's 🍫 Sep 3, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Sep 3, 2020
@mcarare
For mozilla-mobile#14665: Replace hardcoded label with string resource.
55d0551
ekager pushed a commit that referenced this issue Sep 3, 2020
@mcarare @ekager
For #14665: Replace hardcoded label with string resource.
85cb74a
@mcarare mcarare moved this from In Dev Review to QA Review in Hershey's 🍫 Sep 4, 2020
@mcarare mcarare added the eng:qa:needed QA Needed label Sep 4, 2020
@klint
Copy link
Author

klint commented Sep 4, 2020

I can confirm this has been corrected on my Redmi Note 7 with today's nightly. Thanks

@ebalazs-sv
Copy link

Verified as fixed on Nightly 200907 06:01 (Build #2015762483) GV 82.0a1 from 9/7 with Pixel 2 (Android 9), Nexus 5 (Android 6.0.1).

@ebalazs-sv ebalazs-sv added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 7, 2020
@mcarare mcarare moved this from QA Review to Done in Hershey's 🍫 Sep 7, 2020
@mcarare mcarare moved this from Done to Done Sprint 20.18 in Hershey's 🍫 Sep 10, 2020
@Mugurell Mugurell added the E1 Estimation Point: trivial, less than half day label Sep 10, 2020
@mcarare mcarare moved this from Done Sprint 20.19 to Done in Hershey's 🍫 Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. E1 Estimation Point: trivial, less than half day eng:qa:verified QA Verified 🌐 L10N Localization, translation, strings, .. needs:triage Issue needs triage
Projects
No open projects
Hershey's 🍫
  
Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@klint @cadeyrn @Mugurell @ebalazs-sv @mcarare