Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug][a11y] Touch target for the radio button search engine selection needs resizing #14725

Closed
Diana-Rus opened this issue Sep 4, 2020 · 3 comments
Assignees
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. E1 Estimation Point: trivial, less than half day eng:qa:verified QA Verified Feature:SearchProvider Feature:Settings S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@Diana-Rus
Copy link

Diana-Rus commented Sep 4, 2020

Prerequisites:

  • Have Google Accessibility Scanner installed.
  • Have a clean profile.

Steps to reproduce

  1. Open app and tap on "Menu"/"Settings"/"Search".
  2. Scan the "Search" module.

Expected behavior

No suggestions are made.

Actual behavior

Suggestion is to increase the item's size from 32dp x 32dp to 48dp x 48dp or larger.
Touch target
org.mozilla.fenix:id/radio_button
This item's size is 32dp x 32dp. Consider making this touch target 48dp wide and 48dp high or larger. A parent container may be handling touch events for this item. If selecting the larger container performs the same action as selecting this item, consider defining this item as not clickable. If a different action is performed, consider increasing the size of this item.

Device information

  • Android device: Google Pixel 3XL (Android 9)
  • Fenix version: Nightly 9/4
Screen

Screenshot_20200904-154533

┆Issue is synchronized with this Jira Task

@Diana-Rus Diana-Rus added 🐞 bug Crashes, Something isn't working, .. S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Sep 4, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 4, 2020
@Diana-Rus Diana-Rus added Feature:SearchProvider Feature:Settings access Accessibility: Talkback, HW keyboard/mouse, braile display etc. and removed needs:triage Issue needs triage labels Sep 4, 2020
@codrut-topliceanu
Copy link
Contributor

@Diana-Rus Indeed, the radio button is set to wrap_content but, the whole row is set to 48dp (height). Clicking on the row checks the radio button.
Should I still go ahead and make the requested changes anyway?

@Diana-Rus
Copy link
Author

Diana-Rus commented Sep 10, 2020

Hi @codrut-topliceanu , thanks for pointing it out, yes with talk back the entire row will activate a search engine, if it does not affect anything else, sure.

@codrut-topliceanu codrut-topliceanu self-assigned this Sep 10, 2020
@Mugurell Mugurell added the E1 Estimation Point: trivial, less than half day label Sep 10, 2020
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue Sep 11, 2020
@codrut-topliceanu codrut-topliceanu added this to In Dev Review in Hershey's 🍫 Sep 11, 2020
boek pushed a commit that referenced this issue Sep 11, 2020
@boek boek added the eng:qa:needed QA Needed label Sep 11, 2020
abhijitvalluri pushed a commit to abhijitvalluri/firefox2 that referenced this issue Sep 13, 2020
abhijitvalluri pushed a commit to fork-maintainers/iceraven-browser that referenced this issue Sep 13, 2020
abhijitvalluri added a commit to fork-maintainers/iceraven-browser that referenced this issue Sep 13, 2020
abhijitvalluri added a commit to fork-maintainers/iceraven-browser that referenced this issue Sep 13, 2020
@sflorean
Copy link
Contributor

Verified as fixed on Nightly 9/16 with Samsung Galaxy Note 10 (Android 10).

Hershey's 🍫 automation moved this from In Dev Review to QA Review Sep 16, 2020
@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 16, 2020
@mcarare mcarare moved this from QA Review to Done in Hershey's 🍫 Sep 18, 2020
@mcarare mcarare moved this from Done to Done Sprint 20.19 in Hershey's 🍫 Sep 24, 2020
@mcarare mcarare moved this from Done Sprint 20.19 to Done in Hershey's 🍫 Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. E1 Estimation Point: trivial, less than half day eng:qa:verified QA Verified Feature:SearchProvider Feature:Settings S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
No open projects
Development

No branches or pull requests

5 participants