Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Re-evaluate camera permissions when settings are changed #14998

Closed
eliserichards opened this issue Sep 11, 2020 · 2 comments
Closed

[Bug] Re-evaluate camera permissions when settings are changed #14998

eliserichards opened this issue Sep 11, 2020 · 2 comments
Assignees
@eliserichards
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified

Comments

@eliserichards
Copy link
Contributor

eliserichards commented Sep 11, 2020 •
edited by data-sync-user
Loading

Follow up to #14239

Steps to reproduce

When permission is denied and the prompt appears, go to Settings to change the Camera permission.
Switch Camera permission on.
Return to Fenix and tap the Search Scan again.

Expected behavior

The notification is not displayed, the QR code scan is launched.

Actual behavior

The notification still appears after allowing Camera permission.

Device information

  • Android device: ?
  • Fenix version: ?

┆Issue is synchronized with this Jira Task
@eliserichards eliserichards added the 🐞 bug Crashes, Something isn't working, .. label Sep 11, 2020
@eliserichards eliserichards self-assigned this Sep 11, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 11, 2020
@eliserichards eliserichards added sourpatch and removed needs:triage Issue needs triage labels Sep 11, 2020
@sv-ohorvath sv-ohorvath mentioned this issue Sep 14, 2020
Closed
@eliserichards eliserichards mentioned this issue Sep 14, 2020
Merged
9 tasks
@eliserichards eliserichards added the eng:qa:needed QA Needed label Sep 17, 2020
@eliserichards
Copy link
Contributor Author

For QA: see #15097 description for test cases 😄

@interfect interfect mentioned this issue Sep 18, 2020
Closed
interfect added a commit to fork-maintainers/iceraven-browser that referenced this issue Sep 18, 2020
@interfect
Revert "For mozilla-mobile#14239: Notification for QR scan when permi…
71d953e 
…ssions have been denied (mozilla-mobile#14553)"

This reverts commit 87bd441.

This should fix #125

This will need to itself be reverted when
mozilla-mobile#14998 is fixed.
@sv-ohorvath
Copy link
Contributor

Verified as fixed on Nightly 9/18.
Devices: Pixel 4(android 10), HTC Desire 820 (android 6.0.1), Huawei P20 lite (android 9), Nexus 5 (android 5.1)

@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eliserichards eliserichards

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sv-ohorvath @eliserichards