Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] ETP pop-up can appear when toolbar is scrolled off-screen #15402

Closed
mcomella opened this issue Sep 24, 2020 · 3 comments
Closed

[Bug] ETP pop-up can appear when toolbar is scrolled off-screen #15402

mcomella opened this issue Sep 24, 2020 · 3 comments
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR Feature:Toolbar Address bar, see also Feature:Search Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! help wanted Help wanted from a contributor. More complex than good first issue.

Comments

@mcomella
Copy link
Contributor

mcomella commented Sep 24, 2020 •
edited by data-sync-user

Steps to reproduce

  • Clear data
  • Click URL bar
  • Load a site with trackers (e.g. kotaku.com)
  • Scroll down

Expected behavior

ETP pop-up points to ETP shield in toolbar.

Actual behavior

Toolbar is offscreen so ETP pop-up points at nothing. We seem to wait for the page to completely load before showing the pop-up so I'd guess this happens to users pretty often who are probably scrolling before the page finishes loading.

image

Device information

  • Android device: P2
  • Fenix version: Nightly 200924

┆Issue is synchronized with this Jira Task
@mcomella mcomella added the 🐞 bug Crashes, Something isn't working, .. label Sep 24, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 24, 2020
@ekager ekager added eng:ready Ready for engineering Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR Feature:Toolbar Address bar, see also Feature:Search help wanted Help wanted from a contributor. More complex than good first issue. and removed needs:triage Issue needs triage labels Sep 24, 2020
@s-ankur
Copy link
Contributor

s-ankur commented Sep 25, 2020

Duplicate of #14012, probably that can be closed

@mcomella mcomella mentioned this issue Sep 28, 2020
Closed
@mcomella
Copy link
Contributor Author

Thanks – I closed the other issue.

@ekager ekager added the Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! label Sep 28, 2020
sijanr added a commit to sijanr/fenix that referenced this issue Oct 4, 2020
@sijanr
For mozilla-mobile#15402: Hide ETP pop-up if the toolbar is not visible
5b46267
sijanr added a commit to sijanr/fenix that referenced this issue Oct 5, 2020
@sijanr
For mozilla-mobile#15402: Hide ETP pop-up when top or bottom toolbar …
19373c8 
…is not visible
sijanr added a commit to sijanr/fenix that referenced this issue Oct 6, 2020
@sijanr
For mozilla-mobile#15402: Improve toolbar's position check
6146be4
sijanr added a commit to sijanr/fenix that referenced this issue Oct 8, 2020
@sijanr
For mozilla-mobile#15402: Use safe cast
b4d5975
sijanr added a commit to sijanr/fenix that referenced this issue Oct 9, 2020
@sijanr
For mozilla-mobile#15402: Fix ktlint fails
c6d5108
bors bot pushed a commit that referenced this issue Oct 9, 2020
@MozLando @sijanr
Merge #15667
9c74def 
15667: For #15402: Hide ETP pop-up if the toolbar is not visible r=Mugurell a=sijanr


![ETP](https://user-images.githubusercontent.com/47872289/95005944-269c6280-05b3-11eb-870e-4bd2ef90bf79.gif)

### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features. In addition, it includes a screenshot of a successful [accessibility scan](https://play.google.com/store/apps/details?id=com.google.android.apps.accessibility.auditor&hl=en_US) to ensure no new defects are added to the product.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture


Co-authored-by: sijanr <sijan1.rijal@gmail.com>
Mugurell pushed a commit that referenced this issue Oct 9, 2020
@sijanr
For #15402: Hide ETP pop-up if the toolbar is not visible (#15667)
127d006 
For #15402: Hide ETP pop-up when top or bottom toolbar is not visible
@Mugurell Mugurell added the eng:qa:needed QA Needed label Oct 9, 2020
@ebalazs-sv
Copy link

Verified as fixed on Nightly 201015 (Build #2015769771) GV 83.0a1 from 10/15 with Pixel 2 (Android 9).
I will remove the qa:needed label and close this issue.

@ebalazs-sv ebalazs-sv added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR Feature:Toolbar Address bar, see also Feature:Search Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! help wanted Help wanted from a contributor. More complex than good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mcomella @Mugurell @ekager @s-ankur @ebalazs-sv