Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Address bar completion is stuck after pressing enter #15464

Closed
w3Abhishek opened this issue Sep 26, 2020 · 21 comments
Closed

[Bug] Address bar completion is stuck after pressing enter #15464

w3Abhishek opened this issue Sep 26, 2020 · 21 comments
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Search Feature:Toolbar Address bar, see also Feature:Search needs:investigation wontfix

Comments

@w3Abhishek
Copy link

w3Abhishek commented Sep 26, 2020

Steps to reproduce

  • Enter URL or search term in the address bar
  • Tap Enter in on-screen keyboard

Expected behavior

Completion section should disappear after clicking enter

Actual behavior

Sometimes closes and sometimes sticks
Ref: https://youtu.be/OR7516clqj4

Device information

  • Android device: Realme 5
  • Fenix version: Nightly 200926 06:03

┆Issue is synchronized with this Jira Task

@w3Abhishek w3Abhishek added the 🐞 bug Crashes, Something isn't working, .. label Sep 26, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 26, 2020
@Shamp0o
Copy link

Shamp0o commented Oct 12, 2020

Same behavior here on Xiaomi Redmi Note 5 running LineageOS 17.1. Fenix version: 82.0.0-beta.4

@liuche liuche added Feature:Search Feature:Toolbar Address bar, see also Feature:Search and removed needs:triage Issue needs triage labels Oct 15, 2020
@eliserichards
Copy link
Contributor

Same behavior reported here with some additional details: https://www.reddit.com/r/firefox/comments/jiwqal/this_panel_doesnt_go_away_whenever_i_search_by/

@eliserichards eliserichards added this to Inbox in Engineering triage via automation Oct 27, 2020
@eliserichards eliserichards moved this from Inbox to Skittle Staging Backlog in Engineering triage Oct 27, 2020
@mcarare mcarare self-assigned this Dec 22, 2020
@giwrgosmant
Copy link

Same behavior on POCO F1 running Pixel Experience Plus Android 10. Firefox Stable Version: 84.1.2 (Build #2015783137)
Really annoying, I had to go back on Chromium base browser because of this.😕 I hope for a fix soon 🤞

@SPLESHER1
Copy link

Same behavior on POCO F1. Firefox Stable Version: 84.1.2 (Build #2015783137)

@sflorean
Copy link
Contributor

sflorean commented Jan 8, 2021

I wasn't able to reproduce the issue on latest Nightly build with Pixel 3 (Android 11). @giwrgosmant @SPLESHER1 could you check this on Nightly? on stable version will still be reproducible until the bug is landed on release.

@sflorean sflorean removed the eng:qa:needed QA Needed label Jan 8, 2021
@giwrgosmant
Copy link

I wasn't able to reproduce the issue on latest Nightly build with Pixel 3 (Android 11). @giwrgosmant @SPLESHER1 could you check this on Nightly? on stable version will still be reproducible until the bug is landed on release.

Hello,

I've just tested it and it persists. Tested with Nightly from Play Store and Firefox Beta 85.0.0-beta.6 from Github.
POCO F1 running Android 10 Pixel Experience Plus.

@mcarare
Copy link
Contributor

mcarare commented Jan 8, 2021

Hello,

I've just tested it and it persists. Tested with Nightly from Play Store and Firefox Beta 85.0.0-beta.6 from Github.
POCO F1 running Android 10 Pixel Experience Plus.

@giwrgosmant Nightly 210107?

@giwrgosmant
Copy link

giwrgosmant commented Jan 8, 2021

Hello,
I've just tested it and it persists. Tested with Nightly from Play Store and Firefox Beta 85.0.0-beta.6 from Github.
POCO F1 running Android 10 Pixel Experience Plus.

@giwrgosmant Nightly 210107?

Seems the nightly version wasn't 210107 at time I tried it. Now I've tried with 210107, all seems fine atm.
I will let you know if I encounter the issue again. Thanks!
EDIT: After I send this post I encounter it again 😕

@mcarare
Copy link
Contributor

mcarare commented Jan 8, 2021

I cannot reproduce this (even before the fix) on Nightly or Beta. Also used a Xiaomi Redmi Note 8 Pro, the nearest I have to the reported devices( I do not have a custom OS tough).

@giwrgosmant
Copy link

giwrgosmant commented Jan 8, 2021

I cannot reproduce this (even before the fix) on Nightly or Beta. Also used a Xiaomi Redmi Note 8 Pro, the nearest I have to the reported devices( I do not have a custom OS tough).

I've recorded a video reproducing that on 210108 Nightly. Check here [link removed]

@mcarare
Copy link
Contributor

mcarare commented Jan 18, 2021

@giwrgosmant Do you have gesture navigation enabled and/or customized on your device? Does the issue still occurs when you switch back to 3-button or 2-button navigation?

@giwrgosmant
Copy link

@giwrgosmant Do you have gesture navigation enabled and/or customized on your device? Does the issue still occurs when you switch back to 3-button or 2-button navigation?

Yeah I have gesture navigation enabled.
I tried with 3-button and 2-button navigation and the problem seems solved, I switched back to gesture navigation and issue came back. So the problem is with gesture navigation 🤔

@mcarare
Copy link
Contributor

mcarare commented Jan 18, 2021

@giwrgosmant Yes, but I think the problem occurs only with a custom OS that implements its own gesture navigation or when using a custom launcher (with a custom gesture navigation as well).
On standard gesture navigation, I am unable to reproduce this.

@giwrgosmant
Copy link

giwrgosmant commented Jan 19, 2021

@giwrgosmant Yes, but I think the problem occurs only with a custom OS that implements its own gesture navigation or when using a custom launcher (with a custom gesture navigation as well).
On standard gesture navigation, I am unable to reproduce this.

They use the standard Android 10 navigation. There is an option to hide navigation bar pill which I have enabled. I noticed (at least the time I've testing it) if I turned it off I don't have these bar freezes. I don't know if it's related.
Screenshot_20210119-063442320.jpg

@mcarare mcarare removed their assignment Feb 4, 2021
@giwrgosmant
Copy link

@mcarare I am on Android 11 Pixel Experience now with Navigation bar pill always on and I don't face this issue anymore.
It seems to be related with navigation bar pill which I hide in options back in Android 10 version, but I still don't understand why this affect Firefox at all.

@mcarare
Copy link
Contributor

mcarare commented Feb 9, 2021

@giwrgosmant I have tested this in standard Android 10 with different devices and using gesture navigation does not break this feature in Fenix, so I am unable to see what custom OS's change in gestures that interferes with dismissing the dialog fragment.

@mcarare
Copy link
Contributor

mcarare commented Feb 24, 2021

Another report, with

My phone is Sony Xperia H3123 running Lineage OS 17.1 (Android 10)

@GottfriedCP
Copy link

Another report, with

My phone is Sony Xperia H3123 running Lineage OS 17.1 (Android 10)

@giwrgosmant your suggestion seems to solve my problem

@giwrgosmant
Copy link

Another report, with

My phone is Sony Xperia H3123 running Lineage OS 17.1 (Android 10)

@giwrgosmant your suggestion seems to solve my problem

You mean the navigation pill always on?

pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
@stale
Copy link

stale bot commented Aug 23, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 23, 2021
@mariansima
Copy link

Could not reproduce this issue on Samsung A8 SM-A530F Android 9 Firefox 93.0a1 2021-08-29

@stale stale bot closed this as completed Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Search Feature:Toolbar Address bar, see also Feature:Search needs:investigation wontfix
Projects
Engineering triage
  
Skittle Staging Backlog
Development

No branches or pull requests