Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Fenix uses non-public resource APIs; could result in inconsistent app behavior or bugs in future versions #15640

Closed
mcomella opened this issue Oct 2, 2020 · 0 comments
Closed

[Bug] Fenix uses non-public resource APIs; could result in inconsistent app behavior or bugs in future versions #15640

mcomella opened this issue Oct 2, 2020 · 0 comments
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. eng:build Build system, gradle, configuration eng:health Improve code health eng:qa:not-needed Added by QA to issues that cannot be tested

Comments

@mcomella
Copy link
Contributor

mcomella commented Oct 2, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

  • Run Android Lint: ./gradlew lintDebug
  • See PrivateResource WARNING in results

Expected behavior

None shown

Actual behavior

Some shown.

Android Lint explains:

Private resources should not be referenced; the may not be present everywhere, and even where they are they may disappear without notice.

To fix this, copy the resource into your own project instead.

Device information

  • Android device: ?
  • Fenix version: master-ish a173749

When we fix this, we should also change the severity of this check to ERROR from WARNING so it doesn't happen again.

┆Issue is synchronized with this Jira Task
@mcomella mcomella added the 🐞 bug Crashes, Something isn't working, .. label Oct 2, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 2, 2020
@kbrosnan kbrosnan added eng:build Build system, gradle, configuration eng:health Improve code health and removed needs:triage Issue needs triage labels Oct 5, 2020
@mcarare mcarare self-assigned this Dec 4, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Dec 4, 2020
@mcarare
For mozilla-mobile#15640: Increase PrivateResource warning severity t…
a27226f 
…o error.
mcarare added a commit to mcarare/fenix that referenced this issue Dec 4, 2020
@mcarare
For mozilla-mobile#15640: Remove private resources from TextPercentag…
7b37890 
…eSeekBarPref.
mcarare added a commit to mcarare/fenix that referenced this issue Dec 4, 2020
@mcarare
For mozilla-mobile#15640: Remove private resources from RadioButtonPr…
f6b956f 
…eference.
mcarare added a commit to mcarare/fenix that referenced this issue Dec 4, 2020
@mcarare
For mozilla-mobile#15640: Remove private resources from RadioButtonPr…
1f2ba13 
…eference.
mcarare added a commit to mcarare/fenix that referenced this issue Dec 4, 2020
@mcarare
For mozilla-mobile#15640: Remove private resources from RadioButtonPr…
64857c8 
…eference.
mcarare added a commit that referenced this issue Dec 9, 2020
@mcarare
For #15640: Increase PrivateResource warning severity to error.
0a6808d
mcarare added a commit that referenced this issue Dec 9, 2020
@mcarare
For #15640: Remove private resources from TextPercentageSeekBarPref.
fa08afb
mcarare added a commit that referenced this issue Dec 9, 2020
@mcarare
For #15640: Remove private resources from RadioButtonPreference.
b4a81c2
@mcarare mcarare added the eng:qa:not-needed Added by QA to issues that cannot be tested label Dec 9, 2020
@mcarare mcarare closed this as completed Dec 9, 2020
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
@mcarare @pkirakosyan
For mozilla-mobile#15640: Increase PrivateResource warning severity t…
1f2ca8d 
…o error.
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
@mcarare @pkirakosyan
For mozilla-mobile#15640: Remove private resources from TextPercentag…
1428d94 
…eSeekBarPref.
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
@mcarare @pkirakosyan
For mozilla-mobile#15640: Remove private resources from RadioButtonPr…
9709c3b 
…eference.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. eng:build Build system, gradle, configuration eng:health Improve code health eng:qa:not-needed Added by QA to issues that cannot be tested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kbrosnan @mcomella @mcarare