Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Write tests for start up defense static analysis #15707

Closed
mcomella opened this issue Oct 5, 2020 · 4 comments
Closed

Write tests for start up defense static analysis #15707

mcomella opened this issue Oct 5, 2020 · 4 comments
Assignees
@mcomella
Labels
eng:qa:not-needed Added by QA to issues that cannot be tested performance Possible performance wins
Projects
Performance, front-end roadmap

Comments

@mcomella
Copy link
Contributor

mcomella commented Oct 5, 2020 •
edited by data-sync-user

afaik, we're adding three static analysis checks without tests:

We should write tests for them so they don't accidentally regress, considering how important they are to our start up defense strategy.

┆Issue is synchronized with this Jira Task
@mcomella mcomella added the performance Possible performance wins label Oct 5, 2020
@mcomella mcomella added this to Needs prioritization in Performance, front-end roadmap via automation Oct 5, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 5, 2020
@MarcLeclair MarcLeclair moved this from Needs prioritization to Backlog (prioritized) in Performance, front-end roadmap Oct 7, 2020
@liuche liuche removed the needs:triage Issue needs triage label Oct 20, 2020
@mcomella mcomella self-assigned this Oct 21, 2020
@mcomella mcomella moved this from Backlog (prioritized) to In progress in Performance, front-end roadmap Oct 21, 2020
mcomella added a commit to mcomella/fenix that referenced this issue Oct 21, 2020
@mcomella
For mozilla-mobile#15707: remove super.visitElement for ConstraintLay…
09ecea9 
…out lint.

It caused a test to fail because super.visitElement asserted false
because it expected to be overriden. It was correctly overridden - we
were just still calling through to super anyway.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 21, 2020
@mcomella
For mozilla-mobile#15707: add ConstraintLayoutPerfDetectorTest.
b65c66f 
I had to ignore one of the tests because the linter test API seemed to
be broken. All of these APIs are beta so I didn't think it was worth
trying to force it to work.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 21, 2020
@mcomella
For mozilla-mobile#15707: add mozilla-lint-rules:test to pre-push hook.
f96eb1d
mcomella added a commit to mcomella/fenix that referenced this issue Oct 21, 2020
@mcomella
For mozilla-mobile#15707: run mozilla-lint-rules:test in CI.
887cd9e
mcomella added a commit to mcomella/fenix that referenced this issue Oct 21, 2020
@mcomella
For mozilla-mobile#15707: add ConstraintLayoutPerfDetectorTest to cod…
41b9852 
…e owners.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 21, 2020
@mcomella
For mozilla-mobile#15707: clean up mozilla-lint-rules dependencies.
3eb7410
mcomella added a commit to mcomella/fenix that referenced this issue Oct 21, 2020
@mcomella
For mozilla-mobile#15707: correct dependencies in mozilla-detekt-rules.
7af0cb9 
Apparently these tests haven't been running because they don't compile.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 21, 2020
@mcomella
For mozilla-mobile#15707: add MozillaStrictModeSuppressionTest.
d0fbc0e
mcomella added a commit to mcomella/fenix that referenced this issue Oct 21, 2020
@mcomella
For mozilla-mobile#15707: correctly configure JUnit for mozilla-detek…
3671d48 
…t-rules.

Without this, the tests would not run from the command line though they
could run in Android Studio.
@mcomella
Copy link
Contributor Author

I'm adding code to make the tests run in CI (they haven't been) and opened a PR to test that the CI changes work: #16098 (by failing the tests).

mcomella added a commit to mcomella/fenix that referenced this issue Oct 21, 2020
@mcomella
For mozilla-mobile#15707: clean up lint rules dependencies.
a9bfd10 
For mozilla-detekt-rules, the tests didn't compile at all so apparently
they haven't been running in testing.

mozilla-lint-rules worked but they were not clean.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 21, 2020
@mcomella
For mozilla-mobile#15707: remove super.visitElement for ConstraintLay…
a708d26 
…out lint.

It caused a test to fail because super.visitElement asserted false
because it expected to be overriden. It was correctly overridden - we
were just still calling through to super anyway.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 21, 2020
@mcomella
For mozilla-mobile#15707: add ConstraintLayoutPerfDetectorTest.
4bedc5d 
I had to ignore one of the tests because the linter test API seemed to
be broken. All of these APIs are beta so I didn't think it was worth
trying to force it to work.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 21, 2020
@mcomella
For mozilla-mobile#15707: add ConstraintLayoutPerfDetectorTest to cod…
b12bd46 
…e owners.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 21, 2020
@mcomella
For mozilla-mobile#15707: correctly configure JUnit for mozilla-detek…
fbd6af4 
…t-rules.

Without this, the tests would not run from the command line though they
could run in Android Studio.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 21, 2020
@mcomella
For mozilla-mobile#15707: add MozillaStrictModeSuppressionTest.
a6d961c
mcomella added a commit to mcomella/fenix that referenced this issue Oct 21, 2020
@mcomella
For mozilla-mobile#15707: add lint rules tests to pre-push hook.
a7270d4
mcomella added a commit to mcomella/fenix that referenced this issue Oct 21, 2020
@mcomella
For mozilla-mobile#15707: run lint rules tests in CI.
544afd4 
This works but it's imperfect: when the tests fail, it links to the lint
failure artifacts rather than the test failure artifacts.
@mcomella
Copy link
Contributor Author

Opened a PR: #16101

mcomella added a commit to mcomella/fenix that referenced this issue Oct 21, 2020
@mcomella
For mozilla-mobile#15707: clean up lint rules dependencies.
7f94323 
For mozilla-detekt-rules, the tests didn't compile at all so apparently
they haven't been running in testing.

mozilla-lint-rules worked but they were not clean.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 21, 2020
@mcomella
For mozilla-mobile#15707: remove super.visitElement for ConstraintLay…
494afeb 
…out lint.

It caused a test to fail because super.visitElement asserted false
because it expected to be overriden. It was correctly overridden - we
were just still calling through to super anyway.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 21, 2020
@mcomella
For mozilla-mobile#15707: add ConstraintLayoutPerfDetectorTest.
bb6f9b5 
I had to ignore one of the tests because the linter test API seemed to
be broken. All of these APIs are beta so I didn't think it was worth
trying to force it to work.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 21, 2020
@mcomella
For mozilla-mobile#15707: add ConstraintLayoutPerfDetectorTest to cod…
a5f3ad2 
…e owners.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 28, 2020
@mcomella
For mozilla-mobile#15707: remove super.visitElement for ConstraintLay…
fbe142e 
…out lint.

It caused a test to fail because super.visitElement asserted false
because it expected to be overriden. It was correctly overridden - we
were just still calling through to super anyway.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 28, 2020
@mcomella
For mozilla-mobile#15707: add ConstraintLayoutPerfDetectorTest.
f27ae74 
I had to ignore one of the tests because the linter test API seemed to
be broken. All of these APIs are beta so I didn't think it was worth
trying to force it to work.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 28, 2020
@mcomella
For mozilla-mobile#15707: add ConstraintLayoutPerfDetectorTest to cod…
5a1b59f 
…e owners.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 28, 2020
@mcomella
For mozilla-mobile#15707: correctly configure JUnit for mozilla-detek…
ec6c32a 
…t-rules.

Without this, the tests would not run from the command line though they
could run in Android Studio.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 28, 2020
@mcomella
For mozilla-mobile#15707: add MozillaStrictModeSuppressionTest.
d58bc9a
mcomella added a commit to mcomella/fenix that referenced this issue Oct 28, 2020
@mcomella
For mozilla-mobile#15707: add lint rules tests to pre-push hook.
23005e7
mcomella added a commit to mcomella/fenix that referenced this issue Oct 28, 2020
@mcomella
For mozilla-mobile#15707: run lint rules tests in CI.
f2b0023 
This works but it's imperfect: when the tests fail, it links to the lint
failure artifacts rather than the test failure artifacts.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 28, 2020
@mcomella
For mozilla-mobile#15707 - post: add lint test dependencies to androi…
3f2e3a6 
…d-gradle-dependencies script.

`assemble` doesn't assemble the tests so we need to run `test`.
`testClasses` isn't good enough because, according to `--profile`, it
doesn't include dependencies for `testRuntimeClasspath`.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 31, 2020
@mcomella
For mozilla-mobile#15707: clean up lint rules dependencies.
84f219e 
For mozilla-detekt-rules, the tests didn't compile at all so apparently
they haven't been running in testing.

mozilla-lint-rules worked but they were not clean.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 31, 2020
@mcomella
For mozilla-mobile#15707: remove super.visitElement for ConstraintLay…
95d2e01 
…out lint.

It caused a test to fail because super.visitElement asserted false
because it expected to be overriden. It was correctly overridden - we
were just still calling through to super anyway.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 31, 2020
@mcomella
For mozilla-mobile#15707: add ConstraintLayoutPerfDetectorTest.
a70b992 
I had to ignore one of the tests because the linter test API seemed to
be broken. All of these APIs are beta so I didn't think it was worth
trying to force it to work.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 31, 2020
@mcomella
For mozilla-mobile#15707: add ConstraintLayoutPerfDetectorTest to cod…
afcffb8 
…e owners.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 31, 2020
@mcomella
For mozilla-mobile#15707: correctly configure JUnit for mozilla-detek…
01f8070 
…t-rules.

Without this, the tests would not run from the command line though they
could run in Android Studio.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 31, 2020
@mcomella
For mozilla-mobile#15707: add MozillaStrictModeSuppressionTest.
88eb2dd
mcomella added a commit to mcomella/fenix that referenced this issue Oct 31, 2020
@mcomella
For mozilla-mobile#15707: add lint rules tests to pre-push hook.
dc7b266
mcomella added a commit to mcomella/fenix that referenced this issue Oct 31, 2020
@mcomella
For mozilla-mobile#15707: run lint rules tests in CI.
483ce9f 
This works but it's imperfect: when the tests fail, it links to the lint
failure artifacts rather than the test failure artifacts.
mcomella added a commit to mcomella/fenix that referenced this issue Oct 31, 2020
@mcomella
For mozilla-mobile#15707 - post: add lint test dependencies to androi…
3c943f2 
…d-gradle-dependencies script.

`assemble` doesn't assemble the tests so we need to run `test`.
`testClasses` isn't good enough because, according to `--profile`, it
doesn't include dependencies for `testRuntimeClasspath`.
mcomella added a commit that referenced this issue Oct 31, 2020
@mcomella
For #15707: clean up lint rules dependencies.
0a63362 
For mozilla-detekt-rules, the tests didn't compile at all so apparently
they haven't been running in testing.

mozilla-lint-rules worked but they were not clean.
mcomella added a commit that referenced this issue Oct 31, 2020
@mcomella
For #15707: remove super.visitElement for ConstraintLayout lint.
4b94215 
It caused a test to fail because super.visitElement asserted false
because it expected to be overriden. It was correctly overridden - we
were just still calling through to super anyway.
mcomella added a commit that referenced this issue Oct 31, 2020
@mcomella
For #15707: add ConstraintLayoutPerfDetectorTest.
5ba5ab9 
I had to ignore one of the tests because the linter test API seemed to
be broken. All of these APIs are beta so I didn't think it was worth
trying to force it to work.
mcomella added a commit that referenced this issue Oct 31, 2020
@mcomella
For #15707: add ConstraintLayoutPerfDetectorTest to code owners.
25d3ea6
mcomella added a commit that referenced this issue Oct 31, 2020
@mcomella
For #15707: correctly configure JUnit for mozilla-detekt-rules.
12e856c 
Without this, the tests would not run from the command line though they
could run in Android Studio.
mcomella added a commit that referenced this issue Oct 31, 2020
@mcomella
For #15707: add MozillaStrictModeSuppressionTest.
6a635c4
mcomella added a commit that referenced this issue Oct 31, 2020
@mcomella
For #15707: add lint rules tests to pre-push hook.
e246854
mcomella added a commit that referenced this issue Oct 31, 2020
@mcomella
For #15707: run lint rules tests in CI.
087f9b9 
This works but it's imperfect: when the tests fail, it links to the lint
failure artifacts rather than the test failure artifacts.
mcomella added a commit that referenced this issue Oct 31, 2020
@mcomella
For #15707 - post: add lint test dependencies to android-gradle-depen…
8cb4618 
…dencies script.

`assemble` doesn't assemble the tests so we need to run `test`.
`testClasses` isn't good enough because, according to `--profile`, it
doesn't include dependencies for `testRuntimeClasspath`.
@mcomella
Copy link
Contributor Author

Addressed in #16101

Performance, front-end roadmap automation moved this from In progress to Done Oct 31, 2020
@mcomella mcomella added the eng:qa:not-needed Added by QA to issues that cannot be tested label Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcomella mcomella

Labels
eng:qa:not-needed Added by QA to issues that cannot be tested performance Possible performance wins
Projects
Performance, front-end roadmap
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcomella @liuche