Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Grid View] Fix the margins for the tabs in the grid view #15757

Closed
gabrielluong opened this issue Oct 7, 2020 · 3 comments
Closed

[Grid View] Fix the margins for the tabs in the grid view #15757

gabrielluong opened this issue Oct 7, 2020 · 3 comments
Assignees
@Mugurell
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:Tabs

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Oct 7, 2020 •
edited by data-sync-user

margin-start and margin-end should be 16dp instead of the current 8dp for the tabs in the grid view. https://www.figma.com/file/luMaQYjwiMtQM5xQ30P9yP/Tabs?node-id=2%3A0

I think we need to add a margin-start/end for the RecyclerView instead of the tab items because otherwise we would have a 32dp gap between the tabs. It gets a bit more complicated because the parent RecyclerView is shared between the list and grid view.

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong added this to Inbox in Engineering triage via automation Oct 7, 2020
@gabrielluong gabrielluong moved this from Inbox to Grid View in Engineering triage Oct 7, 2020
@gabrielluong gabrielluong added the E3 Estimation Point: average, 2 - 3 days label Oct 7, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 7, 2020
@gabrielluong gabrielluong added Skittle and removed needs:triage Issue needs triage labels Oct 7, 2020
@gabrielluong gabrielluong changed the title Fix the margins for the tabs in the grid view [Grid View] Fix the margins for the tabs in the grid view Oct 9, 2020
@gabrielluong
Copy link
Member Author

Spoke to @Mugurell about #13427 and #15756, where we are both looking into a new solution for displaying the selected border. Since we might both might be touching the layout, we should probably wait a bit from the investigation of both issues.

@gabrielluong gabrielluong added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Oct 14, 2020
@gabrielluong
Copy link
Member Author

I think @Mugurell has a likely fix for this already.

@gabrielluong gabrielluong removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Oct 15, 2020
gabrielluong pushed a commit that referenced this issue Oct 30, 2020
@Mugurell @gabrielluong
For #15757 - Avoid the double spacing issues for grid items in tabs tray
83bd80c 
Items should have a 16dp all around padding.
Have them have a 8dp padding that will add to 16 when placed together.
Have the parent have another 8dp that will add to 16 for when items are placed
to the edge of the available screen.
@gabrielluong gabrielluong added the eng:qa:needed QA Needed label Oct 30, 2020
@ebalazs-sv
Copy link

Verified as fixed on Nightly 201103 05:01 (Build #2015773417) GV 84 from 11/3 with

  • Motorola Moto G6 (Android 8);
  • Pixel 2 (Android 9);
  • Samsung Galaxy Tab S3 (Android 8),

and when the tabs tray is in grid view, the space between the opened tabs is the same.
Tested this in normal and private browsing, light and dark theme, portrait and landscape mode.

I will remove the qa:needed label and close this issue.

@ebalazs-sv ebalazs-sv added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Nov 3, 2020
@gabrielluong gabrielluong removed this from Grid View in Engineering triage Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:Tabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gabrielluong @Mugurell @ebalazs-sv