This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Address Nested ConstraintLayouts in search & tabs tray experiences #15788
Labels
Comments
mcomella
added this to Needs prioritization
in Performance, front-end roadmap
via automation
Oct 8, 2020
mcomella
moved this from Needs prioritization
to Top 10 Inter-Team bugs
in Performance, front-end roadmap
Oct 28, 2020
Two screens involved. Can also run some performance tests (ask the perf team) afterwards. |
mcarare
added a commit
to mcarare/fenix
that referenced
this issue
Nov 17, 2020
mcarare
added a commit
to mcarare/fenix
that referenced
this issue
Nov 18, 2020
mcarare
added a commit
to mcarare/fenix
that referenced
this issue
Nov 18, 2020
mcarare
added a commit
to mcarare/fenix
that referenced
this issue
Nov 18, 2020
mcarare
added a commit
to mcarare/fenix
that referenced
this issue
Nov 18, 2020
ekager
pushed a commit
that referenced
this issue
Nov 18, 2020
ekager
pushed a commit
that referenced
this issue
Nov 18, 2020
For QA: There is no specific testing needed, just check that the layout changes did not introduce any regressions in behavior. Thank you! |
mcarare
added a commit
to mcarare/fenix
that referenced
this issue
Nov 19, 2020
Tested on latest Nightly 11/19 and we didn't encounter any new issue. Devices:
|
Performance, front-end roadmap
automation
moved this from Top 10 Inter-Team bugs
to Done
Nov 19, 2020
mcarare
added a commit
that referenced
this issue
Nov 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Blocked by #15280 & #15644.They are addressed.20ms tabs tray improvement.
Please remove the nested
ConstraintLayout
s in the search screen and tabs tray. From a correctness and performance perspective, ConstraintLayouts are designed to minimize nesting which improves perf and reduces battery use. Ideally, ConstraintLayout is the root element and contains only leaf nodes.We added a custom lint rule #15280 to check for nested ConstraintLayouts. In order to work on this bug:
app/lint-baseline.xml
file (it only contains these violations)./gradlew lintDebug
and check the violation outputWARNING: replacing a ConstraintLayout with several nested ViewGroups is unlikely to improve performance. Remember, a goal is to reduce nesting. If you're unable to remove the extra ConstraintLayout(s) without doing this, it's probably better to suppress this violation.
Please ask the performance team if you have questions!
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: