Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Remove the search widget discoverability experiment from Nightly #15929

Closed
vesta0 opened this issue Oct 15, 2020 · 4 comments
Closed

Remove the search widget discoverability experiment from Nightly #15929

vesta0 opened this issue Oct 15, 2020 · 4 comments
Assignees
Labels
eng:qa:verified QA Verified

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Oct 15, 2020

We were running an experiment in nightly to display an in-product prompt to help users learn about the Search Widget and install it. The experiment ended back in July but we haven't removed the experiment from Nightly.

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 15, 2020
@liuche liuche removed the needs:triage Issue needs triage label Oct 15, 2020
@liuche
Copy link
Contributor

liuche commented Oct 15, 2020

related PR: #11614 (though there were probably other parts of this) and original issue #9488.

We can keep the search widget style changes, but just turn off the Experiment.

@liuche liuche added the hershey label Oct 15, 2020
@mcarare
Copy link
Contributor

mcarare commented Oct 20, 2020

@liuche Does this mean removing the entire CFR? Or should we just adjust the booleans in order to never show it?
The answer is also relevant to this: #12901 if it should be fixed or it does not make sense to do it. Thank you!

@mcarare mcarare added this to Waiting in Hershey's 🍫 Oct 20, 2020
@liuche
Copy link
Contributor

liuche commented Oct 20, 2020

Thanks for linking that issue! We should remove this specific CFR (and strings) so that it doesn't show anymore. We also should remove any place where this is querying Experimenter to determine what branch to be in, because that experiment is being sent in telemetry (and we've finished with it).

I haven't looked at the code but if it's a new CFR type, we probably want to keep the CFR type/class so that we could show a similar tip to this. However, if it's hard-coded but this full-screen CFR is simple enough, might be worthwhile to remove it.

@mcarare mcarare self-assigned this Oct 21, 2020
@mcarare mcarare moved this from Waiting to In Progress in Hershey's 🍫 Oct 21, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Oct 21, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Oct 21, 2020
@mcarare mcarare moved this from In Progress to In Dev Review in Hershey's 🍫 Oct 21, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Oct 21, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Oct 21, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Oct 21, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Oct 21, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Oct 22, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Oct 22, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Oct 22, 2020
liuche pushed a commit that referenced this issue Oct 28, 2020
…6081)

* For #15929: Remove SearchWidgetCFR telemetry.

* For #15929: Remove SearchWidgetCFR and search widget experiment.

* For #15929: Remove unit tests references to search widget experiment.
@mcarare mcarare moved this from In Dev Review to QA Review in Hershey's 🍫 Oct 29, 2020
@mcarare mcarare added the eng:qa:needed QA Needed label Nov 2, 2020
@ebalazs-sv
Copy link

Verified as fixed on Nightly 201103 05:01 (Build #2015773417) GV 84 from 11/3 with

  • Motorola Moto G6 (Android 8);
  • Pixel 2 (Android 9);
  • Samsung Galaxy Tab S3 (Android 8).

I will remove the qa:needed label and close this issue.

@ebalazs-sv ebalazs-sv added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Nov 3, 2020
@mcarare mcarare moved this from QA Review to Done Sprint 83.2 in Hershey's 🍫 Nov 4, 2020
@mcarare mcarare moved this from Done Sprint 83.2 to Done in Hershey's 🍫 Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified
Projects
No open projects
Development

No branches or pull requests

4 participants