Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Sort Downloads from newest to oldest #15931

Closed
topotropic opened this issue Oct 15, 2020 · 7 comments
Closed

Sort Downloads from newest to oldest #15931

topotropic opened this issue Oct 15, 2020 · 7 comments
Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Download
Projects
Fenix Product Backlog

Comments

@topotropic
Copy link

topotropic commented Oct 15, 2020 •
edited by data-sync-user

People go to their download folder to find what they downloaded recently. Currently, downloads are sorted oldest to newest and people have to scroll to find what they recently downloaded. We should reverse the sorting to make it quicker to find recently downloaded items.

┆Issue is synchronized with this Jira Task
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 15, 2020
@vesta0 vesta0 added eng:ready Ready for engineering and removed needs:triage Issue needs triage labels Oct 15, 2020
@Amejia481
Copy link
Contributor

We exposed the property createdTime on DownloadState, we should just sort the list of the downloads using this property :)

@joc-a
Copy link
Contributor

joc-a commented Oct 15, 2020

I'd like to pick this up!

@Amejia481
Copy link
Contributor

Go for it :)

joc-a added a commit to joc-a/fenix that referenced this issue Oct 15, 2020
@joc-a
For mozilla-mobile#15931: Sort Downloads from newest to oldest
2b63e5f 
sort downloads from newest to oldest based on createdTime
joc-a added a commit to joc-a/fenix that referenced this issue Oct 15, 2020
@joc-a
For mozilla-mobile#15931: Sort Downloads from newest to oldest
9c15f97 
sort downloads from newest to oldest based on createdTime
@Poopooracoocoo
Copy link

darn github doesn't seem to link issues when they're referenced in the title of a PR. #15939

joc-a added a commit to joc-a/fenix that referenced this issue Oct 16, 2020
@joc-a
For mozilla-mobile#15931: Sort Downloads from newest to oldest
a59dc6c 
sort downloads from newest to oldest based on createdTime
@anotherus3r
Copy link

anotherus3r commented Oct 16, 2020 •
edited

Kinda related: #14894

(Edit: fixed issue number)

joc-a added a commit to joc-a/fenix that referenced this issue Oct 21, 2020
@joc-a
For mozilla-mobile#15931: Sort Downloads from newest to oldest
78f6cf6 
sort downloads from newest to oldest based on createdTime
joc-a added a commit to joc-a/fenix that referenced this issue Oct 25, 2020
@joc-a
For mozilla-mobile#15931: Sort Downloads from newest to oldest
969e714 
sort downloads from newest to oldest based on createdTime
joc-a added a commit to joc-a/fenix that referenced this issue Oct 25, 2020
@joc-a
For mozilla-mobile#15931: Sort Downloads from newest to oldest
bcc22fe 
add a test to make sure downloads are sorted from newest to oldest
joc-a added a commit to joc-a/fenix that referenced this issue Oct 26, 2020
@joc-a
For mozilla-mobile#15931: Sort Downloads from newest to oldest
e362103 
add a test to make sure downloads are sorted from newest to oldest
gabrielluong pushed a commit that referenced this issue Nov 2, 2020
@joc-a
For #15931: Sort Downloads from newest to oldest (#15939)
1b20415
@gabrielluong gabrielluong added the eng:qa:needed QA Needed label Nov 2, 2020
@sflorean
Copy link
Contributor

sflorean commented Nov 3, 2020

Verified as fixed on Nightly 11/3 with Pixel 3 (Android 11) and LG G7 FIT (Android 8).

@sflorean sflorean closed this as completed Nov 3, 2020
@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Nov 3, 2020
@Amejia481
Copy link
Contributor

Thanks @sflorean !
Awesome work @Poopooracoocoo!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Download
Projects
Fenix Product Backlog
Q4
Milestone
No milestone
Development

No branches or pull requests
8 participants
@topotropic @Amejia481 @gabrielluong @anotherus3r @joc-a @vesta0 @Poopooracoocoo @sflorean