Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Suggest search engine selection based on typed text #16044

Closed
brampitoyo opened this issue Oct 20, 2020 · 9 comments
Closed

Suggest search engine selection based on typed text #16044

brampitoyo opened this issue Oct 20, 2020 · 9 comments

Comments

@brampitoyo
Copy link

brampitoyo commented Oct 20, 2020

What is the user problem or growth opportunity you want to see solved?

  • Many people entered keywords into the address bar and waited for auto-suggest options before making a choice
  • Many people entered a search engine name into the address bar and manually go there, but they ultimately want to perform a one-time search using that search engine

By suggesting one-time search engine selection in the address bar results, we can help people perform their search faster.

Behaviour

  • Search engine suggestion appears first on the list, ahead of the first (verbatim) search suggestion
  • Search engine suggestion only appears when autocomplete matches a search engine name or URL
    • Typing “t” autocompletes to “twitter.com”
    • When this happens, show a suggestion labelled “Search Twitter”
  • When tapped, the search engine suggestion allows users to change their search engine on a one-time basis

String

  • If an engine searches “the internet” (examples: Google, Bing, DuckDuckGo), the string should say:
    • Search with [providerName]
    • Examples: “Search with Google”, “Search with Bing”
  • If an engine searches “the site itself” (examples: Twitter, Wikipedia, YouTube), the string should say:
    • Search [providerName]
    • Examples: “Search with Twitter”, “Search with Wikipedia”
  • Underneath the label, there’s a caption. The string should say:
    • Search directly from the address bar

Mockups

On Autocomplete After tapping “Search [providerName]”
Search Engine Autocomplete - Google@2x Search Engine Autocomplete - Amazon 4@2x

Ping @Verdi: I couldn’t get the provider name on the caption, because that would make the caption run too long. Would it be okay to omit it?

Assets

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 20, 2020
@liuche liuche removed the needs:triage Issue needs triage label Oct 28, 2020
@liuche liuche added this to Inbox in Engineering triage via automation Oct 28, 2020
@liuche liuche removed this from Inbox in Engineering triage Nov 5, 2020
@mcarare mcarare added needs:ac Needs Android Component Work Feature:SearchProvider labels Dec 22, 2020
@mcarare
Copy link
Contributor

mcarare commented Dec 24, 2020

@brampitoyo I have several questions regarding this feature:

  1. I suppose search engine suggestions should be based on the user's engine list ( including custom engines)? If so, could 2 or more suggestions should be displayed? Or should it be limited to one suggestion?

  2. The autocompleted text is not a reliable identifier for the search engine, as they are identified by name, not by the URL that is autocompleted. For example, Bing is identified by the name "bing", not by the autocompleted URL "bing.com". Should we show the suggestion when the entered text matches (entirely or partially) a search engine name?

  3. This seems like the same feature as selecting a search engine for one time use by selecting it from the "search engine" toggle list. Should we also change the hint on the address bar for that use case, to match the one described in this issue?

  4. We don't have a reliable/ universal way to distinguish between engines that search the Internet or the ones that search within a site. What should de hint text be in that case?

@mcarare mcarare self-assigned this Jan 4, 2021
@mcarare mcarare added the needs:UX-feedback Needs UX Feedback label Jan 5, 2021
@mcarare mcarare added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Jan 14, 2021
@mcarare mcarare added this to New Features/Functions (top 20) in Android Team Backlog Staging Board Jan 15, 2021
@brampitoyo
Copy link
Author

Hi @mcarare, answering your questions inline:

  1. Only one suggestion should be displayed
  2. I didn’t know that a search engine is identified by a name rather than a URL. I would prefer the suggestion to be shown based on the URL. If we rely solely on name matching, people who type “bing.com” won’t get the suggestion. We want them to see the suggestion, even if the full URL is already entered.
  3. For the time being, I don’t think we need to change the hint text for the other use case.
  4. For the time being, let’s not worry about distinguishing between different types of search engine. We can just use the same string: “Search with [providerName]”

@mcarare
Copy link
Contributor

mcarare commented Jan 25, 2021

If we rely solely on name matching, people who type “bing.com” won’t get the suggestion.

They will see it because the search suggestions appear as you type. But I will try to implement your design.

Thank you for your response! 👍

@mcarare mcarare removed needs:UX-feedback Needs UX Feedback 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Jan 25, 2021
@mcarare mcarare added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Jan 26, 2021
@mcarare mcarare moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Jan 26, 2021
@mcarare mcarare removed this from New Features/Functions (top 20) in Android Team Backlog Staging Board Jan 26, 2021
@mcarare
Copy link
Contributor

mcarare commented Jan 26, 2021

@bram On implementing this, I came across some cases when maybe using the autocomplete text not the typed one might not give us the expected result.

Let's say for example you visit binge.com . Then, when you type b, bi, bin, bing you would not get autocomplete to bing.com but to binge.com which would mean you will never get a search engine suggestion for Bing.

This would also apply to various scenarios when you will not autocomplete to a search engine except after typing many more letters to exclude autocompleting to a history or places URL.

If this is expected and we only want search engine suggestions for autocomplete I will go ahead with this implementation.

On the other hand, in the case described above, if using the entered text, by doing a partial matching we could suggest bing.
The only question would be when would we consider a match (from one letter, two or more, etc.)

What do you think?

@mcarare mcarare added the needs:UX-feedback Needs UX Feedback label Jan 26, 2021
@mcarare mcarare moved this from In Development (WIP limit - 15) to In Tech Design (WIP limit - ?) in Android Engineering Team Kanban board Jan 26, 2021
@brampitoyo
Copy link
Author

Hi @mcarare,

TL;DR: Yes, we only want search engine suggestions for autocomplete, but history items should always be ranked lower than hardcoded autocomplete and search engine entries. Right now, mobile ranks them higher.

I think the way mobile does autocomplete differs from desktop.

On desktop, even after I visited binge.com many times, typing bi will always show items in this order:

  • Address bar: bing.com
  • Item 1: bing.com (the autocomplete entry – hardcoded by the browser)
  • Item 2: Search with Bing (the search engine entry – hardcoded by the browser)
  • Item 3: `binge.com (the history entry)

Ideally, when I type bi on Fenix or Firefox for iOS, I also want to see things in the same order, except we don’t need bing.com repeated as item 1 (it’s already in the address bar):

  • Address bar: bing.com
  • Item 1: Search with Bing
  • Item 2: binge.com

In other words: my history item should always appear lower than the hardcoded entries, but at the moment, it appears higher.

Maybe we should leave the fix as is, and then file another issue for tweaking the autocomplete recipe?

@mcarare
Copy link
Contributor

mcarare commented Feb 1, 2021

@brampitoyo This would be another issue, the autocomplete order. The question is if we should roll this issue before or after reorganizing autocomplete.

As a note: I do not see bing at all in suggestions when I use Firefox desktop and type bi (except in "this time search with"). The first entry and the autocomplete comes from history:

Screen Shot 2021-02-01 at 10 14 17 AM

@brampitoyo
Copy link
Author

Hi @mcarare,

TL;DR – The behaviour you proposed was already perfect, and the bugs you’ve found was by design. There’s nothing to fix. Sorry for the trouble!

I’ve confirmed with Desktop Search UX that we want frecency to always “win” over any system-hardcoded value.

This means: in all the cases you demonstrated, the only way to get Bing to autocomplete and appear as a “Search with” item, is to type bing. (bing + .).

Otherwise, either binge.com or bibnat.ro will take over. And this is by design. If people are visiting a certain site a lot, we don’t want to block them by presenting our own hardcoded sites every single time. This would block them from getting to where they want to go.

So, the initial behaviour you proposed turned out to be correct. And ultimately, I was wrong for proposing that hardcoded entries should “win”. Sorry about this!

@mcarare mcarare changed the title If address bar autocomplete matches search engine URL, suggest search engine selection Suggest search engine selection based on typed text Feb 5, 2021
@mcarare
Copy link
Contributor

mcarare commented Feb 5, 2021

Talked with @brampitoyo offline and we shall go ahead with using typed text instead of autocompleted text in order to avoid cases where we could not get a suggestion.

@mcarare mcarare moved this from In Tech Design (WIP limit - ?) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Feb 10, 2021
@mcarare mcarare removed the needs:UX-feedback Needs UX Feedback label Feb 16, 2021
@mcarare mcarare moved this from In Development (WIP limit - 15) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Feb 17, 2021
@mcarare mcarare moved this from Dev Complete (WIP limit - 5) to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board Feb 24, 2021
@mcarare mcarare added the eng:qa:needed QA Needed label Feb 24, 2021
@LaurentiuApahideanSV
Copy link

LaurentiuApahideanSV commented Feb 25, 2021

Verified as fixed on Firefox Preview Nightly 210225 (Build #2015795331), I'll close this as verified..

Devices used:

  • OnePlus 6T (Android 9)
  • Google Pixel 3 XL (Android 9)

@LaurentiuApahideanSV LaurentiuApahideanSV added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Feb 25, 2021
Android Engineering Team Kanban board automation moved this from Reviewer approved, ready for test (WIP limit - ?) to Done Feb 25, 2021
@amedyne amedyne added this to the 88 milestone Feb 26, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Development

No branches or pull requests

5 participants