-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Suggest search engine selection based on typed text #16044
Comments
@brampitoyo I have several questions regarding this feature:
|
Hi @mcarare, answering your questions inline:
|
They will see it because the search suggestions appear as you type. But I will try to implement your design. Thank you for your response! 👍 |
@bram On implementing this, I came across some cases when maybe using the autocomplete text not the typed one might not give us the expected result. Let's say for example you visit This would also apply to various scenarios when you will not autocomplete to a search engine except after typing many more letters to exclude autocompleting to a history or places URL. If this is expected and we only want search engine suggestions for autocomplete I will go ahead with this implementation. On the other hand, in the case described above, if using the entered text, by doing a partial matching we could suggest bing. What do you think? |
Hi @mcarare, TL;DR: Yes, we only want search engine suggestions for autocomplete, but history items should always be ranked lower than hardcoded autocomplete and search engine entries. Right now, mobile ranks them higher. I think the way mobile does autocomplete differs from desktop. On desktop, even after I visited
Ideally, when I type
In other words: my history item should always appear lower than the hardcoded entries, but at the moment, it appears higher. Maybe we should leave the fix as is, and then file another issue for tweaking the autocomplete recipe? |
@brampitoyo This would be another issue, the autocomplete order. The question is if we should roll this issue before or after reorganizing autocomplete. As a note: I do not see |
Hi @mcarare, TL;DR – The behaviour you proposed was already perfect, and the bugs you’ve found was by design. There’s nothing to fix. Sorry for the trouble! I’ve confirmed with Desktop Search UX that we want frecency to always “win” over any system-hardcoded value. This means: in all the cases you demonstrated, the only way to get Bing to autocomplete and appear as a “Search with” item, is to type Otherwise, either So, the initial behaviour you proposed turned out to be correct. And ultimately, I was wrong for proposing that hardcoded entries should “win”. Sorry about this! |
Talked with @brampitoyo offline and we shall go ahead with using typed text instead of autocompleted text in order to avoid cases where we could not get a suggestion. |
Verified as fixed on Firefox Preview Nightly 210225 (Build #2015795331), I'll close this as verified.. Devices used:
|
What is the user problem or growth opportunity you want to see solved?
By suggesting one-time search engine selection in the address bar results, we can help people perform their search faster.
Behaviour
String
Mockups
Ping @Verdi: I couldn’t get the provider name on the caption, because that would make the caption run too long. Would it be okay to omit it?
Assets
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: